From: Aryeh Gregor <simetrical@users.mediawiki.org>
Date: Tue, 22 Apr 2008 01:05:15 +0000 (+0000)
Subject: (bug 13816) Filter by main namespace doesn't work on WhatLinksHere.  Guess why? ... 
X-Git-Tag: 1.31.0-rc.0~48142
X-Git-Url: http://git.cyclocoop.org/%22.%28%24lien.?a=commitdiff_plain;h=ce498470531415c7c8161f6ca063c473f8124420;p=lhc%2Fweb%2Fwiklou.git

(bug 13816) Filter by main namespace doesn't work on WhatLinksHere.  Guess why?  Weak PHP typing!  I want to assemble a list of all these bugs as a concrete example of why PHP sucks.
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 5e1ebcb36a..e6081eec3e 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -208,6 +208,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * Fix fatal error on calling PAGESINCATEGORY with invalid category name
 * (bug 13793) Special:Whatlinkshere filters wrong - after paginating instead of before
 * (bug 13796) Show links to parent pages even if some of them are missing
+* (bug 13816) Filter by main namespace doesn't work on WhatLinksHere
 
 === API changes in 1.13 ===
 
diff --git a/includes/FormOptions.php b/includes/FormOptions.php
index f708b4a861..8c7849e8e6 100644
--- a/includes/FormOptions.php
+++ b/includes/FormOptions.php
@@ -154,10 +154,10 @@ class FormOptions {
 					throw new MWException( 'Unsupported datatype' );
 			}
 
-			if ( $value !== $default && $value != null ) {
+			if ( $value !== $default && $value !== null ) {
 				$this->options[$name]['value'] = $value;
 			}
 		}
 	}
 
-}
\ No newline at end of file
+}