UserTest: Don't rely on the behavior of unknown user options
authorBartosz Dziewoński <matma.rex@gmail.com>
Sat, 20 Sep 2014 16:56:04 +0000 (18:56 +0200)
committerBartosz Dziewoński <matma.rex@gmail.com>
Sat, 20 Sep 2014 16:56:31 +0000 (18:56 +0200)
They are not actually expected to be preserved, although they might be.

Change-Id: I34e15f3d1e5b9b825e6fc14814c8e9a6ac151ce9

tests/phpunit/includes/UserTest.php

index 933fed0..5be1b96 100644 (file)
@@ -250,12 +250,12 @@ class UserTest extends MediaWikiTestCase {
                $user = User::newFromName( 'UnitTestUser' );
                $user->addToDatabase();
 
-               $user->setOption( 'someoption', 'test' );
+               $user->setOption( 'userjs-someoption', 'test' );
                $user->setOption( 'cols', 200 );
                $user->saveSettings();
 
                $user = User::newFromName( 'UnitTestUser' );
-               $this->assertEquals( 'test', $user->getOption( 'someoption' ) );
+               $this->assertEquals( 'test', $user->getOption( 'userjs-someoption' ) );
                $this->assertEquals( 200, $user->getOption( 'cols' ) );
        }
 
@@ -266,9 +266,9 @@ class UserTest extends MediaWikiTestCase {
         */
        public function testAnonOptions() {
                global $wgDefaultUserOptions;
-               $this->user->setOption( 'someoption', 'test' );
+               $this->user->setOption( 'userjs-someoption', 'test' );
                $this->assertEquals( $wgDefaultUserOptions['cols'], $this->user->getOption( 'cols' ) );
-               $this->assertEquals( 'test', $this->user->getOption( 'someoption' ) );
+               $this->assertEquals( 'test', $this->user->getOption( 'userjs-someoption' ) );
        }
 
        /**