3 use Wikimedia\Rdbms\Database
;
4 use Wikimedia\Rdbms\IDatabase
;
5 use Wikimedia\Rdbms\DatabaseMysqli
;
6 use Wikimedia\Rdbms\LBFactorySingle
;
7 use Wikimedia\Rdbms\TransactionProfiler
;
8 use Wikimedia\TestingAccessWrapper
;
9 use Wikimedia\Rdbms\DatabaseSqlite
;
10 use Wikimedia\Rdbms\DatabasePostgres
;
11 use Wikimedia\Rdbms\DatabaseMssql
;
13 class DatabaseTest
extends PHPUnit\Framework\TestCase
{
15 use MediaWikiCoversValidator
;
17 protected function setUp() {
18 $this->db
= new DatabaseTestHelper( __CLASS__
. '::' . $this->getName() );
22 * @dataProvider provideAddQuotes
23 * @covers Wikimedia\Rdbms\Database::factory
25 public function testFactory() {
26 $m = Database
::NEW_UNCONNECTED
; // no-connect mode
27 $p = [ 'host' => 'localhost', 'user' => 'me', 'password' => 'myself', 'dbname' => 'i' ];
29 $this->assertInstanceOf( DatabaseMysqli
::class, Database
::factory( 'mysqli', $p, $m ) );
30 $this->assertInstanceOf( DatabaseMysqli
::class, Database
::factory( 'MySqli', $p, $m ) );
31 $this->assertInstanceOf( DatabaseMysqli
::class, Database
::factory( 'MySQLi', $p, $m ) );
32 $this->assertInstanceOf( DatabasePostgres
::class, Database
::factory( 'postgres', $p, $m ) );
33 $this->assertInstanceOf( DatabasePostgres
::class, Database
::factory( 'Postgres', $p, $m ) );
35 $x = $p +
[ 'port' => 10000, 'UseWindowsAuth' => false ];
36 $this->assertInstanceOf( DatabaseMssql
::class, Database
::factory( 'mssql', $x, $m ) );
38 $x = $p +
[ 'dbFilePath' => 'some/file.sqlite' ];
39 $this->assertInstanceOf( DatabaseSqlite
::class, Database
::factory( 'sqlite', $x, $m ) );
40 $x = $p +
[ 'dbDirectory' => 'some/file' ];
41 $this->assertInstanceOf( DatabaseSqlite
::class, Database
::factory( 'sqlite', $x, $m ) );
44 public static function provideAddQuotes() {
48 [ 1234.5678, "'1234.5678'" ],
49 [ 'string', "'string'" ],
50 [ 'string\'s cause trouble', "'string\'s cause trouble'" ],
55 * @dataProvider provideAddQuotes
56 * @covers Wikimedia\Rdbms\Database::addQuotes
58 public function testAddQuotes( $input, $expected ) {
59 $this->assertEquals( $expected, $this->db
->addQuotes( $input ) );
62 public static function provideTableName() {
63 // Formatting is mostly ignored since addIdentifierQuotes is abstract.
64 // For testing of addIdentifierQuotes, see actual Database subclas tests.
80 [ 'dbname' => 'sharedb', 'schema' => null, 'prefix' => '' ],
86 [ 'dbname' => 'sharedb', 'schema' => null, 'prefix' => '' ],
89 'sharedb.sh_tablename',
92 [ 'dbname' => 'sharedb', 'schema' => null, 'prefix' => 'sh_' ],
94 'shared-prefix-raw' => [
95 'sharedb.sh_tablename',
98 [ 'dbname' => 'sharedb', 'schema' => null, 'prefix' => 'sh_' ],
101 'databasename.tablename',
102 'databasename.tablename',
106 'databasename.tablename',
107 'databasename.tablename',
114 * @dataProvider provideTableName
115 * @covers Wikimedia\Rdbms\Database::tableName
117 public function testTableName( $expected, $table, $format, array $alias = null ) {
119 $this->db
->setTableAliases( [ $table => $alias ] );
123 $this->db
->tableName( $table, $format ?
: 'quoted' )
127 public function provideTableNamesWithIndexClauseOrJOIN() {
129 'one-element array' => [
130 [ 'table' ], [], 'table '
133 [ 'table1', 'table2' ], [], 'table1,table2 '
136 [ 'table1', 'table2' ],
137 [ 'table2' => [ 'LEFT JOIN', 't1_id = t2_id' ] ],
138 'table1 LEFT JOIN table2 ON ((t1_id = t2_id))'
140 'real join with multiple conditionals' => [
141 [ 'table1', 'table2' ],
142 [ 'table2' => [ 'LEFT JOIN', [ 't1_id = t2_id', 't2_x = \'X\'' ] ] ],
143 'table1 LEFT JOIN table2 ON ((t1_id = t2_id) AND (t2_x = \'X\'))'
145 'join with parenthesized group' => [
146 [ 'table1', 'n' => [ 'table2', 'table3' ] ],
148 'table3' => [ 'JOIN', 't2_id = t3_id' ],
149 'n' => [ 'LEFT JOIN', 't1_id = t2_id' ],
151 'table1 LEFT JOIN (table2 JOIN table3 ON ((t2_id = t3_id))) ON ((t1_id = t2_id))'
153 'join with degenerate parenthesized group' => [
154 [ 'table1', 'n' => [ 't2' => 'table2' ] ],
156 'n' => [ 'LEFT JOIN', 't1_id = t2_id' ],
158 'table1 LEFT JOIN table2 t2 ON ((t1_id = t2_id))'
164 * @dataProvider provideTableNamesWithIndexClauseOrJOIN
165 * @covers Wikimedia\Rdbms\Database::tableNamesWithIndexClauseOrJOIN
167 public function testTableNamesWithIndexClauseOrJOIN( $tables, $join_conds, $expect ) {
168 $clause = TestingAccessWrapper
::newFromObject( $this->db
)
169 ->tableNamesWithIndexClauseOrJOIN( $tables, [], [], $join_conds );
170 $this->assertSame( $expect, $clause );
174 * @covers Wikimedia\Rdbms\Database::onTransactionIdle
175 * @covers Wikimedia\Rdbms\Database::runOnTransactionIdleCallbacks
177 public function testTransactionIdle() {
180 $db->setFlag( DBO_TRX
);
183 $db->onTransactionIdle(
184 function () use ( $db, &$flagSet, &$called ) {
186 $flagSet = $db->getFlag( DBO_TRX
);
190 $this->assertFalse( $flagSet, 'DBO_TRX off in callback' );
191 $this->assertTrue( $db->getFlag( DBO_TRX
), 'DBO_TRX restored to default' );
192 $this->assertTrue( $called, 'Callback reached' );
194 $db->clearFlag( DBO_TRX
);
196 $db->onTransactionIdle(
197 function () use ( $db, &$flagSet ) {
198 $flagSet = $db->getFlag( DBO_TRX
);
202 $this->assertFalse( $flagSet, 'DBO_TRX off in callback' );
203 $this->assertFalse( $db->getFlag( DBO_TRX
), 'DBO_TRX restored to default' );
205 $db->clearFlag( DBO_TRX
);
206 $db->onTransactionIdle(
207 function () use ( $db ) {
208 $db->setFlag( DBO_TRX
);
212 $this->assertFalse( $db->getFlag( DBO_TRX
), 'DBO_TRX restored to default' );
216 * @covers Wikimedia\Rdbms\Database::onTransactionPreCommitOrIdle
217 * @covers Wikimedia\Rdbms\Database::runOnTransactionPreCommitCallbacks
219 public function testTransactionPreCommitOrIdle() {
220 $db = $this->getMockDB( [ 'isOpen' ] );
221 $db->method( 'isOpen' )->willReturn( true );
222 $db->clearFlag( DBO_TRX
);
224 $this->assertFalse( $db->getFlag( DBO_TRX
), 'DBO_TRX is not set' );
227 $db->onTransactionPreCommitOrIdle(
228 function () use ( &$called ) {
233 $this->assertTrue( $called, 'Called when idle' );
235 $db->begin( __METHOD__
);
237 $db->onTransactionPreCommitOrIdle(
238 function () use ( &$called ) {
243 $this->assertFalse( $called, 'Not called when transaction is active' );
244 $db->commit( __METHOD__
);
245 $this->assertTrue( $called, 'Called when transaction is committed' );
249 * @covers Wikimedia\Rdbms\Database::onTransactionPreCommitOrIdle
250 * @covers Wikimedia\Rdbms\Database::runOnTransactionPreCommitCallbacks
252 public function testTransactionPreCommitOrIdle_TRX() {
253 $db = $this->getMockDB( [ 'isOpen' ] );
254 $db->method( 'isOpen' )->willReturn( true );
255 $db->setFlag( DBO_TRX
);
257 $lbFactory = LBFactorySingle
::newFromConnection( $db );
258 // Ask for the connectin so that LB sets internal state
259 // about this connection being the master connection
260 $lb = $lbFactory->getMainLB();
261 $conn = $lb->openConnection( $lb->getWriterIndex() );
262 $this->assertSame( $db, $conn, 'Same DB instance' );
263 $this->assertTrue( $db->getFlag( DBO_TRX
), 'DBO_TRX is set' );
266 $db->onTransactionPreCommitOrIdle(
267 function () use ( &$called ) {
271 $this->assertFalse( $called, 'Not called when idle if DBO_TRX is set' );
273 $lbFactory->beginMasterChanges( __METHOD__
);
274 $this->assertFalse( $called, 'Not called when lb-transaction is active' );
276 $lbFactory->commitMasterChanges( __METHOD__
);
277 $this->assertTrue( $called, 'Called when lb-transaction is committed' );
281 * @covers Wikimedia\Rdbms\Database::onTransactionResolution
282 * @covers Wikimedia\Rdbms\Database::runOnTransactionIdleCallbacks
284 public function testTransactionResolution() {
287 $db->clearFlag( DBO_TRX
);
288 $db->begin( __METHOD__
);
290 $db->onTransactionResolution( function () use ( $db, &$called ) {
292 $db->setFlag( DBO_TRX
);
294 $db->commit( __METHOD__
);
295 $this->assertFalse( $db->getFlag( DBO_TRX
), 'DBO_TRX restored to default' );
296 $this->assertTrue( $called, 'Callback reached' );
298 $db->clearFlag( DBO_TRX
);
299 $db->begin( __METHOD__
);
301 $db->onTransactionResolution( function () use ( $db, &$called ) {
303 $db->setFlag( DBO_TRX
);
305 $db->rollback( __METHOD__
, IDatabase
::FLUSHING_ALL_PEERS
);
306 $this->assertFalse( $db->getFlag( DBO_TRX
), 'DBO_TRX restored to default' );
307 $this->assertTrue( $called, 'Callback reached' );
311 * @covers Wikimedia\Rdbms\Database::setTransactionListener
313 public function testTransactionListener() {
316 $db->setTransactionListener( 'ping', function () use ( $db, &$called ) {
321 $db->begin( __METHOD__
);
322 $db->commit( __METHOD__
);
323 $this->assertTrue( $called, 'Callback reached' );
326 $db->begin( __METHOD__
);
327 $db->commit( __METHOD__
);
328 $this->assertTrue( $called, 'Callback still reached' );
331 $db->begin( __METHOD__
);
332 $db->rollback( __METHOD__
);
333 $this->assertTrue( $called, 'Callback reached' );
335 $db->setTransactionListener( 'ping', null );
337 $db->begin( __METHOD__
);
338 $db->commit( __METHOD__
);
339 $this->assertFalse( $called, 'Callback not reached' );
343 * Use this mock instead of DatabaseTestHelper for cases where
344 * DatabaseTestHelper is too inflexibile due to mocking too much
345 * or being too restrictive about fname matching (e.g. for tests
346 * that assert behaviour when the name is a mismatch, we need to
347 * catch the error here instead of there).
351 private function getMockDB( $methods = [] ) {
352 static $abstractMethods = [
353 'fetchAffectedRowCount',
357 'fetchObject', 'fetchRow',
358 'fieldInfo', 'fieldName',
359 'getSoftwareLink', 'getServerVersion',
363 'lastError', 'lastErrno',
364 'numFields', 'numRows',
368 $db = $this->getMockBuilder( Database
::class )
369 ->disableOriginalConstructor()
370 ->setMethods( array_values( array_unique( array_merge(
375 $wdb = TestingAccessWrapper
::newFromObject( $db );
376 $wdb->trxProfiler
= new TransactionProfiler();
377 $wdb->connLogger
= new \Psr\Log\
NullLogger();
378 $wdb->queryLogger
= new \Psr\Log\
NullLogger();
383 * @covers Wikimedia\Rdbms\Database::flushSnapshot
385 public function testFlushSnapshot() {
386 $db = $this->getMockDB( [ 'isOpen' ] );
387 $db->method( 'isOpen' )->willReturn( true );
389 $db->flushSnapshot( __METHOD__
); // ok
390 $db->flushSnapshot( __METHOD__
); // ok
392 $db->setFlag( DBO_TRX
, $db::REMEMBER_PRIOR
);
393 $db->query( 'SELECT 1', __METHOD__
);
394 $this->assertTrue( (bool)$db->trxLevel(), "Transaction started." );
395 $db->flushSnapshot( __METHOD__
); // ok
396 $db->restoreFlags( $db::RESTORE_PRIOR
);
398 $this->assertFalse( (bool)$db->trxLevel(), "Transaction cleared." );
402 * @covers Wikimedia\Rdbms\Database::getScopedLockAndFlush
403 * @covers Wikimedia\Rdbms\Database::lock
404 * @covers Wikimedia\Rdbms\Database::unlock
405 * @covers Wikimedia\Rdbms\Database::lockIsFree
407 public function testGetScopedLock() {
408 $db = $this->getMockDB( [ 'isOpen' ] );
409 $db->method( 'isOpen' )->willReturn( true );
411 $this->assertEquals( 0, $db->trxLevel() );
412 $this->assertEquals( true, $db->lockIsFree( 'x', __METHOD__
) );
413 $this->assertEquals( true, $db->lock( 'x', __METHOD__
) );
414 $this->assertEquals( false, $db->lockIsFree( 'x', __METHOD__
) );
415 $this->assertEquals( true, $db->unlock( 'x', __METHOD__
) );
416 $this->assertEquals( true, $db->lockIsFree( 'x', __METHOD__
) );
417 $this->assertEquals( 0, $db->trxLevel() );
419 $db->setFlag( DBO_TRX
);
420 $this->assertEquals( true, $db->lockIsFree( 'x', __METHOD__
) );
421 $this->assertEquals( true, $db->lock( 'x', __METHOD__
) );
422 $this->assertEquals( false, $db->lockIsFree( 'x', __METHOD__
) );
423 $this->assertEquals( true, $db->unlock( 'x', __METHOD__
) );
424 $this->assertEquals( true, $db->lockIsFree( 'x', __METHOD__
) );
425 $db->clearFlag( DBO_TRX
);
427 $this->assertEquals( 0, $db->trxLevel() );
429 $db->setFlag( DBO_TRX
);
431 $this->badLockingMethodImplicit( $db );
432 } catch ( RunTimeException
$e ) {
433 $this->assertTrue( $db->trxLevel() > 0, "Transaction not committed." );
435 $db->clearFlag( DBO_TRX
);
436 $db->rollback( __METHOD__
, IDatabase
::FLUSHING_ALL_PEERS
);
437 $this->assertTrue( $db->lockIsFree( 'meow', __METHOD__
) );
440 $this->badLockingMethodExplicit( $db );
441 } catch ( RunTimeException
$e ) {
442 $this->assertTrue( $db->trxLevel() > 0, "Transaction not committed." );
444 $db->rollback( __METHOD__
, IDatabase
::FLUSHING_ALL_PEERS
);
445 $this->assertTrue( $db->lockIsFree( 'meow', __METHOD__
) );
448 private function badLockingMethodImplicit( IDatabase
$db ) {
449 $lock = $db->getScopedLockAndFlush( 'meow', __METHOD__
, 1 );
450 $db->query( "SELECT 1" ); // trigger DBO_TRX
451 throw new RunTimeException( "Uh oh!" );
454 private function badLockingMethodExplicit( IDatabase
$db ) {
455 $lock = $db->getScopedLockAndFlush( 'meow', __METHOD__
, 1 );
456 $db->begin( __METHOD__
);
457 throw new RunTimeException( "Uh oh!" );
461 * @covers Wikimedia\Rdbms\Database::getFlag
462 * @covers Wikimedia\Rdbms\Database::setFlag
463 * @covers Wikimedia\Rdbms\Database::restoreFlags
465 public function testFlagSetting() {
467 $origTrx = $db->getFlag( DBO_TRX
);
468 $origSsl = $db->getFlag( DBO_SSL
);
471 ?
$db->clearFlag( DBO_TRX
, $db::REMEMBER_PRIOR
)
472 : $db->setFlag( DBO_TRX
, $db::REMEMBER_PRIOR
);
473 $this->assertEquals( !$origTrx, $db->getFlag( DBO_TRX
) );
476 ?
$db->clearFlag( DBO_SSL
, $db::REMEMBER_PRIOR
)
477 : $db->setFlag( DBO_SSL
, $db::REMEMBER_PRIOR
);
478 $this->assertEquals( !$origSsl, $db->getFlag( DBO_SSL
) );
480 $db->restoreFlags( $db::RESTORE_INITIAL
);
481 $this->assertEquals( $origTrx, $db->getFlag( DBO_TRX
) );
482 $this->assertEquals( $origSsl, $db->getFlag( DBO_SSL
) );
485 ?
$db->clearFlag( DBO_TRX
, $db::REMEMBER_PRIOR
)
486 : $db->setFlag( DBO_TRX
, $db::REMEMBER_PRIOR
);
488 ?
$db->clearFlag( DBO_SSL
, $db::REMEMBER_PRIOR
)
489 : $db->setFlag( DBO_SSL
, $db::REMEMBER_PRIOR
);
492 $this->assertEquals( $origSsl, $db->getFlag( DBO_SSL
) );
493 $this->assertEquals( !$origTrx, $db->getFlag( DBO_TRX
) );
496 $this->assertEquals( $origSsl, $db->getFlag( DBO_SSL
) );
497 $this->assertEquals( $origTrx, $db->getFlag( DBO_TRX
) );
501 * @expectedException UnexpectedValueException
502 * @covers Wikimedia\Rdbms\Database::setFlag
504 public function testDBOIgnoreSet() {
505 $db = $this->getMockBuilder( DatabaseMysqli
::class )
506 ->disableOriginalConstructor()
510 $db->setFlag( Database
::DBO_IGNORE
);
514 * @expectedException UnexpectedValueException
515 * @covers Wikimedia\Rdbms\Database::clearFlag
517 public function testDBOIgnoreClear() {
518 $db = $this->getMockBuilder( DatabaseMysqli
::class )
519 ->disableOriginalConstructor()
523 $db->clearFlag( Database
::DBO_IGNORE
);
527 * @covers Wikimedia\Rdbms\Database::tablePrefix
528 * @covers Wikimedia\Rdbms\Database::dbSchema
530 public function testMutators() {
531 $old = $this->db
->tablePrefix();
532 $this->assertInternalType( 'string', $old, 'Prefix is string' );
533 $this->assertEquals( $old, $this->db
->tablePrefix(), "Prefix unchanged" );
534 $this->assertEquals( $old, $this->db
->tablePrefix( 'xxx' ) );
535 $this->assertEquals( 'xxx', $this->db
->tablePrefix(), "Prefix set" );
536 $this->db
->tablePrefix( $old );
537 $this->assertNotEquals( 'xxx', $this->db
->tablePrefix() );
539 $old = $this->db
->dbSchema();
540 $this->assertInternalType( 'string', $old, 'Schema is string' );
541 $this->assertEquals( $old, $this->db
->dbSchema(), "Schema unchanged" );
542 $this->assertEquals( $old, $this->db
->dbSchema( 'xxx' ) );
543 $this->assertEquals( 'xxx', $this->db
->dbSchema(), "Schema set" );
544 $this->db
->dbSchema( $old );
545 $this->assertNotEquals( 'xxx', $this->db
->dbSchema() );