Aaron Schulz [Wed, 21 Dec 2011 21:29:16 +0000 (21:29 +0000)]
* FU r106752: unbreak urls to ForeignAPIRepo file thumbnails. FileRepo no longer uses bogus <public root URL>/thumb default for the thumnail URL when the public root URL wasn't even set. This was making ForeignAPIRepo not set it since it saw that it was already set.
* Cleaned up and added some missing sanity checks for scriptDirUrl member in FileRepo. Made some related documentation tweaks.
* Removed pointless getRepo() call in File.
Raimond Spekking [Wed, 21 Dec 2011 20:44:11 +0000 (20:44 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Aaron Schulz [Wed, 21 Dec 2011 20:39:50 +0000 (20:39 +0000)]
* Added FileRepo::SKIP_LOCKING constant and made storeBatch() check it.
* Made File::maybeDoTransform() use the FileRepo::store() and a new File::getThumbRel() function. Looks cleaner and loosens FileBackend coupling.
* Also made storeTemp() use FileRepo::SKIP_LOCKING for performance.
* Killed some useless initZones() calls in FileRepo. Extensions may not even use these zones. Likewise, it could make tests fail even though they don't those zones. We already do the sanity with some prepare() calls in storeBatch().
* Removed FileRepo::SKIP_VALIDATION, not used by anything now.
* Moved getUrlRel() down a bit.
Brion Vibber [Wed, 21 Dec 2011 19:17:39 +0000 (19:17 +0000)]
Code style: move a couple htmlspecialchars() down to usage so it's clear where escaping happens
Roan Kattouw [Wed, 21 Dec 2011 18:58:27 +0000 (18:58 +0000)]
(bug 33246) News icon shown for news:// URLs but not for news: URLs. Patch by Erwin Dokter
Alexandre Emsenhuber [Wed, 21 Dec 2011 18:53:00 +0000 (18:53 +0000)]
Declare constant default values directly in the class definition and removed the constructor since it's useless now
Alexandre Emsenhuber [Wed, 21 Dec 2011 18:46:39 +0000 (18:46 +0000)]
Use LinkCache::singleton()->clear() instead of using a local variable so that I can see what LinkCache::singleton() will be used for directly in grep
Alexandre Emsenhuber [Wed, 21 Dec 2011 18:44:25 +0000 (18:44 +0000)]
* Use local context to get messages
* Use Language::userTimeAndDate() and related instead of Language::timeanddate() where needed
* Factorised some calls to member functions
Alexandre Emsenhuber [Wed, 21 Dec 2011 18:40:02 +0000 (18:40 +0000)]
Use accessor instead of the member variable directly and factorise the calls to it
Antoine Musso [Wed, 21 Dec 2011 15:31:30 +0000 (15:31 +0000)]
tests for r94881 which interprets relative Location: headers
Jeroen De Dauw [Wed, 21 Dec 2011 15:09:01 +0000 (15:09 +0000)]
follow up to r106883, typo fixes
Aaron Schulz [Wed, 21 Dec 2011 10:06:47 +0000 (10:06 +0000)]
Optimized doOperations() a bit to only get SH locks for the paths that aren't already going to get EX locks
Aaron Schulz [Wed, 21 Dec 2011 09:16:28 +0000 (09:16 +0000)]
* Renamed FileBackend functions internal to FileBackend/FileOp, making their usage clearer.
* Added convenience functions to FileBackendBase for basic file ops. Previously, doOperation() was the only convenience function...give it some friends :)
* More documentation comments.
Aaron Schulz [Wed, 21 Dec 2011 08:46:10 +0000 (08:46 +0000)]
Fixed typo in testGetFileList() and used the proper FileBackend function delete
Tim Starling [Wed, 21 Dec 2011 05:49:00 +0000 (05:49 +0000)]
Release notes for r105645.
Jeroen De Dauw [Wed, 21 Dec 2011 01:10:51 +0000 (01:10 +0000)]
actually use the flipping cssclass arg, so its possible to set a css class without creating your own input field type class
Ryan Kaldari [Wed, 21 Dec 2011 00:28:57 +0000 (00:28 +0000)]
follow-up to r105740, adding the actual graphic to use (in the right branch this time)
Ryan Kaldari [Tue, 20 Dec 2011 23:50:15 +0000 (23:50 +0000)]
follow-up to r106754 - using strict comparison, adding logic for editing existing pages, changing parameter name in WikiPage::replaceSection from $summary to $sectionTitle as it only used for section titling
Aaron Schulz [Tue, 20 Dec 2011 23:47:53 +0000 (23:47 +0000)]
FU r106752: use "media-" instead of "images-" in container names. Long live books, video, 3D meshes, and animated holograms from the future!
Neil Kandalgaonkar [Tue, 20 Dec 2011 23:02:42 +0000 (23:02 +0000)]
fix race condition in UploadFromChunks, followup to r104687
Brandon Harris [Tue, 20 Dec 2011 22:53:07 +0000 (22:53 +0000)]
Followup r105280
For bug 33139 "Swapping colors in new diff color scheme"
* Modified diff colorscheme to yellow[orange]/blue[blue]
- These colors attempt to address the following issues with diffs:
- Colorblindness (Protanopia/Deuteranopia)
- Cultural meaning of color (e.g., "green is good, therefore this diff is better")
* Bumped font size up overall (actually, just removed the smaller)
* Removed dotted line around difftext
Jeroen De Dauw [Tue, 20 Dec 2011 22:45:14 +0000 (22:45 +0000)]
partial revert of r106872 after discussion with Brion on #mediawiki irc
Brion Vibber [Tue, 20 Dec 2011 22:11:29 +0000 (22:11 +0000)]
Revert r106439, r106441 - bad formatting mushing separate lines together
Brion Vibber [Tue, 20 Dec 2011 22:05:40 +0000 (22:05 +0000)]
Revert r106870: doesn't seem like it would format things consistently as expected.
Aaron Schulz [Tue, 20 Dec 2011 21:58:29 +0000 (21:58 +0000)]
FU r106514: Sanity check for empty sha1 values in the DB
Brion Vibber [Tue, 20 Dec 2011 21:57:17 +0000 (21:57 +0000)]
Revert r106094 (broken unnecessary cleanup), r106454 (ugly unneceessary cleanup)
The ugliness of this sort of code is probably part of why there's still a Linker::tooltip() function.
Please don't just replace it with worse code; if truly cleaning it up this should be done by giving a saner interface to the nav generation code
Brion Vibber [Tue, 20 Dec 2011 21:52:18 +0000 (21:52 +0000)]
Revert r106456, r106485: system-wide setting seems to be intended to apply only to specific extensions' code but wouldn't? Also weird config parameter combining two unrelated things into one.
Sam Reed [Tue, 20 Dec 2011 21:37:51 +0000 (21:37 +0000)]
For r106521/r106865, wrap long example description strings
Follows up r106439
Brion Vibber [Tue, 20 Dec 2011 21:37:04 +0000 (21:37 +0000)]
Provisional revert of r105831: as noted it's not safe; alternative fix was a weird abstraction violation that would leave you not knowing whether the data would be present or not.
Brion Vibber [Tue, 20 Dec 2011 21:29:24 +0000 (21:29 +0000)]
grammar :) followup r106514
Brion Vibber [Tue, 20 Dec 2011 21:26:57 +0000 (21:26 +0000)]
Revert r106521: creates lots of long, unwrappable lines in help output
Brion Vibber [Tue, 20 Dec 2011 21:24:06 +0000 (21:24 +0000)]
Provisional revert r106573, r106559: may be the wrong thing to do, and should probably come with regression tests if added.
Brion Vibber [Tue, 20 Dec 2011 21:20:50 +0000 (21:20 +0000)]
Revert r106523: abstraction violation, looks very wrong, unclear benefits
Raimond Spekking [Tue, 20 Dec 2011 20:47:29 +0000 (20:47 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Tue, 20 Dec 2011 20:41:01 +0000 (20:41 +0000)]
r106752: Add two more new message keys to maintenance file
Chad Horohoe [Tue, 20 Dec 2011 20:15:42 +0000 (20:15 +0000)]
Simplify $assoc check
Aaron Schulz [Tue, 20 Dec 2011 20:15:05 +0000 (20:15 +0000)]
FU r106770: fixed the other getTransform() call
Aaron Schulz [Tue, 20 Dec 2011 19:25:23 +0000 (19:25 +0000)]
Cleaned up some references to FSRepo in code and comments. This should have no noticeable functional changes.
Aaron Schulz [Tue, 20 Dec 2011 18:55:50 +0000 (18:55 +0000)]
FU r106752: added b/c code to FSRepo to make things easy for extensions (like ConfirmAccount)
Alexandre Emsenhuber [Tue, 20 Dec 2011 18:09:21 +0000 (18:09 +0000)]
Fix casing of Language::timeanddate calls
Alexandre Emsenhuber [Tue, 20 Dec 2011 18:07:19 +0000 (18:07 +0000)]
Use local context to get messages
Siebrand Mazeland [Tue, 20 Dec 2011 17:26:57 +0000 (17:26 +0000)]
Update punctuation for recently added messages.
Jure Kajzer [Tue, 20 Dec 2011 16:11:45 +0000 (16:11 +0000)]
* removed manual cascading of recentchanges on page delete
* fixed purgeCache bug in updater
* TESTED install/update from 1.18/phpunit
Sam Reed [Tue, 20 Dec 2011 15:02:39 +0000 (15:02 +0000)]
Fix AutoLoader fail from r106800
Raimond Spekking [Tue, 20 Dec 2011 14:23:20 +0000 (14:23 +0000)]
Fix typo spotted by Roan. Originated in r106752, cp error in r106796.
Sam Reed [Tue, 20 Dec 2011 14:01:09 +0000 (14:01 +0000)]
Move registration form template to its own file
Raimond Spekking [Tue, 20 Dec 2011 13:34:36 +0000 (13:34 +0000)]
r106752: Add block comments
Sam Reed [Tue, 20 Dec 2011 12:36:34 +0000 (12:36 +0000)]
Fix for r104684
Using "$result['sectionanchor'] == ''; rather than "$result['sectionanchor'] = '';"...
Santhosh Thottingal [Tue, 20 Dec 2011 12:07:22 +0000 (12:07 +0000)]
Correct the error dialog display.
Niklas Laxström [Tue, 20 Dec 2011 11:17:36 +0000 (11:17 +0000)]
Fix for bug 33270: default to 'default' search profile
Had this fixed in one of my wikies but not committed
Brian Wolff [Tue, 20 Dec 2011 10:15:18 +0000 (10:15 +0000)]
(bug 33156) Special:block didn't let you confirm blocking yourself if using non-normalized name.
Was comparing the normalized name to the non-normalized name that gets inserted into the form, since
request variables from previous request override form defaults.
Alexandre Emsenhuber [Tue, 20 Dec 2011 09:12:20 +0000 (09:12 +0000)]
Fix for r102116: link feed to Special:Recentchanges, not current page
Aaron Schulz [Tue, 20 Dec 2011 08:47:48 +0000 (08:47 +0000)]
Set deleted zone container in parserTest.inc
Aaron Schulz [Tue, 20 Dec 2011 08:38:55 +0000 (08:38 +0000)]
FU r106752: unbreak "other sizes" links on File: pages by working around the suck /media system.
Siebrand Mazeland [Tue, 20 Dec 2011 08:21:54 +0000 (08:21 +0000)]
Remove trailing whitespace and a few superfluous empty lines.
Brian Wolff [Tue, 20 Dec 2011 07:55:44 +0000 (07:55 +0000)]
Don't re-use allinnamespace as the header for special:prefixindex. instead introduce new message prefixindex-namespace
Hopefully directly editing MessagesQqq.php like I did is ok... I can never remember if i'm supposed to do that, or if it will just be overridden on next translatewiki export.
Aaron Schulz [Tue, 20 Dec 2011 07:55:16 +0000 (07:55 +0000)]
Set deleted zone container in UploadFromUrlTestSuite
Aaron Schulz [Tue, 20 Dec 2011 07:53:48 +0000 (07:53 +0000)]
FU r106752: Fixed directory b/c for ForeignAPIRepo, which was moved to Setup.php
Max Semenik [Tue, 20 Dec 2011 07:50:45 +0000 (07:50 +0000)]
Follow-up r97303: sort module names in paraminfo's paraminfo
Brian Wolff [Tue, 20 Dec 2011 06:48:05 +0000 (06:48 +0000)]
follow-up r98710/r104410. I personally think that forRefresh is confusing, since a purge is always in essence a "refresh"ing operation. change it to forThumbRefresh.
Brian Wolff [Tue, 20 Dec 2011 06:16:08 +0000 (06:16 +0000)]
If you request LogEventList to display the combination of 2 log types, and one of
those logs are restricted, will generate a warning, since it removes first entry of
array, but doesn't re-index the array, and subsequent code makes assumptions of the
form if ( count( $this->types ) $singleType = $this->types[0] (which doesn't work, as
first index is 1).
Thus cause array to be re-indexed if a $wgLogRestriction causes a log type to be removed.
Steps to reproduce the issue is make deletion log restricted, then view a (non-existent) user page.
Personally I think its kind of weird/wrong that if someone restricts both the move and delete log,
then viewing a non-existent will give "This page has been deleted, here's delete log:" followed by an
entry from *any* public log.
Tim Starling [Tue, 20 Dec 2011 04:39:12 +0000 (04:39 +0000)]
* Fix class name
* unset($wgMemc) doesn't actually do anything useful, it just removes the reference from the local scope. Set it to NULL instead.
Tim Starling [Tue, 20 Dec 2011 04:36:27 +0000 (04:36 +0000)]
Don't suppress warnings when attempting file creation for the second time, this masks important error messages
Ryan Kaldari [Tue, 20 Dec 2011 04:22:06 +0000 (04:22 +0000)]
$reqArr is an ambiguous variable name - req can mean required or request. Changing to an unambiguous name
Ryan Kaldari [Tue, 20 Dec 2011 04:15:21 +0000 (04:15 +0000)]
adding sectiontitle/wgSectionTitle as a new parameter for page editing (so that it can be set separately from the edit summary). For right now, this is just for API use, and thus isnt used in the form. As soon as 1.19 is out the door, we should change the form to use this as well. The current implementation is designed to be completely backward-compatible and non-disruptive
Aaron Schulz [Tue, 20 Dec 2011 03:52:06 +0000 (03:52 +0000)]
Merged FileBackend branch. Manually avoiding merging the many prop-only changes SVN likes to sprinkle in (easy to spot from the change list). Did not add SwiftFileBackend.php as it still is in development.
Aaron Schulz [Tue, 20 Dec 2011 00:57:25 +0000 (00:57 +0000)]
Reverted r101014 per CR. Added comment. The sooner RL2 kills this the better...
Sam Reed [Mon, 19 Dec 2011 23:33:37 +0000 (23:33 +0000)]
Fix $imit to $limit
Followup r106567
Platonides [Mon, 19 Dec 2011 21:00:03 +0000 (21:00 +0000)]
ExtraParserTest::testTrackingCategory and ExtraParserTest::testTrackingCategorySpecial need a db
Alexandre Emsenhuber [Mon, 19 Dec 2011 20:20:47 +0000 (20:20 +0000)]
Use local context to get message
Raimond Spekking [Mon, 19 Dec 2011 20:15:36 +0000 (20:15 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Neil Kandalgaonkar [Mon, 19 Dec 2011 19:46:52 +0000 (19:46 +0000)]
add docs for feedback messages
Sam Reed [Mon, 19 Dec 2011 19:07:18 +0000 (19:07 +0000)]
Followup r106619, mark said method public due to callers
Alexandre Emsenhuber [Mon, 19 Dec 2011 18:19:03 +0000 (18:19 +0000)]
* Use Language::userTimeAndDate() and related instead of Language::timeanddate() when using user preferences to display dates
* Use local variables instead of calling some methods three times
* Fixed casing of remaining Language::timeanddate() call
Alexandre Emsenhuber [Mon, 19 Dec 2011 16:10:06 +0000 (16:10 +0000)]
Pass the User object to Title::userCan()
Alexandre Emsenhuber [Mon, 19 Dec 2011 16:05:47 +0000 (16:05 +0000)]
* Inlinise the only usage of $user in MediaWiki::main()
* Change the name of the variable containing the WikiPage object for more consistency
Sam Reed [Mon, 19 Dec 2011 01:07:30 +0000 (01:07 +0000)]
@private is a lie, based on usage, it'd need to be at least protected
Removing useless documentation replacing with param/return doc
Jeroen De Dauw [Sun, 18 Dec 2011 21:29:41 +0000 (21:29 +0000)]
doc++
Raimond Spekking [Sun, 18 Dec 2011 20:47:06 +0000 (20:47 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Robin Pepermans [Sun, 18 Dec 2011 19:20:41 +0000 (19:20 +0000)]
Follow-up r103640
Alexandre Emsenhuber [Sun, 18 Dec 2011 19:04:25 +0000 (19:04 +0000)]
* Use local context to get messages
* Use Language::userTimeAndDate(), Language::userTime() and Language::userDate() instead of Language::timeAndDate(), Language::time(), Language::date() to not depend on $wgUser
* Replaced empty() check by check against explicit values
Robin Pepermans [Sun, 18 Dec 2011 17:58:47 +0000 (17:58 +0000)]
Follow-up r106559: it's better to set the preference for own MediaWiki names in Language::getTranslatedLanguageNames. More consistent and saves some code :)
Also update Babel to use that function.
Aaron Schulz [Sun, 18 Dec 2011 16:35:45 +0000 (16:35 +0000)]
FU r106514: use base 16 SHA-1 to be consistent with image info
Robin Pepermans [Sun, 18 Dec 2011 16:25:45 +0000 (16:25 +0000)]
Remove ltr class (see r89466), it should not be used at all, because 1) the name is too general, 2) it is automatically added to the body element (colliding class names) and 3) it is better to use HTML dir="ltr" as in r105929.
Alexandre Emsenhuber [Sun, 18 Dec 2011 16:02:14 +0000 (16:02 +0000)]
And I of course forgot to commit ProtectionForm.php in r106567...
Alexandre Emsenhuber [Sun, 18 Dec 2011 16:01:31 +0000 (16:01 +0000)]
* Merged WikiPage::updateRestrictions() and Title::updateTitleProtection() into WikiPage::doUpdateRestrictions(); older methods still work for backward compatibility, but marked Title::updateTitleProtection() as deprecated and for removal in 1.20 since no extension calls it
* Removed permissions check from WikiPage::doUpdateRestrictions() and left it for callers, resolves the todo from documentation
* Inverted $expiry and $reason parameter between WikiPage::doUpdateRestrictions() and WikiPage::updateRestrictions() for more consistency; WikiPage::doUpdateRestrictions() also requires all parameters to be passed
* WikiPage::doUpdateRestrictions() returns a Status object instead of bool for the older one; only possible error at the moment is a read-only database
* Updated core calls to these functions
* Made maintenance scripts using it simply protect all actions returned by Title::getRestrictionTypes() instead of hardcoded 'edit' and 'move'
* This also means that protect.php can be used to protect a non-existing page for creation
Alexandre Emsenhuber [Sun, 18 Dec 2011 14:48:23 +0000 (14:48 +0000)]
Revert r106545 and pass a null variable by ref (also updated the documentation) so that the hook is called at the correct moment and after everything is executed.
This is *exactly* the same behaviour as before r88898 since $article was an out parameter to fill $wgArticle correctly.
Alexandre Emsenhuber [Sun, 18 Dec 2011 14:07:01 +0000 (14:07 +0000)]
Pass the User object to Revision::userCan()
Robin Pepermans [Sun, 18 Dec 2011 13:50:34 +0000 (13:50 +0000)]
Clarify documentation
Robin Pepermans [Sun, 18 Dec 2011 12:17:12 +0000 (12:17 +0000)]
Make the output consistent when no second parameter is given and second parameter equals first parameter. This gives preference to names defined in MediaWiki, but when it is not in MediaWiki, it also sees whether there is one defined in the translated language names.
Mark A. Hershberger [Sun, 18 Dec 2011 01:46:25 +0000 (01:46 +0000)]
followup r88898 -- move BeforeInitialize hook to where it can be
called in a way that matches the documented parameters
As it was, when an extension tried to use BeforeInitialize with the
documented parameters this resulted in an exception:
Detected bug in an extension! Hook HookFunctionName has invalid
call signature; Parameter 2 to HookFunctionName() expected to be a
reference, value given
Mark A. Hershberger [Sun, 18 Dec 2011 01:32:11 +0000 (01:32 +0000)]
w/s
Aaron Schulz [Sat, 17 Dec 2011 23:14:39 +0000 (23:14 +0000)]
Kill some useless code in r106514
Sam Reed [Sat, 17 Dec 2011 19:55:49 +0000 (19:55 +0000)]
Per bug 28901, and Duplicatebug on r105831, only list the Article ID if it has already been loaded
Not a long term fix, but saves potentially a lot of database queries to lookup article ids, until the other issues on bug 28901 are tidied up
Sam Reed [Sat, 17 Dec 2011 19:10:33 +0000 (19:10 +0000)]
More example conversions/additions
Ping r106439
Alexandre Emsenhuber [Sat, 17 Dec 2011 18:52:52 +0000 (18:52 +0000)]
Pass the User object to Title::userCan()
Robin Pepermans [Sat, 17 Dec 2011 18:31:25 +0000 (18:31 +0000)]
Follow-up r92924: move the CSS/JS for e-mail validation to Special:ChangeEmail.
Also merge the different LTR/RTL styles, it is flipped anyway.
Aaron Schulz [Sat, 17 Dec 2011 18:27:38 +0000 (18:27 +0000)]
Expose rev_sha1/ar_sha1 to API (bug 21860)
Leons Petrazickis [Sat, 17 Dec 2011 15:59:21 +0000 (15:59 +0000)]
Fixes to address MaxSem's comment on r106480 regarding DB2 tables.sql syntax, indentation, and capitalization:
* Made all table and column names lowercase for consistency
* Removed " from around some "identifiers". Not necessary for DB2.
* Applied consistent indentation to all table declarations
* Applied consistent indentation to all index declarations
* Moved all PRIMARY KEY clauses to their own line for consistency and max line length
* Moved all ON clauses to their own line for consistency and max line length
* Fixed vertical alignment for column names and data types, remove all other vertical alignment
* Removed commented out references to SEQUENCE values, as they are used in neither DB2 nor MySQL schemas.
* Consistent spacing around parens () and commas ,
* Capitalized all data types.
* Note: tables.sql is approaching DB2's 32k limit. It will need to be split into two files soon.
Alexandre Emsenhuber [Sat, 17 Dec 2011 13:24:40 +0000 (13:24 +0000)]
Use local context to get messages