jenkins-bot [Mon, 1 May 2017 23:30:49 +0000 (23:30 +0000)]
Merge "config: Add unit tests for EtcdConfig"
jenkins-bot [Mon, 1 May 2017 23:24:36 +0000 (23:24 +0000)]
Merge "Avoid master queries in loadAndLazyInit() for miser mode"
jenkins-bot [Mon, 1 May 2017 23:08:07 +0000 (23:08 +0000)]
Merge "Use isSpecialPage() where possible"
jenkins-bot [Mon, 1 May 2017 23:07:37 +0000 (23:07 +0000)]
Merge "api: Use NS_SPECIAL instead of -1 in ApiPageSet"
Fomafix [Sat, 29 Apr 2017 20:50:33 +0000 (22:50 +0200)]
api: Use NS_SPECIAL instead of -1 in ApiPageSet
Follows-up
e2055fe0a55c.
Change-Id: Ifd33f339a3c5ec475cc3c6b2fba57c35386bab8b
Florian Schmidt [Sat, 15 Apr 2017 23:52:23 +0000 (01:52 +0200)]
Use IPSet for checking of wgProxyList
Instead of using array_* functions, use the IPSet for checking, if a
specific IP address matches a set of addresses.
This also deprecates a backward-compatibility functionality, that
the wgProxyList array could also be an associative array, where the blocked
IP address is set as a key of the array insted of a value. All IP address
keys will be mved to values on-the-fly, however a deprecation warning will
be emitted. A notice in the Release notes was added, too.
Bug: T161580
Change-Id: I69d9534942c415ab044177969ecd54160079b593
Timo Tijhof [Thu, 27 Apr 2017 04:15:51 +0000 (21:15 -0700)]
config: Add unit tests for EtcdConfig
Change-Id: I6e647985b98724b5448831a6fae1b2d2521fd363
jenkins-bot [Mon, 1 May 2017 21:39:51 +0000 (21:39 +0000)]
Merge "Avoid implicit globals"
Ed Sanders [Mon, 1 May 2017 14:03:40 +0000 (15:03 +0100)]
Avoid implicit globals
Wrap in IIFE if variables is not intended to be global, otherwise
explicitly assign to window for better readability, and avoiding
problems if code were to get wrapped in IIFE later.
Change-Id: I2313daeaf00f27b6ea9eb6b907c066844c5d3836
Translation updater bot [Mon, 1 May 2017 19:56:47 +0000 (21:56 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: If2d4e2b342645f88f166ff54ce9102439599e24c
Ed Sanders [Mon, 1 May 2017 14:02:21 +0000 (15:02 +0100)]
Remove unnecessary Function.binds
Also fix ,->; typo
Change-Id: Icf87ae6e2aa111f3cb578c7355c92ffc6019df55
Ed Sanders [Mon, 1 May 2017 13:56:04 +0000 (14:56 +0100)]
Spread and indent string-concatenations
Avoids single lint string concatenations and multi-line strings.
Change-Id: Iada91c1019cda87d48b13bdcff963d1950b54874
Eugene Gvozdetsky [Mon, 1 May 2017 12:18:29 +0000 (14:18 +0200)]
Add GenderAliases for namespaces
Change-Id: I16b54e35c4212ccc26e7c9d23ee898e29c04a69f
Translation updater bot [Sun, 30 Apr 2017 19:57:26 +0000 (21:57 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Id132ebc6e31dd5ef9c4a5e774c39c393aa67e3d5
Fomafix [Sat, 29 Apr 2017 20:22:46 +0000 (22:22 +0200)]
Use isSpecialPage() where possible
Change-Id: Ie4d0838acf96a7ed4a1fe4cfdc901c77d3312174
Translation updater bot [Sat, 29 Apr 2017 20:31:33 +0000 (22:31 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Id5d126cf626391b5f7d562758a8a2e1a603fed21
Aaron Schulz [Sat, 29 Apr 2017 05:10:43 +0000 (22:10 -0700)]
Avoid master queries in loadAndLazyInit() for miser mode
Bug: T92357
Change-Id: Idaef633d9039cdbfa3bd123018f2339c6d489fe4
jenkins-bot [Sat, 29 Apr 2017 04:07:48 +0000 (04:07 +0000)]
Merge "SpecialJavaScriptTest: Make sure we don't catch our own exception"
Aaron Schulz [Fri, 28 Apr 2017 20:56:20 +0000 (13:56 -0700)]
Improve EtcdConfig fallback logic
If the cache is stale and the lock keeps being acquired, but the re-fetch
fails each time, the method would end up failing after the timeout was
reached. Instead, use the stale cache if available.
Change-Id: Ieafc9de17e6c60d8eea7b937923b4ad548e99be8
Translation updater bot [Fri, 28 Apr 2017 21:19:02 +0000 (23:19 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Id3c6419b44d67846ad7aaf882a635a3b41a98cf3
jenkins-bot [Fri, 28 Apr 2017 15:23:34 +0000 (15:23 +0000)]
Merge "Simplify Image/Video/Audio rules using LESS nesting"
Ed Sanders [Fri, 28 Apr 2017 12:30:51 +0000 (13:30 +0100)]
Simplify Image/Video/Audio rules using LESS nesting
Also allow Video/Audio to contain img instead of video
for VE support.
Change-Id: Ic54662bbcd50de70133c6581cd7d8025c872a7f4
jenkins-bot [Fri, 28 Apr 2017 12:27:28 +0000 (12:27 +0000)]
Merge "EtcdConfig: use array_key_exists(), the value can be null"
jenkins-bot [Fri, 28 Apr 2017 12:24:57 +0000 (12:24 +0000)]
Merge "Add space version of img_upright and img_page for language de"
Tim Starling [Fri, 28 Apr 2017 05:14:57 +0000 (15:14 +1000)]
EtcdConfig: use array_key_exists(), the value can be null
Change-Id: Iae175401da8d49f5475d8c88cc5390b16e7cba32
jenkins-bot [Fri, 28 Apr 2017 02:29:21 +0000 (02:29 +0000)]
Merge "Document rationale or primary use case for many indexes"
Brion Vibber [Fri, 28 Apr 2017 01:22:31 +0000 (18:22 -0700)]
Fix help text for --d on shell.php
1 is stderr, not 0
Change-Id: Iaee4ffd5767f8ae693e8ef19371ce38fe6bd1817
Tim Starling [Thu, 27 Apr 2017 23:56:38 +0000 (09:56 +1000)]
Add ConsoleLogger, use it for eval.php -d
eval.php previously set $wgDebugLogFile to /dev/stdout. This had the
following problems:
* It doesn't work if the maintenance script is executed via sudo, since
/dev/stdout is typically owned by the original user, so MW can't open
it. Using php://stdout worked on HHVM but not PHP.
* Setting $wgDebugLogFile has no effect if the wiki uses MonologSpi.
* Setting $wgDebugLogFile has no effect on channels configured with
$wgDebugLogGroups.
* stderr is a more appropriate place to send logging output.
* Writing to configuration variables is discouraged.
So, add ConsoleSpi, which is a very simple logging service provider
which sends all messages to stderr. This should be suitable for
debugging with eval.php or shell.php in WMF production or beta.
Change-Id: Ib0d6ce45e0cbecd58263fc4e360c63d4149acb3a
Ed Sanders [Mon, 10 Apr 2017 12:59:19 +0000 (13:59 +0100)]
Cleanup postEdit and match styles to mw.notification
* Remove HTML template
* Add mw-notification class and dependency
* Fix variable scoping issues so firing two notifications
doesn't cause one to become stuck
Bug: T58313
Change-Id: I9a702d23a8a9b5cc098cbb413213d73813bec097
jenkins-bot [Thu, 27 Apr 2017 20:03:40 +0000 (20:03 +0000)]
Merge "Expire the cache of a User object when a group membership is set to expire"
Translation updater bot [Thu, 27 Apr 2017 20:00:32 +0000 (22:00 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ia2686ac474c045e91fd29daef68ec0925b73823e
Umherirrender [Thu, 27 Apr 2017 19:47:09 +0000 (21:47 +0200)]
Add space version of img_upright and img_page for language de
On de.wikipedia.org the localized version of upright is used with
spaces, not underscores.
Add the version as alias to fix the pages and make linter happy
(T162961)
Change-Id: Id4726aecb51887fc82583e4d6b9284706b6b5b69
jenkins-bot [Thu, 27 Apr 2017 19:21:39 +0000 (19:21 +0000)]
Merge "Release prior row locks beforehand in LinksUpdate::updateCategoryCounts"
jenkins-bot [Thu, 27 Apr 2017 19:20:01 +0000 (19:20 +0000)]
Merge "SpecialJavaScriptTest: Do not accidentally pass parameters to QUnit.start()"
jenkins-bot [Thu, 27 Apr 2017 19:19:58 +0000 (19:19 +0000)]
Merge "SpecialJavaScriptTest: Format long JavaScript code fragments"
jenkins-bot [Thu, 27 Apr 2017 18:42:29 +0000 (18:42 +0000)]
Merge "Prepare for 1.30 branch"
Bartosz Dziewoński [Thu, 27 Apr 2017 18:22:41 +0000 (20:22 +0200)]
SpecialJavaScriptTest: Make sure we don't catch our own exception
If the jQuery promise returned by mw.loader.using() is rejected
synchronously (e.g. because one of the modules has a dependency on
non-existent module), the function passed to fail() also executes
synchronously. Note that this is true also with jQuery 3.
The exception it throws was caught by the catch() below, which
resulted in start() being called twice, which resulted in QUnit
throwing 'Uncaught Error: Called start() outside of a test
context too many times' rather than actually starting.
Change-Id: I5c6b50647c0af0fdec6547aaa59165f6b4a42642
Bartosz Dziewoński [Thu, 27 Apr 2017 18:19:32 +0000 (20:19 +0200)]
SpecialJavaScriptTest: Do not accidentally pass parameters to QUnit.start()
If the mw.loader.using() call's promise is rejected, we end up
passing an Error object as the 'count' parameter to QUnit.start().
This seems to be harmless, but is very confusing when debugging.
Change-Id: I44caca5285dbced5a5876d9d7ff6236dbd3efc35
Bartosz Dziewoński [Thu, 27 Apr 2017 18:05:25 +0000 (20:05 +0200)]
SpecialJavaScriptTest: Format long JavaScript code fragments
Change-Id: Iaa6369467e9fa846a8d5eb8f43cf0b523ef1a64e
jenkins-bot [Thu, 27 Apr 2017 17:46:58 +0000 (17:46 +0000)]
Merge "Block: Remove old IP addresses from default autoblock_whitelist message"
jenkins-bot [Thu, 27 Apr 2017 17:45:13 +0000 (17:45 +0000)]
Merge "mw.widgets.DateInputWidget: Highlight widget and open calendar on focus"
jenkins-bot [Thu, 27 Apr 2017 17:06:24 +0000 (17:06 +0000)]
Merge "Correct the "Help", "Media" and talk namespace names for Dinka"
jenkins-bot [Thu, 27 Apr 2017 13:51:27 +0000 (13:51 +0000)]
Merge "Do not add limit to ApiQueryPagePropNames when database type is mysql"
Amire80 [Tue, 25 Apr 2017 07:52:51 +0000 (10:52 +0300)]
Correct the "Help", "Media" and talk namespace names for Dinka
The corrections come from users Dinkawiki and Mawanmuortat,
who did most of the translation into this language.
No aliases are needed, because the file was only created recently,
and not yet used anywhere.
Change-Id: Ic1ddfaca403e05e5971c516d6e7a454311794f3c
Aaron Schulz [Thu, 27 Apr 2017 05:33:56 +0000 (22:33 -0700)]
Release prior row locks beforehand in LinksUpdate::updateCategoryCounts
Bug: T163801
Change-Id: I6a026ee9a249da5a8fd9ceb216416340a9188d3f
Tim Starling [Mon, 24 Apr 2017 06:49:05 +0000 (16:49 +1000)]
Document rationale or primary use case for many indexes
Change-Id: I1f0a13adbc6f618f38c3b05a1d356d76e2f5bd23
jenkins-bot [Thu, 27 Apr 2017 02:04:55 +0000 (02:04 +0000)]
Merge "Add a space between "Go to page" dropdown and button for multipage images"
jenkins-bot [Thu, 27 Apr 2017 01:59:36 +0000 (01:59 +0000)]
Merge "Revert, Follow-up: -1 recent contributors"
Eddie Greiner-Petter [Sat, 22 Apr 2017 19:23:11 +0000 (21:23 +0200)]
Revert, Follow-up: -1 recent contributors
This reverts commit
b67f40e5b01af569794eba26da79497329590d36.
There was an issue that the web installer, when inserting initial
values into the db table site_stats, would not insert any value for
ss_active_users. That lead to some places, most notably
Special:CreateAccount, to show off -1 recent contributors.
The commit to revert solved this by setting a default value of 1 for
the ss_active_users field in the database schema. However, while the
default schema has been changed, there hasn't been any schema update
procedure implemented. Also, the default of 1 is inconsistent with
other defaults in that table.
Revert that schema change completely. Instead, make the web installer
insert 0 to the field ss_active_users (just like it does with all other
fields in that table).
Bug: T56888
Change-Id: I4298754c2238f6e5447a5df77a4ada722ba302b2
jenkins-bot [Thu, 27 Apr 2017 00:41:25 +0000 (00:41 +0000)]
Merge "mediawiki.toolbar: Emit deprecation warnings"
James D. Forrester [Mon, 20 Mar 2017 22:56:27 +0000 (15:56 -0700)]
mediawiki.toolbar: Emit deprecation warnings
Callers to the EditPageBeforeEditToolbar hook can now return false to
signal that the toolbar is over-written, in which case this old code
won't be called (so no deprecation warnings for users of WikiEditor,
CodeEditor, etc.).
Bug: T30856
Depends-On: I5e755ef5dffb843368563511044d3123f14dc4bc
Change-Id: I3bed70a20e4b94fe3d04a00925b8012312202574
jenkins-bot [Wed, 26 Apr 2017 21:35:33 +0000 (21:35 +0000)]
Merge "exception: Add newline at the end of a debugging line for CLI users"
Florian Schmidt [Sat, 15 Apr 2017 23:02:58 +0000 (01:02 +0200)]
exception: Add newline at the end of a debugging line for CLI users
Bug: T162315
Change-Id: Ia2963fa298ab0e4782ef823e7f53322cd6a9c99b
Translation updater bot [Wed, 26 Apr 2017 21:21:00 +0000 (23:21 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ice5f1ec383e94de1b6e43c581a821e415edfe767
jenkins-bot [Wed, 26 Apr 2017 20:11:05 +0000 (20:11 +0000)]
Merge "Add percent and permille to special character list"
Eugene Gvozdetsky [Tue, 25 Apr 2017 10:10:47 +0000 (12:10 +0200)]
Extend grammar rules for Ukraininan language
Change-Id: I2a18acee6a1c4a7462953477da50d57239994f37
Ed Sanders [Wed, 26 Apr 2017 19:22:18 +0000 (20:22 +0100)]
Add percent and permille to special character list
Bug: T163894
Change-Id: I82a926412fb0f7c886e1e17ed4cf05cf2d4f00d9
James D. Forrester [Wed, 26 Apr 2017 18:47:40 +0000 (11:47 -0700)]
Prepare for 1.30 branch
Change-Id: If9842b19ec995d03f93f96bfad4d61ca96c37f3c
jenkins-bot [Wed, 26 Apr 2017 15:50:52 +0000 (15:50 +0000)]
Merge "SpecialMediaStatistics: Remove WMF-specific hack, no longer needed"
Bartosz Dziewoński [Wed, 26 Apr 2017 15:39:01 +0000 (17:39 +0200)]
SpecialMediaStatistics: Remove WMF-specific hack, no longer needed
We deleted the broken row from the databases per T155769.
This reverts
6e02a95227c4ef194ff2299a823aaa51aa9a223c.
Bug: T74535
Bug: T155769
Change-Id: Iac0873eb7112502dd7fc6b34ca956d9a2dffcb44
jenkins-bot [Wed, 26 Apr 2017 13:15:56 +0000 (13:15 +0000)]
Merge "EditPage: Factor out getSaveButtonLabel method"
jenkins-bot [Wed, 26 Apr 2017 01:46:50 +0000 (01:46 +0000)]
Merge "Interwiki: Don't override interwiki map order"
Volker E [Wed, 26 Apr 2017 01:28:38 +0000 (18:28 -0700)]
Update OOjs UI to v0.21.2
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.21.2
Change-Id: Id7cae80a4f3d84ea5d50003f2409537b307c0c58
jenkins-bot [Tue, 25 Apr 2017 23:41:44 +0000 (23:41 +0000)]
Merge "RCFilters UI: Create base classes for shared objects"
Moriel Schottlender [Tue, 25 Apr 2017 18:26:20 +0000 (11:26 -0700)]
RCFilters UI: Create base classes for shared objects
Preparing for adding other types of items than filters (namespaces,
users, tags, etc) this commit creates base classes for the model
and relevant widgets and extends Filter* from them.
Bug: T159942
Bug: T163521
Change-Id: I61c88a1f14a3ca9d91aa831187eda156468a6591
jenkins-bot [Tue, 25 Apr 2017 22:51:20 +0000 (22:51 +0000)]
Merge "Special:Block: Fix FOUC of bold 'mw-block-hideuser'"
Timo Tijhof [Tue, 25 Apr 2017 20:36:06 +0000 (13:36 -0700)]
Interwiki: Don't override interwiki map order
The ksort() here was causing the order to be enforced as
alphabetical instead of preserving the original order.
The order usually doesn't matter, except with regards to handling
of duplicates. Due to Parsoid normalising external links to interwiki
links, it has to do a reverse lookup. In doing so it has to decide
which one to prefer. It currently picks the first match from the
API request for meta=siteinfo&siprop=interwikimap, which didn't
match the defined order in the actual Interwiki map due to ksort()
being called in getAllPrefixes().
Sort in this function was originally introduced in 2010 with
commit
844e7c83e4 (2011; r92528; T21838), which is otherwise unrelated
and left no rationale.
The existing unit tests needed to be adjusted slightly as they
assumed alphabetical order. While it appeared they were also defined
in alphabetical order, this was merely the order of the variable
creation. The effective order is preserved within locals and globals,
but overall globals come before locals.
Also removed the duplicate test for Hash and CDB in InterwikiTest
that belongs in ClassicInterwikiLookupTest instead.
Bug: T145337
Change-Id: I7348748801cbdf16c6ceea5b0654fc174b79707e
Timo Tijhof [Tue, 25 Apr 2017 20:37:10 +0000 (13:37 -0700)]
Special:Block: Fix FOUC of bold 'mw-block-hideuser'
Loading Special:Block/<your own name> shows "Confirm block", but
this then becomes bold a second later. This is because the styles
are part of 'mediawiki.special.block' which also contains JavaScript
and is loaded with addModules().
Move the styles to mediawiki.special.css instead.
Change-Id: I1c47256227603a6cde36238fdd7e11205d9494ec
Translation updater bot [Tue, 25 Apr 2017 20:08:37 +0000 (22:08 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I53453d3129920681a8eb8ece0c9c2cba400cab77
Bartosz Dziewoński [Tue, 25 Apr 2017 14:41:51 +0000 (16:41 +0200)]
Add a space between "Go to page" dropdown and button for multipage images
Change-Id: I174da5597563be36cc6e67a485f8556b9bcd84f6
This, that and the other [Tue, 25 Apr 2017 03:55:26 +0000 (13:55 +1000)]
Expire the cache of a User object when a group membership is set to expire
To avoid user permissions persisting for up to 1 hour beyond their expiry
time.
Bug: T163691
Change-Id: I85b578e6b7816639c3d0101d66efb1efedb17af6
jenkins-bot [Tue, 25 Apr 2017 02:05:40 +0000 (02:05 +0000)]
Merge "Keep headers from jumping when expire interface is shown"
L10n-bot [Mon, 24 Apr 2017 20:02:24 +0000 (20:02 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Mon, 24 Apr 2017 20:02:15 +0000 (22:02 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I4ccfc62901bfa044c19b63fa30b450af8e9aa0a5
jenkins-bot [Mon, 24 Apr 2017 20:01:55 +0000 (20:01 +0000)]
Merge "Remove usages of RequestContext::getStats()"
Florian Schmidt [Mon, 17 Apr 2017 15:06:53 +0000 (17:06 +0200)]
Remove usages of RequestContext::getStats()
Bug: T156810
Change-Id: Ic07896a68389e20ce0a35a06049b8c51b6c3f699
Kaldari [Mon, 24 Apr 2017 19:02:18 +0000 (12:02 -0700)]
Keep headers from jumping when expire interface is shown
Change-Id: If2cb7c8e2e30c5e40f32113353f571a1fba63d29
Amire80 [Mon, 24 Apr 2017 09:39:38 +0000 (12:39 +0300)]
Add Dinka (din) to Names.php and languages/messages/
Bug: T163600
Change-Id: I2bf03c97680c17cddf48d05adee88581640268ec
jenkins-bot [Mon, 24 Apr 2017 15:19:29 +0000 (15:19 +0000)]
Merge "New maintenance script to clean up rows with invalid DB keys"
Amir Sarabadani [Mon, 24 Apr 2017 12:58:51 +0000 (17:28 +0430)]
Do not add limit to ApiQueryPagePropNames when database type is mysql
It's a known bug in some versions of mysql (including WMF dbs) that it
won't do a loose index scan when a limit is applied. Given that number
of possible types is still very low, this shouldn't be a problem.
More info: https://bugs.mysql.com/bug.php?id=61517
Bug: T115825
Change-Id: I4c3b885ac05b793088a92e054a38a36b9d07c0d4
jenkins-bot [Mon, 24 Apr 2017 08:33:13 +0000 (08:33 +0000)]
Merge "mw.widgets: Add SelectWithInputWidget and its PHP implementation"
Prateek Saxena [Wed, 22 Mar 2017 10:16:24 +0000 (15:46 +0530)]
mw.widgets: Add SelectWithInputWidget and its PHP implementation
Bug: T106999
Change-Id: Ic158bec3c463fba5099b05f41c9686f833e1c313
Translation updater bot [Sun, 23 Apr 2017 19:54:59 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Iba16aa2179c535c6d48a3745cb3b861ebd39b067
Translation updater bot [Sat, 22 Apr 2017 19:58:16 +0000 (21:58 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I4a646e2126a03104fbb2a23eeec923cdcea5d4a8
Prateek Saxena [Thu, 9 Mar 2017 10:53:12 +0000 (16:23 +0530)]
mw.widgets.DateInputWidget: Highlight widget and open calendar on focus
Bug: T159987
Change-Id: I24327e1fe4b23de1b35833d3f23634094b5a2664
jenkins-bot [Sat, 22 Apr 2017 04:37:05 +0000 (04:37 +0000)]
Merge "Set a persistent connection ID for RedisConnectionPool"
jenkins-bot [Sat, 22 Apr 2017 02:32:34 +0000 (02:32 +0000)]
Merge "Add benchmarkTidy.php, to benchmark tidy drivers"
jenkins-bot [Sat, 22 Apr 2017 02:08:09 +0000 (02:08 +0000)]
Merge "Send 500 http status code, instead of 200, for DBConnectionErrors"
Aaron Schulz [Sat, 22 Apr 2017 00:17:07 +0000 (17:17 -0700)]
Set a persistent connection ID for RedisConnectionPool
This re-uses the options hash as the ID so that re-used connections
do not clobber each others settings.
Change-Id: I17e5993ecdab1770259803e06956b85b9ebb2ba6
jenkins-bot [Fri, 21 Apr 2017 23:17:49 +0000 (23:17 +0000)]
Merge "RCFilters UI: Fix FilterTagItemWidget styles"
Translation updater bot [Fri, 21 Apr 2017 20:01:37 +0000 (22:01 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ifec3cc97ff0bf69a31843968228c9bd9c1618068
Moriel Schottlender [Fri, 21 Apr 2017 18:34:21 +0000 (11:34 -0700)]
RCFilters UI: Fix FilterTagItemWidget styles
The styles got a bit messed up when we switched to using
TagMultiselectWidget. Fixes:
* Switch to using the methods of flaggable element (which TagItemWidget
already is using) instead of custom css classes
* Use flag:invalid for conflicts, so the styles are consistent with
OOUI styling for invalid tags, but keep the label red color, so it
is still evident when the tag is selected.
* Bonus: Actually apply filterTagMultiselectWidget base class, because
it wasn't applied before (oops)
Bug: T163522
Change-Id: I1cc3bd743d8b930bee23386516ca123ee3c36983
jenkins-bot [Fri, 21 Apr 2017 18:23:42 +0000 (18:23 +0000)]
Merge "Rephrase enotif_lastdiff and enotif_lastvisited"
jenkins-bot [Fri, 21 Apr 2017 18:15:59 +0000 (18:15 +0000)]
Merge "Set default to 1 recent contributor instead of -1"
Derk-Jan Hartman [Fri, 21 Apr 2017 12:50:53 +0000 (14:50 +0200)]
HTMLForm: add errors to html in ooui variants
HTMLForm when using OOUI mode was not adding errors to the resulting
HTML, if depending on message arrays, as previously used before
Status.
This exposed additional problems. Aligned the function a bit closer to
HTMLForm's getErrorsOrWarnings()
Bug: T158492
Change-Id: I8765a025dd441676e35a7c183c67b37036643c1e
Florian Schmidt [Sun, 16 Apr 2017 19:26:13 +0000 (21:26 +0200)]
Send 500 http status code, instead of 200, for DBConnectionErrors
Bug: T160875
Change-Id: I4c909457938a19358dfc4b2aec216b1a148df46c
Tim Starling [Thu, 23 Mar 2017 01:51:43 +0000 (12:51 +1100)]
Add benchmarkTidy.php, to benchmark tidy drivers
Plus representative input file
Change-Id: I254793fc55c57a98c07ae1e4c27e6005965c9a20
jenkins-bot [Fri, 21 Apr 2017 00:54:48 +0000 (00:54 +0000)]
Merge "Fix preference tab switching so it doesn't fight prevTab v url hash"
jenkins-bot [Fri, 21 Apr 2017 00:40:24 +0000 (00:40 +0000)]
Merge "RCFilters UI: Unify li bullets with and without highlights"
jenkins-bot [Fri, 21 Apr 2017 00:36:23 +0000 (00:36 +0000)]
Merge "RCFilters UI: Change text for edit authorship group"