umherirrender [Sat, 28 Feb 2015 09:38:08 +0000 (10:38 +0100)]
Add release-notes for message escaping
Some of this messages where used with raw html on wmf wikis, that makes
it possible that this message also will be used with raw html on third
party wikis, therefore give a hint in the release notes.
This includes release notes for:
Id55295a0406659242bbc12a59af7e23fb742237c: editsection
Ic4fcb40de844ac51c88fb51d752a4c286313ecf9: redirectto
I1e90962c3c94c8b72aadfc4c0d041d52e2cde3f1: version-poweredby-others
I7a5dfc8ecd2f84da0dce3e1357af462a3c0da23f: thisisdeleted, viewdeleted
Ifb58bd3823aa633135a701ae3e2ae9c955b422c0: protect-summary-cascade
Id16d8c8dff73fdacad6c9a4ff7f2919945b7e893: editlink, viewsourcelink
Ibcc1b49946bc91e12756eb3866448159493c61f4: lastmodifiedat,
laggedslavemode
Ifd696ecd93c76e56cb21b3f2645367beeeeb5ba0: retrievedfrom
Bug: T85864
Change-Id: I1b144242ccb8780120f1a8ad9e3b6fde0da760f5
Thiemo Mättig [Thu, 26 Mar 2015 09:17:07 +0000 (10:17 +0100)]
Replace Html::... with self::... in the Html class
How cool is that, I can call a patch "SelfHTML". ;-)
Change-Id: I17d36bc45a349c92715b88004aaae046d4f7be1c
jenkins-bot [Fri, 27 Mar 2015 17:28:38 +0000 (17:28 +0000)]
Merge "Add mobile target for mediawiki.confirmCloseWindow"
jenkins-bot [Fri, 27 Mar 2015 17:06:36 +0000 (17:06 +0000)]
Merge "Update MWLoggerLegacyLogger phpdoc"
jenkins-bot [Fri, 27 Mar 2015 17:06:01 +0000 (17:06 +0000)]
Merge "Allow MWLoggerMonologHandler to take prefix from channel"
Florian [Fri, 27 Mar 2015 16:56:50 +0000 (17:56 +0100)]
Add mobile target for mediawiki.confirmCloseWindow
Bug: T88949
Change-Id: I1e06668cbd149c23f7b961f7603be07262a021a9
jenkins-bot [Fri, 27 Mar 2015 16:44:22 +0000 (16:44 +0000)]
Merge "Made ProfilerStub return null instead of a dummy ScopedCallback"
jenkins-bot [Fri, 27 Mar 2015 16:38:02 +0000 (16:38 +0000)]
Merge "Removed view event from $wgAutopromoteOnce"
jenkins-bot [Fri, 27 Mar 2015 16:33:18 +0000 (16:33 +0000)]
Merge "Set parameter default to array() in WebResponse::setcookie()"
Ejegg [Fri, 27 Mar 2015 15:58:26 +0000 (15:58 +0000)]
Merge "Fix TestingAccessWrapper::__call"
jenkins-bot [Fri, 27 Mar 2015 15:54:36 +0000 (15:54 +0000)]
Merge "ApiParse: Fix parse of new section title"
Thiemo Mättig [Fri, 27 Mar 2015 08:58:58 +0000 (09:58 +0100)]
Set parameter default to array() in WebResponse::setcookie()
This is a direct follow-up for the question raised in Ifab16c2.
Null is not a meaningful value in this case. As far as I can see the
only reason it was added was to make the parameter optional. Optional
array parameters are better marked with "= array()".
Change-Id: I86965d390fdb718de7fb81a9f4c48b2261c16aa9
jenkins-bot [Fri, 27 Mar 2015 08:37:28 +0000 (08:37 +0000)]
Merge "Remove unneeded variable assignment in Usercreate.php"
Aaron Schulz [Fri, 27 Mar 2015 05:51:13 +0000 (22:51 -0700)]
Made User actually use the mQuickTouched process cache
Change-Id: I158eae2dac16b5fdacd095fff7fb031b42804a1e
Kunal Mehta [Fri, 27 Mar 2015 00:00:42 +0000 (17:00 -0700)]
Don't require database access for ContentHandlerTest
We can just mark all the titles as non-existent in the LinkCache
Change-Id: Ifd6fdfd0f8318dac8af7f7509705cf30d44c8a4e
jenkins-bot [Thu, 26 Mar 2015 23:26:14 +0000 (23:26 +0000)]
Merge "Revert "mediawiki.action.edit.preview: Disable if there is no #wpTextbox1""
Aaron Schulz [Thu, 26 Mar 2015 22:47:33 +0000 (15:47 -0700)]
Removed view event from $wgAutopromoteOnce
* This avoids master queries on view. It could use local jobs, but nothing
was using this by default anyway.
Bug: T92357
Change-Id: Id6353942215a3c704848d3bcc31c2b76225c78be
jenkins-bot [Thu, 26 Mar 2015 22:37:59 +0000 (22:37 +0000)]
Merge "Made addAutopromoteOnceGroups check wfReadOnly"
jenkins-bot [Thu, 26 Mar 2015 22:25:19 +0000 (22:25 +0000)]
Merge "Introduced User::touch() method to bump the getTouched() value using memcached"
Aaron Schulz [Thu, 26 Mar 2015 22:20:14 +0000 (15:20 -0700)]
Made addAutopromoteOnceGroups check wfReadOnly
Change-Id: I2fecf6616dd00cd34647f67298583ea8ec2977c0
jenkins-bot [Thu, 26 Mar 2015 22:13:48 +0000 (22:13 +0000)]
Merge "Made showJobs.php include abandoned jobs in --list"
jenkins-bot [Thu, 26 Mar 2015 22:11:34 +0000 (22:11 +0000)]
Merge "refreshLinks.php: Limit rows scanned per query in deleteLinksFromNonexistent()"
TheDJ [Thu, 26 Mar 2015 22:06:43 +0000 (22:06 +0000)]
Revert "mediawiki.action.edit.preview: Disable if there is no #wpTextbox1"
This caused T94089
This reverts commit
c890a2fdefaae2551897ce2f1b9f39d82b435dc2.
Change-Id: Ia5e151d12f0ad03ce50802502e661d7499749526
Aaron Schulz [Thu, 26 Mar 2015 05:19:32 +0000 (22:19 -0700)]
Introduced User::touch() method to bump the getTouched() value using memcached
* This lets some callers avoid the heavyweight invalidateCache() method
Bug: T91279
Bug: T92357
Change-Id: I8c1c7ff9c5574f0eca23e7effde199ab13a19231
Translation updater bot [Thu, 26 Mar 2015 20:55:24 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I2c29611aa564f96e33980784eb64907598230542
Kevin Israel [Sun, 15 Mar 2015 10:58:58 +0000 (06:58 -0400)]
refreshLinks.php: Limit rows scanned per query in deleteLinksFromNonexistent()
This also makes the -e and [start] options apply to --dfn-only, making it
possible to restart the script other than at the beginning if necessary.
Bug: T38195
Change-Id: I828b522039290b5700faa89fb8ad4075e50332e7
Aaron Schulz [Thu, 26 Mar 2015 19:17:10 +0000 (12:17 -0700)]
Made showJobs.php include abandoned jobs in --list
Change-Id: I7ae8dd2470d5e15fd66c6c06f3feb6d70527daa3
Derk-Jan Hartman [Thu, 19 Mar 2015 21:20:53 +0000 (22:20 +0100)]
ApiParse: Fix parse of new section title
Mirror how EditPage transforms a new sectiontitle to be gray, have
the arrow etc...
Bug: T84877
Change-Id: If4d8fd11386c87a5b6d51b6afbeae737b3a829a5
umherirrender [Thu, 26 Mar 2015 19:13:01 +0000 (20:13 +0100)]
Remove unneeded variable assignment in Usercreate.php
Change-Id: I8fe2e6bc3a6c63dacee8d6c8f314d9b4161b7144
Thiemo Mättig [Thu, 26 Mar 2015 15:42:14 +0000 (16:42 +0100)]
Fix inline documentation in WebResponse
Main reason to touch this file are the missing "null" types in the
documentation.
Change-Id: Ifab16c276efb3d8c4aa0a27d8d5106d4e3303794
jenkins-bot [Thu, 26 Mar 2015 18:22:06 +0000 (18:22 +0000)]
Merge "Update OOjs UI to v0.9.4"
jenkins-bot [Thu, 26 Mar 2015 16:45:51 +0000 (16:45 +0000)]
Merge "Fixed the usage of $flags in loadLastEdit()"
jenkins-bot [Thu, 26 Mar 2015 16:16:17 +0000 (16:16 +0000)]
Merge "ApiParse: Forbid section=new when using page, pageid, or oldid"
jenkins-bot [Thu, 26 Mar 2015 15:34:33 +0000 (15:34 +0000)]
Merge "LivePreview: Update the correct mw-editfooter-list"
jenkins-bot [Thu, 26 Mar 2015 15:09:47 +0000 (15:09 +0000)]
Merge "Fix typos in qunit tests"
aude [Thu, 26 Mar 2015 14:40:18 +0000 (15:40 +0100)]
Fix typos in qunit tests
seperator -> separator
Change-Id: I67ff04d11f0600dd528fa09894b48d1d2edd248f
jenkins-bot [Thu, 26 Mar 2015 14:07:54 +0000 (14:07 +0000)]
Merge "Fix misleading $class = false default in Html::infoBox"
jenkins-bot [Thu, 26 Mar 2015 13:58:22 +0000 (13:58 +0000)]
Merge "More specific types in doc tags in the Html class"
Derk-Jan Hartman [Thu, 26 Mar 2015 13:06:49 +0000 (14:06 +0100)]
LivePreview: Update the correct mw-editfooter-list
mw-editfooter-list is used by both templatesUsed and hiddencats, so
make sure we replace correct one.
Bug: T78834
Change-Id: I00be75ac6d68f96fb366b9561ec1ee0e1998f656
Niklas Laxström [Thu, 26 Mar 2015 10:44:18 +0000 (11:44 +0100)]
Make wfWarn name the caller in Http::get
The warning is useless as of now, unless you have stracktraces.
Bug: T91764
Change-Id: I8fcae49f3943ab2f6d13519c5f8d370ed147b185
Thiemo Mättig [Thu, 26 Mar 2015 09:43:01 +0000 (10:43 +0100)]
Fix misleading $class = false default in Html::infoBox
I found this because my PHPStorm complains about the type mismatch.
I could have changed the @param tag to "string|bool", but when looking
at the code, the $class variable is casted to a string anyway and
never used as a bool.
Change-Id: I3450fa8a898923bbae26830ed3be0017685020d3
Thiemo Mättig [Thu, 26 Mar 2015 09:38:35 +0000 (10:38 +0100)]
More specific types in doc tags in the Html class
This is a pure inline-documentation patch. It fixes a few actual
mistakes in documentation tags and makes some generic "array" types
more specific, if that's possible.
Change-Id: Id02e1e936624b845316b8ce99f8b8d2a1f829e97
Adam Roses Wight [Thu, 26 Mar 2015 08:57:33 +0000 (01:57 -0700)]
Fix TestingAccessWrapper::__call
We were only passing the first parameter to the wrapped object's methods.
Change-Id: I27a69d1cc1b2d048e44514af8b4ac79d7ee1fb85
jenkins-bot [Thu, 26 Mar 2015 08:18:37 +0000 (08:18 +0000)]
Merge "LivePreview: Let's not potentially mangle #wikiPreview"
Aaron Schulz [Thu, 26 Mar 2015 05:38:34 +0000 (22:38 -0700)]
Made User::loadFromRow protected for sanity
* The loading logic is complex enough without more possible
entry points to cover
* No outside callers found
Change-Id: I7e9bace35afb0a540993423cf1da98381a516ac5
Max Semenik [Mon, 23 Mar 2015 18:51:39 +0000 (11:51 -0700)]
Deprecate wfDiff()
This function is backwards:
* The stated purpose is to generate a list of differences for callers to parse,
however we already have DiffEngine that returns a list of differences that you
don't need to parse manually shooting your feet off in process.
* With improvements in PHP performance in the last 10 years, shelling out instead of using
a pure-PHP diff has a doubtful performance benefit.
* Even in configurations where it's faster on predominant diffs (which have to be huge),
shelling out has its own security implications.
This function is not used in core. The only extensons using it are Echo (which just parses
its output so would be better off with DiffEngine) and AbuseFilter, let's not add more users
by tolerating this function.
Also, add error checking while I'm at it.
Change-Id: Ia67debce39de8252312fd887ebfbe6fb89f9edc9
Aaron Schulz [Thu, 26 Mar 2015 03:50:41 +0000 (20:50 -0700)]
Made ProfilerStub return null instead of a dummy ScopedCallback
* This can happen well over 10k times per request due to the message
hooks. Avoiding the object construction seems prudent.
Change-Id: I45ff7b8c10851f15a25cbea9a2df3669ec21dbd3
Aaron Schulz [Thu, 26 Mar 2015 03:39:39 +0000 (20:39 -0700)]
Fixed the usage of $flags in loadLastEdit()
Bug: T93976
Change-Id: I57eb41b463116ea27c0fc8dac8fff07db593499a
jenkins-bot [Thu, 26 Mar 2015 02:37:02 +0000 (02:37 +0000)]
Merge "Replace mb_strtolower with strtolower"
jenkins-bot [Thu, 26 Mar 2015 00:27:44 +0000 (00:27 +0000)]
Merge "mediawiki.action.edit.preview: Replace only title in firstHeading"
Derk-Jan Hartman [Wed, 25 Mar 2015 23:55:16 +0000 (00:55 +0100)]
ApiParse: Forbid section=new when using page, pageid, or oldid
Change-Id: I45ce0fe2083587e429143aa3d8d832aa884e1ad7
Derk-Jan Hartman [Wed, 25 Mar 2015 23:33:06 +0000 (00:33 +0100)]
LivePreview: Let's not potentially mangle #wikiPreview
Sometimes you look at what you have written and realize it can be better...
Bug: T90490
Change-Id: If620e5c672e4632997028ddc9f802a82a83e6924
jenkins-bot [Wed, 25 Mar 2015 23:22:36 +0000 (23:22 +0000)]
Merge "LivePreview: Notifiy user about errors"
Derk-Jan Hartman [Sat, 28 Feb 2015 15:26:25 +0000 (16:26 +0100)]
LivePreview: Notifiy user about errors
Bug: T90490
Change-Id: Ic52311839c175a213065eec442e50b4de0463822
James D. Forrester [Wed, 25 Mar 2015 22:26:56 +0000 (15:26 -0700)]
Update OOjs UI to v0.9.4
Release notes:
https://git.wikimedia.org/blob/oojs%2Fui.git/v0.9.4/History.md
Change-Id: I0ab9ef6d67e16379785e143cb20ae8de7fe78a7e
Translation updater bot [Wed, 25 Mar 2015 20:44:14 +0000 (21:44 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I79e13cf2d6d3bc8c447b75a49ac0bdca2ae536d9
jenkins-bot [Wed, 25 Mar 2015 20:13:01 +0000 (20:13 +0000)]
Merge "Remove never thrown UploadStashNotAvailableException"
Derk-Jan Hartman [Thu, 12 Mar 2015 21:28:28 +0000 (22:28 +0100)]
LivePreview: Support section=new for preview
Reproduce the new section behavior for the full submit preview.
Diffing will require a bit more additional work in Api.
Bug: T84877
Change-Id: Iec71fdc7ba09f91683214f3d65472ea2f72a06b1
jenkins-bot [Wed, 25 Mar 2015 19:29:54 +0000 (19:29 +0000)]
Merge "PrefixSearchTest: Move insertPage() from setUp() to addDBData()"
umherirrender [Sat, 14 Mar 2015 14:12:05 +0000 (15:12 +0100)]
Remove never thrown UploadStashNotAvailableException
Also move creation of UploadStash to main entry point of the special
page to avoid use of context before it is set (by called getUser).
Change-Id: Ibcb17b6ee1b853d807f91104ba428b307e9a5208
Timo Tijhof [Mon, 23 Mar 2015 05:29:55 +0000 (05:29 +0000)]
PrefixSearchTest: Move insertPage() from setUp() to addDBData()
Doesn't change the semantics much since run() calls addDBData()
right before setUp(), but these belong addDBData() per the
documentation of setUp().
Change-Id: I304a0aff1fc6b2f0541b3dc3c9e3527772c8f91c
Timo Tijhof [Mon, 23 Mar 2015 05:36:20 +0000 (05:36 +0000)]
MediaWikiTestCase: Consistently use UTSysop user in setup/teardown
Change-Id: I42d108ca11246725d936e505508b73a9ae7553c6
Marius Hoch [Wed, 25 Mar 2015 15:09:21 +0000 (16:09 +0100)]
Fallback to read from master in DifferenceEngine::loadRevisionData
In DifferenceEngine we need to show a diff immediately after
an edit happened if someone did a rollback. To make that work
again, try loading a revision from master if we have more than
one database servers and we failed loading the revision from
a slave.
Change-Id: I08a16faa9e637c614c6d2fc9a10536c7b41685a8
Follows:
3c2bc32ae1775f5e875958b62d7181b4b5cfe24e
Bug: T93866
Niklas Laxström [Wed, 25 Mar 2015 08:53:40 +0000 (09:53 +0100)]
Replace mb_strtolower with strtolower
Function mb_strtolower is not guaranteed to be present. In this case
we are dealing with language codes, which are ASCII, for which there
is no need to use multibyte version in the first place.
Bug: T55912
Change-Id: I009bab2ff03b22142d35c8be60711266ca3683c1
Fomafix [Wed, 25 Mar 2015 05:47:18 +0000 (05:47 +0000)]
mediawiki.action.edit.preview: Replace only title in firstHeading
Bug: T85784
Change-Id: I71098997ae4e1172381350443637e51a03260d1a
Ori.livneh [Sat, 21 Mar 2015 05:14:02 +0000 (05:14 +0000)]
Revert "Optimize order of styles and scripts"
The patch did not improve performance. I'd like to think that the increased
control over when inline scripts are executed makes the patch worthwhile
regardless, but that is post hoc justification and possibly a bit of personal
ego. Krinkle agrees that we may use some of the ideas in this patch in the
future but he thinks we're better off not heading down this path before we
have a better sense of where we're going, and I trust his judgment.
This reverts commit
e86e5f8460b922cadac231142a495f3259c67b43.
Change-Id: I151f74a41dd664b5a0aa5cfd99fcc95e2686a1e6
Fomafix [Tue, 17 Mar 2015 18:56:47 +0000 (18:56 +0000)]
Update HTML title with displaytitle on live preview
Set the new global JavaScript variable 'wgEditMessage' with the name of the message.
Document this global JavaScript variable in
https://www.mediawiki.org/wiki/Manual:Interface/JavaScript#mw.config
after merge.
Bug: T88117
Change-Id: Ida5c1d470908cefd16925bd5455758d25db02113
Translation updater bot [Tue, 24 Mar 2015 20:51:17 +0000 (21:51 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Id37e5c4448f3e9b003626009b9c6b821aad4d6cc
jenkins-bot [Tue, 24 Mar 2015 19:12:23 +0000 (19:12 +0000)]
Merge "Allow callers to load user objects from slaves if desired"
Bartosz Dziewoński [Mon, 23 Mar 2015 20:55:12 +0000 (21:55 +0100)]
ResourceLoaderImageModule: Synchronize CSS with .background-image-svg LESS mixin
Bug: T87504
Change-Id: I790bd953fabbd4ff03f15c94fe101e2f65891520
Aaron Schulz [Tue, 24 Mar 2015 00:39:48 +0000 (17:39 -0700)]
Allow callers to load user objects from slaves if desired
Bug: T92357
Change-Id: Ib9d21b8ee988c84e7b3d1676ad6cbbbf07f795a4
jenkins-bot [Tue, 24 Mar 2015 17:30:31 +0000 (17:30 +0000)]
Merge "Use ksort() in getDeduplicationInfo for sanity"
jenkins-bot [Tue, 24 Mar 2015 01:18:40 +0000 (01:18 +0000)]
Merge "RELEASE-NOTES: Increase minimum MySQL version to 5.0.3"
Kevin Israel [Tue, 24 Mar 2015 00:16:45 +0000 (20:16 -0400)]
RELEASE-NOTES: Increase minimum MySQL version to 5.0.3
Follows-up
5d9b67e09ed1.
Also updated the list of supported database servers in INSTALL
to match the list from RELEASE-NOTES-1.25.
Change-Id: I6881b1163455d834b058f4b4a7839a6aea44cdab
Kevin Israel [Mon, 23 Mar 2015 23:58:06 +0000 (19:58 -0400)]
Remove unused class DBObject
This was left over from a previous attempt at Oracle support,
which was removed in 1.10 (r19196 /
ccf91e827a48).
Change-Id: I5f9b82fffc0b4f84286b697be8d504020fe22547
Translation updater bot [Mon, 23 Mar 2015 20:19:47 +0000 (21:19 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I029a05e24e48f9b5e3893f0e964aed5e8c53280c
jenkins-bot [Mon, 23 Mar 2015 19:20:08 +0000 (19:20 +0000)]
Merge "Fixed Style/StringLiterals RuboCop offense"
jenkins-bot [Mon, 23 Mar 2015 19:06:33 +0000 (19:06 +0000)]
Merge "Fixed Style/HashSyntax RuboCop offense"
jenkins-bot [Mon, 23 Mar 2015 18:57:09 +0000 (18:57 +0000)]
Merge "resourceloader: Add template compiler for Mustache JS"
Željko Filipin [Wed, 18 Mar 2015 17:59:28 +0000 (18:59 +0100)]
Fixed Style/StringLiterals RuboCop offense
$ bundle exec rubocop --auto-correct
Inspecting 25 files
CC....C.......
CCCCCCCCC.C
Offenses:
Gemfile:4:8: C: [Corrected] Prefer single-quoted strings when you don't
need string interpolation or special symbols.
source "https://rubygems.org"
^^^^^^^^^^^^^^^^^^^^^^
…
25 files inspected, 81 offenses detected, 81 offenses corrected
Bug: T91485
Change-Id: Ic6f1337fa465e8c90e5aa7ea3540eb6bfad15af8
jenkins-bot [Mon, 23 Mar 2015 18:48:04 +0000 (18:48 +0000)]
Merge "Fixed Style/PerlBackrefs RuboCop offense"
Željko Filipin [Wed, 18 Mar 2015 17:53:51 +0000 (18:53 +0100)]
Fixed Style/HashSyntax RuboCop offense
$ bundle exec rubocop --auto-correct
Inspecting 25 files
.CCC.....................
Offenses:
maintenance/jsduck/custom_tags.rb:16:16: C: [Corrected] Use the new
Ruby 1.9 hash syntax.
return { :tagname => @tagname, :doc => :multiline }
^^^^^^^^^^^
...
25 files inspected, 8 offenses detected, 8 offenses corrected
Bug: T91485
Change-Id: Ic2aff32e106c5b5eaa45839ad3310b97fcec6ddf
Željko Filipin [Wed, 18 Mar 2015 17:52:02 +0000 (18:52 +0100)]
Fixed Style/PerlBackrefs RuboCop offense
Refactored to use `Regexp#match`, avoiding use of match globals
entirely.
Bug: T91485
Change-Id: I4b1a40e153c18d92ef9e78291bc4e14781cc6978
jdlrobson [Wed, 17 Dec 2014 20:30:54 +0000 (12:30 -0800)]
resourceloader: Add template compiler for Mustache JS
Compatible library for PHP backend added by I281acc49c1.
This adds the frontend compiler.
Change-Id: I2190276a629ca882f3f5535e4e73635d2494e944
jenkins-bot [Mon, 23 Mar 2015 17:25:14 +0000 (17:25 +0000)]
Merge "Fixed Lint/UnusedMethodArgument RuboCop offense"
jenkins-bot [Mon, 23 Mar 2015 17:22:24 +0000 (17:22 +0000)]
Merge "Fixed Style/FileName RuboCop offense"
jenkins-bot [Mon, 23 Mar 2015 04:33:34 +0000 (04:33 +0000)]
Merge "resourceloader: Add @covers and minor clean up of test suites"
jenkins-bot [Mon, 23 Mar 2015 04:29:52 +0000 (04:29 +0000)]
Merge "resourceloader: Use parent getDefinitionSummary() in ResourceLoaderFileModule"
Timo Tijhof [Mon, 23 Mar 2015 03:57:45 +0000 (03:57 +0000)]
resourceloader: Add @covers and minor clean up of test suites
* Move testMixedCssAnnotations to ResourceLoaderFileModuleTest.
* Re-order data providers before test methods.
* Add relevant @covers annotations in resourceloader/ tests.
* Make test helper function private.
* Add a few @covers for methods called from OutputPage::makeResourceLoaderLink
(only one level deep, we should have separate unit tests for
the more internal helpers).
Change-Id: I2cc1757126214ed28059d4566ca813a86bcd95a7
Timo Tijhof [Mon, 23 Mar 2015 03:56:35 +0000 (03:56 +0000)]
resourceloader: Use parent getDefinitionSummary() in ResourceLoaderFileModule
Right now ResourceLoaderModule::getDefinitionSummary just returns an array
with the class name, but may be extended in the future. Either way, it shouldn't
be repeated in the subclass.
Change-Id: Ic1d58f8d330fb2176daffc7ad39bc0751c196181
Kunal Mehta [Mon, 23 Mar 2015 03:17:43 +0000 (20:17 -0700)]
TemplateParser: Use ObjectCache::newAccelerator() with fallback set
Change-Id: I202192f6bf509068941e9490d02a11bdedecd872
Kunal Mehta [Mon, 23 Mar 2015 03:06:28 +0000 (20:06 -0700)]
TemplateParser: make most functions protected, only expose processTemplate()
All of the other functions expose internal implementation details, which no
external caller should ever need. In fact, no external caller does use these
functions directly.
The TemplateParser::compile() tests were removed as they're simply just
checking LightnCandy functionality, which is something the library should be
doing.
Change-Id: If9003d40315e0e5aa361c174b764b799e3b88c34
Timo Tijhof [Sun, 22 Mar 2015 22:01:52 +0000 (22:01 +0000)]
TemplateParser: Don't fatal on cache misses
Also add regression test, and coverage for more methods.
Was trying to eval the code which had the hmac integrity check in front of it,
which causes a syntax error in valid PHP code.
Follows-up
db1866da4,
50c50bea2e.
Bug: T93436
Bug: T93511
Change-Id: Ie90074e4885de7340e53f59fdd479f5384b5eac6
Bryan Davis [Sun, 22 Mar 2015 22:18:52 +0000 (16:18 -0600)]
Update MWLoggerLegacyLogger phpdoc
Add a missing @return declaration for MWLoggerLegacyLogger::interpolate
Change-Id: Ia7d35606d63a3da92b1e38284c611de1961a0c8e
Bryan Davis [Sun, 22 Mar 2015 22:12:25 +0000 (16:12 -0600)]
Allow MWLoggerMonologHandler to take prefix from channel
Make MWLoggerMonologHandler replace a prefix of "{channel}" with the log
event channel when formatting an event for a udp2log stream. This allows
a simpler configuration for a typical Monolog configuration where
a separate file is desired for each logging channel that is emitted to
udp2log. One handler can be shared by multiple channels.
Change-Id: Ie2b24ba02b281b8d8cf2ad58d28874c710e1e2e5
Translation updater bot [Sun, 22 Mar 2015 19:45:06 +0000 (20:45 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I8313b4e6f3fddaf9ee468e10972a5923bb1201d5
jenkins-bot [Sun, 22 Mar 2015 12:07:54 +0000 (12:07 +0000)]
Merge "mediawiki.action.edit.preview: Disable if there is no #wpTextbox1"
Derk-Jan Hartman [Thu, 19 Mar 2015 21:45:53 +0000 (22:45 +0100)]
mediawiki.action.edit.preview: Disable if there is no #wpTextbox1
ProofreadPage has custom editforms for Index pages, which are not
supported by the API. These editforms have no #wpTextbox1, so disable
live preview in that case.
Bug: T78709
Change-Id: I90cba79e5a4a756454741c4070ebdf620520ab55
Amir E. Aharoni [Sat, 21 Mar 2015 20:46:21 +0000 (22:46 +0200)]
Bidi-isolate numbers of added/removed bytes in changes lists
Bug: T93484
Change-Id: I26d3c46a843b2a2114ca50ec0a366fa6b76904a9
jenkins-bot [Sat, 21 Mar 2015 17:50:39 +0000 (17:50 +0000)]
Merge "mediawiki.helplink: Use a SVG+PNG icon"