Raimond Spekking [Wed, 14 Mar 2012 20:55:01 +0000 (20:55 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Marcin Cieślak [Wed, 14 Mar 2012 20:20:53 +0000 (20:20 +0000)]
Follow-up to r15791: Rename "user" and "text" when upgrading on PostgreSQL
You can lie to me, but not to your installer.
Make DatabasePostgres::tableExists to check
for real table names, not faked ones.
DatabasePostgres is currently lying to the rest
of the MediaWiki that "mwuser" table is actually
called "user" and that "pagecontents" is called
"text". While MediaWiki does not care, the
installer (and updater do).
This allows us to overcome first hurdle
in getting MediaWiki 1.7.3 to update to trunk
on PostgreSQL and uncover further bugs.
For this commit to actually do something,
we rename those tables when upgrading to match
what we have in maintenance/postgres/tables.sql
And by the way, tell installer not to check
for "user" table, since most PostgreSQL users
will have "mwuser" instead. Picking "archive"
instead.
Thomas Gries [Wed, 14 Mar 2012 20:16:32 +0000 (20:16 +0000)]
adding two public convenience function wrappers: dropExtensionField and dropExtensionTable
Aaron Schulz [Wed, 14 Mar 2012 17:55:59 +0000 (17:55 +0000)]
Reverted r113803: makes already messy class messier (a bit to much)
Max Semenik [Wed, 14 Mar 2012 16:31:52 +0000 (16:31 +0000)]
* (bug 34889) User name should be normalized on Special:Contributions. Fixes regression from r103751.
Alexandre Emsenhuber [Wed, 14 Mar 2012 16:18:27 +0000 (16:18 +0000)]
We have DatabaseBase::selectRow() to select a single row
Alexandre Emsenhuber [Wed, 14 Mar 2012 16:04:21 +0000 (16:04 +0000)]
* (bug 34841) Fix for r103502: don't show edit links when display old page versions
Alexandre Emsenhuber [Wed, 14 Mar 2012 10:46:59 +0000 (10:46 +0000)]
Be consistent in the interface and use Title::quickUserCan() instead of Title::userCan() to show items in the interface so that when the user is blocked or the page is cascade protected there is not a part of the interface saying you can edit the page and another part not.
Alexandre Emsenhuber [Wed, 14 Mar 2012 09:52:34 +0000 (09:52 +0000)]
Don't create new Revision and Title object if we can use the ones that we already have
Aaron Schulz [Wed, 14 Mar 2012 01:42:14 +0000 (01:42 +0000)]
(bug 32827) "[Regression] Block log for IP ranges not shown on Special:Block"
Marcin Cieślak [Wed, 14 Mar 2012 00:36:11 +0000 (00:36 +0000)]
Cosmetic improvements to PostreSQL updater output
* Don't WARN on sequences already existing
* Align dots nicely to the rest
Amir E. Aharoni [Tue, 13 Mar 2012 23:09:06 +0000 (23:09 +0000)]
Bug 35034 - moved autocomment-prefix between the prefix and the arrow. Follow up to r109086.
Brion Vibber [Tue, 13 Mar 2012 22:38:14 +0000 (22:38 +0000)]
* (bug 35201) Edit buttons no longer cause jump in IE 9
Changed order of feature-detection checks so we prefer the IE method over the Mozilla method in encapsulateSelection. Fixes a problem where IE9 triggered the Mozilla mode, then mysteriously scrolled to the top of the page.
(IE9 and IE10 add a lot of standard and semi-standard HTML APIs, so this sort of thing happens from time to time. :)
Alexandre Emsenhuber [Tue, 13 Mar 2012 21:30:29 +0000 (21:30 +0000)]
Use local context to get message
Raimond Spekking [Tue, 13 Mar 2012 20:50:02 +0000 (20:50 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Krinkle [Tue, 13 Mar 2012 20:22:48 +0000 (20:22 +0000)]
moved release notes for r113737 to 1.19 (a 1.19-regression fix)
* Follows-up r113746
Aaron Schulz [Tue, 13 Mar 2012 20:09:49 +0000 (20:09 +0000)]
Reverted r113177 per CR
Siebrand Mazeland [Tue, 13 Mar 2012 19:32:41 +0000 (19:32 +0000)]
Fix plural in 'backend-fail-maxsize'
Alexandre Emsenhuber [Tue, 13 Mar 2012 19:03:59 +0000 (19:03 +0000)]
Move delcaration of User::$mAllowUsertalk out of the "cache variables" block since it's not part of it; also reorder the cache variables for consistency.
Rob Moen [Tue, 13 Mar 2012 18:41:56 +0000 (18:41 +0000)]
update RELEASE-NOTES-1.20 follow up r113737
Alexandre Emsenhuber [Tue, 13 Mar 2012 18:41:13 +0000 (18:41 +0000)]
Follow-up r113223: set the "interface" flag in Message to true by default and set it to false when the page is included.
The point is to have the fix applied to all usages of IContextSource::msg() calls instead of only SpecialPage.
Aaron Schulz [Tue, 13 Mar 2012 18:30:34 +0000 (18:30 +0000)]
[FileBackend] r113704: updated FileBackend constructor documentation
Rob Moen [Tue, 13 Mar 2012 17:57:54 +0000 (17:57 +0000)]
User:PleaseStand patch fixes bug 34972
Alexandre Emsenhuber [Tue, 13 Mar 2012 15:54:20 +0000 (15:54 +0000)]
* (bug 34887) Fix for r100138: make $3 and $4 parameters being substituted correctly in message "movepage-moved"
Alexandre Emsenhuber [Tue, 13 Mar 2012 07:39:33 +0000 (07:39 +0000)]
* (bug 35152) Fix for r92924: help message for e-mail was removed from user preferences
Aaron Schulz [Tue, 13 Mar 2012 01:46:33 +0000 (01:46 +0000)]
[FileBackend]
* Added FileJournal class to log file changes for file backends. This can be used for migrations (like moving to Swift), syncing mirror repos, consistency checks, finishing/reverting operation batches, and such. The default journal is the "null" journal, which simply does nothing.
* Added the optional schema change required for using the DBFileJournal (MySQL, SQLite).
Aaron Schulz [Tue, 13 Mar 2012 01:44:39 +0000 (01:44 +0000)]
Tweak testFileRepoConstructionWithRequiredOptions so that it doesn't fail depending on the config of the wiki being tested on.
Aaron Schulz [Tue, 13 Mar 2012 00:32:47 +0000 (00:32 +0000)]
(bug 34978) Use a rev parent batch query to get the diff sizes for history pages rather than rely on assumptions that break if any filtering is used.
Aaron Schulz [Tue, 13 Mar 2012 00:18:29 +0000 (00:18 +0000)]
r113688: updated test assertions
Aaron Schulz [Tue, 13 Mar 2012 00:05:23 +0000 (00:05 +0000)]
Made wfShellMaintenanceCmd() not totally broken due to excess shell escaping.
Alexandre Emsenhuber [Mon, 12 Mar 2012 21:17:23 +0000 (21:17 +0000)]
Revert r113650 and reapply r113619 and r113649 with one modification: User::createNew() was missing a DatabaseBase::timestamp() call
Raimond Spekking [Mon, 12 Mar 2012 20:46:25 +0000 (20:46 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Marcin Cieślak [Mon, 12 Mar 2012 19:58:27 +0000 (19:58 +0000)]
Revert r113619, r113649: Breaks unit tests
https://integration.mediawiki.org/ci/job/MediaWiki-postgres-phpunit/3210/console
Maybe a new property with unpredictable
value breaks some tests. Need to investigate.
Marcin Cieślak [Mon, 12 Mar 2012 19:35:38 +0000 (19:35 +0000)]
Fix r113619: Convert timestamp to the backend database value
Alexandre Emsenhuber [Mon, 12 Mar 2012 19:01:44 +0000 (19:01 +0000)]
* Put the timer stuff after leading line breaks in debug log entries (mainly for the first call on a request) so that they are placed near the remaing text and not on its own line
* Normalise line breaks in the first entry on a web request so that it's consistent with the one for command line requests
Sam Reed [Mon, 12 Mar 2012 16:55:25 +0000 (16:55 +0000)]
Add a getValue method...
Alexandre Emsenhuber [Mon, 12 Mar 2012 14:04:20 +0000 (14:04 +0000)]
Removed the remaining parts of "cookie password" stuff, does nothing and no longer used since ages
Alexandre Emsenhuber [Mon, 12 Mar 2012 13:07:50 +0000 (13:07 +0000)]
Set the user_touched field directly when adding a new user to the database so that the field is correct when someone does not call saveSettings() after addToDatabase()
Ryan Kaldari [Mon, 12 Mar 2012 12:43:35 +0000 (12:43 +0000)]
fix for bug 34696 - mw.loader.using shouldnt call callback more than once
Daniel Friesen [Mon, 12 Mar 2012 05:24:54 +0000 (05:24 +0000)]
Revert r113610, it appears it's impossible to fix vector in a sane way. If we try to fix it without images then the white in the version with images that's supposed to be there disappears. And that can't be fixed because that part of vector uses a variable em height disabling the ability to fix the issue by editing the uploaded image.
Daniel Friesen [Mon, 12 Mar 2012 04:34:28 +0000 (04:34 +0000)]
Tweak background colours in Vector's css so that Vector looks sane when images are disabled.
Siebrand Mazeland [Mon, 12 Mar 2012 00:50:10 +0000 (00:50 +0000)]
rebuildLanguage.php
Sam Reed [Sun, 11 Mar 2012 23:40:33 +0000 (23:40 +0000)]
Bug 35162 - Change in Database api break extension MSSQLBackCompat
$canonicalDBTypes is probably superfluous information, but doesn't harm as a shortcut
Ping r108051
Robin Pepermans [Sun, 11 Mar 2012 23:35:51 +0000 (23:35 +0000)]
r113599: add to names.php & release note
Sam Reed [Sun, 11 Mar 2012 23:28:11 +0000 (23:28 +0000)]
Over 40% completion of MediaWiki core messages translated
Sam Reed [Sun, 11 Mar 2012 22:05:54 +0000 (22:05 +0000)]
More of r113580
Raimond Spekking [Sun, 11 Mar 2012 20:39:18 +0000 (20:39 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Sun, 11 Mar 2012 18:54:55 +0000 (18:54 +0000)]
Normalise casing of getArticleID used in core
Robin Pepermans [Sun, 11 Mar 2012 14:53:30 +0000 (14:53 +0000)]
r113572 in trunk file too
Robin Pepermans [Sun, 11 Mar 2012 03:25:22 +0000 (03:25 +0000)]
Remove the explicit user lang/dir attributes, because variant names are usually not in the user language, and there are lang attributes on those li items.
Raimond Spekking [Sat, 10 Mar 2012 22:57:43 +0000 (22:57 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Daniel Friesen [Sat, 10 Mar 2012 22:26:40 +0000 (22:26 +0000)]
Move printfooter hiding css from multiple stylesheets into shared.css where it should belong.
Robin Pepermans [Sat, 10 Mar 2012 02:07:31 +0000 (02:07 +0000)]
fix r113403
Benny Situ [Sat, 10 Mar 2012 00:31:54 +0000 (00:31 +0000)]
followup to -r113545 - add null for missing $default param
Sam Reed [Fri, 9 Mar 2012 23:33:42 +0000 (23:33 +0000)]
Documentation, spaces, braces, explicit member variables
Roan Kattouw [Fri, 9 Mar 2012 23:27:28 +0000 (23:27 +0000)]
(bug 34521) Returning to the previous page after logging in loses any array-valued parameters in the query string. This happens because WebRequest::getValues() calls getVal() which strips arrays, even though the doc comment says that no transformation is applied. Changed getValues() to call getGPCVal() instead. The only difference is that arrays are no longer stripped, so the doc comment is no longer a lie
Siebrand Mazeland [Fri, 9 Mar 2012 23:23:01 +0000 (23:23 +0000)]
Add message keys for 18 missing summary messages.
* Patch for bug 34319 for Special:DeletedContributions and Special:Contributions contributed by Srikanth Lakshmanan
* Other 16 instances identified by Der Umherirrende on translatewiki.net (https://translatewiki.net/wiki/Thread:Support/Missing_summary_message_keys_in_message_files), code updates by me.
Aaron Schulz [Fri, 9 Mar 2012 22:59:13 +0000 (22:59 +0000)]
Make sure ForkController nukes any connection resources that backends might have before forking
Raimond Spekking [Fri, 9 Mar 2012 22:30:45 +0000 (22:30 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Marcin Cieślak [Fri, 9 Mar 2012 22:29:22 +0000 (22:29 +0000)]
Fix PostgreSQL updater broken by r113487
Alexandre Emsenhuber [Fri, 9 Mar 2012 20:37:44 +0000 (20:37 +0000)]
Let's be consistent and use the same check to show an the deleted version and cascade the parameter
Alexandre Emsenhuber [Fri, 9 Mar 2012 20:26:08 +0000 (20:26 +0000)]
No need to create a new Revision object if we already have one available
Aaron Schulz [Fri, 9 Mar 2012 19:36:19 +0000 (19:36 +0000)]
Made FileOp::allowStaleReads take a boolean argument (more versatile) and killed a few lines of code.
Sam Reed [Fri, 9 Mar 2012 19:05:29 +0000 (19:05 +0000)]
Fix syntax error and indenting from r113487
Sam Reed [Fri, 9 Mar 2012 19:01:30 +0000 (19:01 +0000)]
PHP Fatal error: Call to undefined method DatabasePostgres::getCoreSchea() in /var/lib/jenkins/jobs/MediaWiki-postgres-phpunit/workspace/mw-core/includes/installer/PostgresUpdater.php on line 309
Ping r113487
Sam Reed [Fri, 9 Mar 2012 18:55:12 +0000 (18:55 +0000)]
Fix up some documentation weirdness from r113487
Sam Reed [Fri, 9 Mar 2012 18:52:31 +0000 (18:52 +0000)]
Fix broken unit tests post r113487
[exec] PHP Fatal error: Call to a member function getCoreSchema() on a non-object in /var/lib/jenkins/jobs/MediaWiki-postgres-phpunit/workspace/mw-core/includes/db/DatabasePostgres.php on line 216
Max Semenik [Fri, 9 Mar 2012 18:32:03 +0000 (18:32 +0000)]
(bug 23795) Add parser itself to ParserMakeImageParams hook.
Marcin Cieślak [Fri, 9 Mar 2012 17:24:57 +0000 (17:24 +0000)]
Handle PostgreSQL transaction errors and improve schema detection
* Introduce $wgDebugDBTransactions facility to help
figure out what's going on with transactions.
Currently PostgreSQL only.
PostgresTransactionState can be easily be made more general
to trace all sorts of state machinery.
* Improve r113408: we don't need to full reconnect on error,
rollback is enough.
Rolling back breaks search_path, as PostgreSQL
can manage sessions settings under transaction therefore
we need to improve schema sniffing introduced in r82674
* Introduce few schema handling functions. This could
probably be generalized for other databases like DB2 and Oracle.
* Fix bug 15816 - Add a switch for SETting the search_path
We try to avoid touching search_path at all unless
really necessary. Even in this case we append MediaWiki
core schema to the front of the list.
* No longer add $wgDBmwschema to PostgreSQL role search_path
in the installer. This is no longer necessary as
setting schema on connect should ReallyWorkNow(tm).
* Get rid as much as possible of $wgDBmwschema and
bring us one step closer to fix bug 16794 (wgSharedDB
support).
All references to core MediaWiki schema in PostgreSQL
specific code should now use Database::getCoreSchema()
unless we know what we are doing.
Followup-To: r113408 r82674
Aaron Schulz [Fri, 9 Mar 2012 16:01:11 +0000 (16:01 +0000)]
r113416: added missing parameter to message
Alexandre Emsenhuber [Fri, 9 Mar 2012 14:50:39 +0000 (14:50 +0000)]
Use WikiPage::getRevision() instead of another Revision object if the oldid parameter corresponds to the page's latest revision
Krinkle [Fri, 9 Mar 2012 05:40:36 +0000 (05:40 +0000)]
release-notes (rr113415)
Aaron Schulz [Fri, 9 Mar 2012 01:18:32 +0000 (01:18 +0000)]
Disable file locking for thumbnail purging just as it already is with creation/updates (for performance).
Aaron Schulz [Thu, 8 Mar 2012 22:51:43 +0000 (22:51 +0000)]
Added backend-fail-maxsize failure message and use it instead of the vague "could not store" type message.
Max Semenik [Thu, 8 Mar 2012 22:51:39 +0000 (22:51 +0000)]
(bug 25095) Special:Categories doesn't show first relevant item when "from" is filled
Aaron Schulz [Thu, 8 Mar 2012 22:31:04 +0000 (22:31 +0000)]
[FileBackend] Made doOperations() Status handling align with documentation as well as what FileRepo is essentially expecting when using the 'force' option (it assumes fatals are for total batch failures, not just partial ones). The relevant documentation was also improved.
Marcin Cieślak [Thu, 8 Mar 2012 21:44:03 +0000 (21:44 +0000)]
PostgreSQL: Improve SQL error handling
After a query error, PostgreSQL transaction is aborted
until it's terminated or the query is closed.
All further queries result in:
ERROR: current transaction is aborted, commands ignored
until end of transaction block
Those subsequent errors are ignored by double fault handling in
DatabaseBase::reportQueryError but they cause all localization
of error messages to fail (unable to issue queries to message
tables) and errors lke
This resulted in a broken MediaWiki screen with
<databaseerror>
<dberrortext>
instead of localized error message.
We need to fully reset database connection because after
pg_connection_reset() various session parameters need to
be set again (like "search_path"), otherwise tables will not be
found.
ERROR: relation "msg_resource" does not exist
ERROR: relation "l10n_cache" does not exist
Alexandre Emsenhuber [Thu, 8 Mar 2012 21:39:13 +0000 (21:39 +0000)]
* (bug 35019) Fix for rr99942: edit summaries are no longer transformed in notification e-mails
Robin Pepermans [Thu, 8 Mar 2012 20:56:26 +0000 (20:56 +0000)]
Update core usage of getLanguageName[s].
Raimond Spekking [Thu, 8 Mar 2012 20:35:25 +0000 (20:35 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Thu, 8 Mar 2012 20:06:49 +0000 (20:06 +0000)]
* (bug 35014) Fix for r100529: including a special page no longer sets the page's title to the included page
Robin Pepermans [Thu, 8 Mar 2012 19:30:30 +0000 (19:30 +0000)]
Follow-up r112479
* Add @since, fix indentation.
* Change default from 'all' to 'mw' as it's the most used (so default fetchLanguageNames() is equivalent to default getLanguageNames()).
* Add the include parameter also to fetchLanguageName() as it's needed in Parser: interlanguage links should only take into account mediawiki names. (Doesn't make a difference with how the functions are now, but could have been later.)
Krinkle [Thu, 8 Mar 2012 03:19:51 +0000 (03:19 +0000)]
[ObjectCache.php] typo from r112985
Tim Starling [Thu, 8 Mar 2012 00:49:50 +0000 (00:49 +0000)]
(bug 34929) Show the correct diff when a section edit is rejected by the spam filter. Use EditPage::showDiff() so that the same kind of diff is shown as when you click the "show changes" button. I considered changing the source text to be the original section text, but if you do that, the line numbers are wrong and section=new doesn't show you the headline which may have matched the spam filter.
Ryan Kaldari [Thu, 8 Mar 2012 00:34:42 +0000 (00:34 +0000)]
better error message and comment
Ryan Kaldari [Wed, 7 Mar 2012 23:51:05 +0000 (23:51 +0000)]
typo fix
Ryan Kaldari [Wed, 7 Mar 2012 23:48:45 +0000 (23:48 +0000)]
adding note for new API functionality
Tim Starling [Wed, 7 Mar 2012 23:00:42 +0000 (23:00 +0000)]
Fix for r113312: explain the bug without the use of commented-out code
Aaron Schulz [Wed, 7 Mar 2012 22:46:47 +0000 (22:46 +0000)]
[FileRepo]
* Made upload() explicitly check $status->successCount rather than isOk() as FileRepo::publish() gives fatal statuses where it used to only give warnings. This way, failed uploads still displace the current image DB row to oldimage rather than do nothing and have the same image row point to a new file (which can cause mismatched metadata).
* Disabled exception about invalid oi_archive_name. This makes things more broken in that when people get this an error on upload (which happens when the FS has no current file but the DB does), the new file is added as the current version in the FS but the DB is unchanged. Thus, the metadata can be mismatched.
Benny Situ [Wed, 7 Mar 2012 21:45:38 +0000 (21:45 +0000)]
followup to -r112918 - display old title in SpecialNews page when namespace or title text has been changed
Raimond Spekking [Wed, 7 Mar 2012 21:06:01 +0000 (21:06 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Krinkle [Wed, 7 Mar 2012 20:45:31 +0000 (20:45 +0000)]
Follow-up r113277: release-notes
Roan Kattouw [Wed, 7 Mar 2012 19:33:37 +0000 (19:33 +0000)]
(bug 35036) Wikipage-based ResourceLoader modules were not automatically purged as they should be when one of their messages changed. In practice, this only affected WikiLove.
Also adding a documentation comment in ResourceLoaderModule to clarify that it is the subclass's responsibility to make sure message blob timestamps are taken into account
Krinkle [Wed, 7 Mar 2012 19:14:20 +0000 (19:14 +0000)]
[Html::namespaceSelector] Remove default id/name attributes
* Remove default id/name attributes
* Remove now redundant tests introduced in r110274
* Add tests to make sure label has no 'for' attribute when label isn't null but name/id are unset
* Update tests to not include id="" and name="" when calling with no arguments
* Updating calls to add name/id if needed, and while at it remove useless 'null' params
* Context:
-- Introduced in r109990, r111376, r111315
-- No callers exist that assume these defaults. Forcing an ID that should be unique is annoying and redundant. The name used in the query when submitting a form should be mentioned in the same file where it is used from the submission, never assume what name="" is from unrelated code
-- Same for ID, this is often used in CSS or JavaScript, shouldn't be assumed. (It should be simple to but two simple namespace selectors on a page without getting DOM conflicts)
Jeroen De Dauw [Wed, 7 Mar 2012 19:07:40 +0000 (19:07 +0000)]
Follow up to r113142; fix incorrect conversion to array (value can be array already)
Krinkle [Wed, 7 Mar 2012 19:00:38 +0000 (19:00 +0000)]
Follows-up r113214: span ternary operator over multiple lines for readability
Niklas Laxström [Wed, 7 Mar 2012 10:13:58 +0000 (10:13 +0000)]
My proposed fix to bug 34987: gender not working in many special pages.
I haven't checked if there are other places whereh context is set to Message class, but if there are they might need a fix too.
Antoine Musso [Wed, 7 Mar 2012 10:07:32 +0000 (10:07 +0000)]
warn that dumpBackup does not actually backup the wiki!
The user table is not dumped by that tool. The warning notice makes it clear
and will avoid someone having some trouble recovering his precious private
data.
Antoine Musso [Wed, 7 Mar 2012 09:56:24 +0000 (09:56 +0000)]
(bug 34302) Add CSS classes to email fields in user preferences
Patch by Nischay Nahata whom I have mentored earlier this week.
Krinkle [Wed, 7 Mar 2012 02:58:11 +0000 (02:58 +0000)]
[mw.util.tooltipAccessKeyPrefix] alt-shift for Chrome on Windows
* Fixes:
-- (bug 29753) mw.util.tooltipAccessKeyPrefix should be alt-shift for Chrome on Windows