jenkins-bot [Wed, 16 Nov 2016 11:26:44 +0000 (11:26 +0000)]
Merge "mw.ForeignStructuredUpload.BookletLayout: Remove incorrect comment"
Bartosz Dziewoński [Wed, 16 Nov 2016 10:42:25 +0000 (11:42 +0100)]
mw.ForeignStructuredUpload.BookletLayout: Remove incorrect comment
This was added in
c0fb8a883633f110a8083a164672e8334714d450;
the issue was fixed in
f2fbab67a16dec81cd1cd4751b5bb820f064b523.
Change-Id: I61d9af66f34d97765ed1b32e305e017779cb93ca
Hashar [Wed, 16 Nov 2016 10:35:20 +0000 (10:35 +0000)]
Revert "objectcache: detect default getWithSetCallback() set options"
Causes HHVM 3.12.7 to segfault and or:
Fatal error: Stack overflow in includes/libs/objectcache/BagOStuff.php on line 754
This reverts commit
b47ce21cec3a4340dd37c773210a514350f10297.
Bug: T150833
Change-Id: Ia52fdf65f5e386c0eaa1046328680fb5c8a9081a
jenkins-bot [Wed, 16 Nov 2016 08:37:07 +0000 (08:37 +0000)]
Merge "Reduce default cookie expiration time to 30 days"
Gergő Tisza [Tue, 15 Nov 2016 02:51:31 +0000 (02:51 +0000)]
Reduce default cookie expiration time to 30 days
Cookie expiration time was increased to 180 day in
7d7ebfc to make
logins last longer. Since
16cea35 made login cookie length separately
configurable, this setting does not make much sense anymore and should
be restored to a more privacy-friendly default.
Change-Id: Ia2d200a20c4954fa7cd50197f44471e98061a425
jenkins-bot [Wed, 16 Nov 2016 05:12:26 +0000 (05:12 +0000)]
Merge "objectcache: Remove broken cas() method from WinCacheBagOStuff"
Aaron Schulz [Fri, 11 Nov 2016 20:14:51 +0000 (12:14 -0800)]
objectcache: Remove broken cas() method from WinCacheBagOStuff
Bug: T120896
Change-Id: I9406a50df8e900b4fc5861c2174ba7a63a0dd765
Aaron Schulz [Sat, 22 Oct 2016 04:12:12 +0000 (21:12 -0700)]
objectcache: detect default getWithSetCallback() set options
This works by setting a callback to return the cache set
options. The callback will watch DB reads and create a
merged result from said usage.
This handles callers that are missing getCacheSetOptions().
Change-Id: Ia264f011e45e8cf105480955dad7e2c4c2357b73
jenkins-bot [Wed, 16 Nov 2016 02:46:31 +0000 (02:46 +0000)]
Merge "Make NumericUppercaseCollation use localized digit transforms"
jenkins-bot [Wed, 16 Nov 2016 02:16:20 +0000 (02:16 +0000)]
Merge "Add first letter data for bn collation (Standard and Traditional)"
jenkins-bot [Wed, 16 Nov 2016 01:25:28 +0000 (01:25 +0000)]
Merge "build: Bump eslint-config-wikimedia to v0.3.0 (already passes)"
Tim Starling [Tue, 15 Nov 2016 05:11:15 +0000 (16:11 +1100)]
Rewrite runBatchedQuery.php
This maintenance script was previously introduced as a way to do large
UPDATE queries in a replication safe way. However, in modern versions of
MySQL, UPDATE...LIMIT is considered a non-replication-safe query, and
will emit a warning.
So instead, ask the user to provide slightly more structured data about
the update query being done, and partition the table based on an index.
In the UPDATE queries, specify index ranges instead of using LIMIT.
Also add a "db" option, which allows the script to update databases
which are not valid wiki names, for example, centralauth.
Change-Id: I462bdcb03e107af9db4738895952d5110f0ec4fc
jenkins-bot [Wed, 16 Nov 2016 00:21:23 +0000 (00:21 +0000)]
Merge "build: Replace jscs+jshint with eslint"
jenkins-bot [Wed, 16 Nov 2016 00:18:12 +0000 (00:18 +0000)]
Merge "Throttler: improve log message compatibility with Monolog logger"
Brian Wolff [Thu, 27 Oct 2016 08:09:11 +0000 (08:09 +0000)]
Add first letter data for bn collation (Standard and Traditional)
This is based solely on looking at the bn.txt collation data
file. It has not been tested by native speakers.
Bug: T148885
Change-Id: Ide926bc5ee8752269ef6a1bfe972e19b7188d193
jenkins-bot [Tue, 15 Nov 2016 23:36:18 +0000 (23:36 +0000)]
Merge "Add ParserFetchTemplate hook"
James D. Forrester [Tue, 15 Nov 2016 23:15:18 +0000 (15:15 -0800)]
build: Bump eslint-config-wikimedia to v0.3.0 (already passes)
Change-Id: Iee727a4521acd8c221733c7bd763cbf2adb9bd49
Ed Sanders [Tue, 15 Nov 2016 21:02:04 +0000 (21:02 +0000)]
build: Replace jscs+jshint with eslint
Change-Id: Id0a23c03aabadfaf2ec705528ae4b3bd0908fa3e
jenkins-bot [Tue, 15 Nov 2016 22:47:23 +0000 (22:47 +0000)]
Merge "parserTests: Use a mock parser during article insertion"
Bryan Davis [Tue, 15 Nov 2016 22:18:08 +0000 (15:18 -0700)]
Throttler: improve log message compatibility with Monolog logger
The `type` log event attribute is used in Wikimedia production logging
to categorize log events by source (e.g. 'mediawiki', 'restbase', etc).
Adding a `type` key to the logging context overwrites the default value
of 'mediawiki'. Rename the key to `throttle` in the context and the
message template.
Change-Id: Ic274159774e43a8749f83c850fff7897956cf377
jenkins-bot [Tue, 15 Nov 2016 22:03:02 +0000 (22:03 +0000)]
Merge "Fix typo in #getDateFromExif"
jenkins-bot [Tue, 15 Nov 2016 21:31:17 +0000 (21:31 +0000)]
Merge "Make /*jshint -W024*/ global to allow 'static' as property"
Translation updater bot [Tue, 15 Nov 2016 21:14:19 +0000 (22:14 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I1a4e9666a3207aecab05e6c377515e548d63aebd
Ed Sanders [Tue, 15 Nov 2016 21:02:56 +0000 (21:02 +0000)]
Fix typo in #getDateFromExif
Actually use fileStr instead of fileReader.result directly.
Change-Id: I470799c65c06e191c8ca81aee2f286676be1c8f9
jenkins-bot [Tue, 15 Nov 2016 20:43:02 +0000 (20:43 +0000)]
Merge "Add parser test for "Piped link with empty link text""
Bartosz Dziewoński [Wed, 2 Nov 2016 20:00:40 +0000 (21:00 +0100)]
Make /*jshint -W024*/ global to allow 'static' as property
We use it all over the place in things that use OOjs, which uses the
'static' property internally. While we support some non-ES5 browsers,
this ES5 feature (being able to parse code that uses a reserved word
as an object property name) works in all of them too.
Change-Id: If641642242292fe38c95f690a9409edaf3683a9f
umherirrender [Sat, 25 Jun 2016 19:39:50 +0000 (21:39 +0200)]
Add parser test for "Piped link with empty link text"
Change-Id: Iea2bcf3d3ff618973d2300fef702fa0667db3c93
jenkins-bot [Tue, 15 Nov 2016 18:43:33 +0000 (18:43 +0000)]
Merge "ApiSandbox: Add text about limit's "max" value"
Bartosz Dziewoński [Tue, 15 Nov 2016 17:55:48 +0000 (18:55 +0100)]
mw.jqueryMsg: Match behavior when key does not exist to PHP
Follow-up to
e681e5d8c974914f957e24fd29de5caf160152fb. This only
affects the output of '{{int:}}' in jqueryMsg-parsed messages.
See
184658eb32f6c5561cd3789716bd98c1e9f0ba04.
Change-Id: I90390e014b897084692fb1a86a5a8bcefd93ff11
jenkins-bot [Tue, 15 Nov 2016 18:02:35 +0000 (18:02 +0000)]
Merge "ApiSandbox: Don't use OO.ui.NumberInputWidget for limit fields"
James D. Forrester [Tue, 15 Nov 2016 17:28:03 +0000 (09:28 -0800)]
Follow-up
e681e5d: Correct typo in test comment
Change-Id: I9212b38cb5335eea722c7be258460305dd011653
Translation updater bot [Tue, 15 Nov 2016 14:08:35 +0000 (15:08 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I88c0084340fa0a55f72cfce2b82e55a8fce1631c
jenkins-bot [Tue, 15 Nov 2016 09:44:31 +0000 (09:44 +0000)]
Merge "Initialize gallery slideshow on wikipage.content hook"
jenkins-bot [Tue, 15 Nov 2016 09:34:53 +0000 (09:34 +0000)]
Merge "Fix message name for passwordreset-invalidemail"
jenkins-bot [Tue, 15 Nov 2016 05:25:34 +0000 (05:25 +0000)]
Merge "Fix multiple bugs in EncryptedPassword"
Tim Starling [Mon, 14 Nov 2016 10:04:30 +0000 (21:04 +1100)]
Fix multiple bugs in EncryptedPassword
* openssl_decrypt() expects the encrypted string you give it to be the
exact one that came out of openssl_encrypt(), it doesn't expect you to
pre-decode the base64 encoding. So don't do that.
* Use the same IV when re-encrypting the underlying hash for comparison.
* Check the return value of OpenSSL functions, and report meaningful
error messages, for sysadmin convenience and to avoid e.g. giving all
users the same hash if an invalid cipher method was chosen (which was
the previous behaviour).
* Fix EncryptedPassword::update(). Tested it with eval.php since there
doesn't seem to be any callers.
Change-Id: I3a39de152d0329f93d16aa4ed43faf08f665b8e2
jenkins-bot [Tue, 15 Nov 2016 03:48:31 +0000 (03:48 +0000)]
Merge "Fix SpecialPasswordResetOnSubmit parameter handling"
Brian Wolff [Tue, 15 Nov 2016 03:40:42 +0000 (03:40 +0000)]
Fix message name for passwordreset-invalidemail
This adjust the qqq.json and en.json file. I didn't touch the
other language files for fear of messing with however translatewiki
export works.
Change-Id: Ia4b7a9230b0a1cd9aacdcb57ccde186d469c9571
jenkins-bot [Tue, 15 Nov 2016 03:05:00 +0000 (03:05 +0000)]
Merge "Followup to I5b47e5a"
Gergő Tisza [Tue, 15 Nov 2016 02:27:02 +0000 (02:27 +0000)]
Fix SpecialPasswordResetOnSubmit parameter handling
Special:PasswordReset will take either the username or the email
into account but never both. Reflect this in the way parameters
are passed to the hook.
This also makes sure hook handlers never receive an unsanitized
email address.
Change-Id: I8d3b3d81e0cd5f92e5cd0a866a16695638610592
Gergő Tisza [Tue, 15 Nov 2016 02:39:44 +0000 (02:39 +0000)]
Followup to I5b47e5a
We have logging now, just not in this class.
Change-Id: Idd3c2cbcc22d06428740f9310a8116ce6f1fa355
jenkins-bot [Tue, 15 Nov 2016 02:34:19 +0000 (02:34 +0000)]
Merge "Add better logging to password reset"
Tim Starling [Mon, 14 Nov 2016 23:54:44 +0000 (10:54 +1100)]
Accept salted password hashes with :A: prefixes
Partially reverting Icb809274f9f63.
The broken :A: prefixed passwords generated by MW before that change
were apparently written back to the database -- there are 2.5M in enwiki
alone. Accepting them should not depend on $wgPasswordSalt, which is a
deprecated global and should soon be removed.
Change-Id: I772de0fb17245d080eb15a7d5df6bf3125e1f71a
Derk-Jan Hartman [Mon, 14 Nov 2016 21:46:10 +0000 (22:46 +0100)]
Initialize gallery slideshow on wikipage.content hook
The slideshow mode of gallery tag was triggered upon document.ready,
instead of on wikipage.content. For this reason, after editing and
saving one of these galleries in VE, you would loose your slideshow
mode and default back to packed mode.
Change-Id: I411703b3c1cafbd7d763cbaa8bc9585924c51030
Translation updater bot [Mon, 14 Nov 2016 21:05:39 +0000 (22:05 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I5c7b9e3268660018c11fd7ccf68178e2decac011
jenkins-bot [Mon, 14 Nov 2016 19:46:30 +0000 (19:46 +0000)]
Merge "Add extra logging for when user logs in with a temp password"
jenkins-bot [Mon, 14 Nov 2016 17:08:59 +0000 (17:08 +0000)]
Merge "Wait for Slave Lag to catch up in wrapOldPasswords.php"
Brad Jorsch [Mon, 14 Nov 2016 17:01:50 +0000 (12:01 -0500)]
ApiSandbox: Add text about limit's "max" value
In action=help this is reflected by the "Type" field, but that field
isn't displayed in ApiSandbox.
Change-Id: I7e491acc8ba7fdc3463f3cf1656b13fb3949d7d3
Brad Jorsch [Mon, 14 Nov 2016 16:52:16 +0000 (11:52 -0500)]
ApiSandbox: Don't use OO.ui.NumberInputWidget for limit fields
According to T150455#
2789277 it shouldn't be able to allow 'max' even
though this is a mostly-numeric field with one non-numeric value.
Oh well.
Change-Id: I620a233aab20c715db354eff77ea8a3ffee3bc77
jenkins-bot [Mon, 14 Nov 2016 16:54:02 +0000 (16:54 +0000)]
Merge "mw.Message: Match behavior when key does not exist to PHP"
jenkins-bot [Mon, 14 Nov 2016 16:43:18 +0000 (16:43 +0000)]
Merge "Fix interpretation of "A-type" password hashes"
Reedy [Mon, 14 Nov 2016 16:42:33 +0000 (16:42 +0000)]
Wait for Slave Lag to catch up in wrapOldPasswords.php
Change-Id: Ib02be41c8166a3567d2a1c61352cb383fbb7aee9
Bartosz Dziewoński [Mon, 14 Nov 2016 15:14:37 +0000 (16:14 +0100)]
mw.Message: Match behavior when key does not exist to PHP
See
184658eb32f6c5561cd3789716bd98c1e9f0ba04.
Change-Id: I3dba16bcb137ca2f52203bce95f8c044870af3fd
WMDE-Fisch [Fri, 11 Nov 2016 16:58:11 +0000 (17:58 +0100)]
Add missing doc param
Change-Id: I674b0bdaab33f858a63afb1dfa04618311086ab5
MarcoAurelio [Fri, 11 Nov 2016 16:41:32 +0000 (17:41 +0100)]
Gorontalo (gor) to Names.php and RELEASE-NOTES-1.28
Bug: T136083
Change-Id: Ib3e46962de9cc7abc2052cfdf06e95f898e36142
Tim Starling [Mon, 14 Nov 2016 05:47:03 +0000 (16:47 +1100)]
Fix interpretation of "A-type" password hashes
An A-type hash is an unsalted hash. A B-type hash is a salted hash of
the form md5(salt "-" md5(password)). So it's not correct to have an
A-type hash with a salt. User::comparePasswords() and
CentralAuthUser::getPasswordFromString() already get this right, they
generate :B: prefixes for legacy salted hashes where the salt is not
specified in the database.
Change-Id: Icb809274f9f63641e54daf98332a5646fd58b550
Translation updater bot [Sun, 13 Nov 2016 21:08:23 +0000 (22:08 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I1de41d1ef19a714081976ddd1d0845952db6a323
jenkins-bot [Sun, 13 Nov 2016 15:17:42 +0000 (15:17 +0000)]
Merge "Karelian (krl) to Names.php and RELEASE-NOTES-1.28"
Brian Wolff [Sun, 13 Nov 2016 05:11:49 +0000 (05:11 +0000)]
Add extra logging for when user logs in with a temp password
It would be good to keep better track of this in the logs
Change-Id: I7f33b45f83034bfa1c003c149e92917b2f045988
Brian Wolff [Sun, 13 Nov 2016 02:40:38 +0000 (02:40 +0000)]
Add better logging to password reset
In particular we definitely want to log capturing resets.
Change-Id: I5b47e5aa6efdc6414238d8e8f97a8f823111ff46
Translation updater bot [Sat, 12 Nov 2016 21:06:12 +0000 (22:06 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Iaa6a4d7d2d13b59fe16ac650465c3e3b5d9d814b
MarcoAurelio [Fri, 11 Nov 2016 16:50:18 +0000 (17:50 +0100)]
Karelian (krl) to Names.php and RELEASE-NOTES-1.28
* Added Karelian (krl) to Names.php.
* Added mention to RELEASE-NOTES-1.28
* Created MessagesKrl.php and $fallback = 'fi';
Bug: T137415
Change-Id: Iee2d03d042c8b514ee2575450a37158b26c732a3
jenkins-bot [Fri, 11 Nov 2016 23:59:24 +0000 (23:59 +0000)]
Merge "MediaWiki namespace (and talk) back to English in MessagesCdo.php"
jenkins-bot [Fri, 11 Nov 2016 22:24:00 +0000 (22:24 +0000)]
Merge "Add !!html/php parser test for HTML comment after template name"
Translation updater bot [Fri, 11 Nov 2016 21:05:03 +0000 (22:05 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ibc4d14ebcf6e6cd78fe2cd4b9c8344fd5a181a78
jenkins-bot [Fri, 11 Nov 2016 19:29:21 +0000 (19:29 +0000)]
Merge "More robust, cleaned up MessageTest"
jenkins-bot [Fri, 11 Nov 2016 18:19:38 +0000 (18:19 +0000)]
Merge "Get StatsdDataFactory from MediaWikiServices"
MarcoAurelio [Fri, 11 Nov 2016 17:49:20 +0000 (18:49 +0100)]
MediaWiki namespace (and talk) back to English in MessagesCdo.php
Bug: T122428
Change-Id: I740addd0fce913ca74394c663c6858849aa4e2d5
Amire80 [Fri, 11 Nov 2016 09:19:05 +0000 (11:19 +0200)]
Add !!html/php parser test for HTML comment after template name
I came looking for a test with comments inside transclusions
because of bug T89615. I could only find a test for Parsoid
and not for PHP, so I added it.
Bug: T89615
Change-Id: I4ee3bc75ec86cc6fde6449790b81d287f0ca8345
WMDE-Fisch [Fri, 11 Nov 2016 16:48:02 +0000 (17:48 +0100)]
Get StatsdDataFactory from MediaWikiServices
Change-Id: Ia4a32e7932299168649b6472f503249630fd7c1e
Thiemo Mättig [Fri, 11 Nov 2016 09:53:10 +0000 (10:53 +0100)]
More robust, cleaned up MessageTest
This is a direct follow up to my comments in Ia6ec10d.
Relevant for T146416 are the two messages I added. They explain why these
assertions are duplicated.
assertEquals behaves bogus when used with strings, especially when used
with formatters and parsers, which is the case here. For example,
assertEquals( '9a', 9 ) succeeds. assertEquals is useful when comparing
objects.
Bug: T146416
Change-Id: Ie8df41b3ce6678f3add55bab6701b56b66447a2e
jenkins-bot [Thu, 10 Nov 2016 23:57:14 +0000 (23:57 +0000)]
Merge "resourceloader: Use cached Revision::newKnownCurrent for WikiModule"
jenkins-bot [Thu, 10 Nov 2016 23:27:40 +0000 (23:27 +0000)]
Merge "tests: stop updating the search engine"
Translation updater bot [Thu, 10 Nov 2016 21:08:22 +0000 (22:08 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ide14b88775d42539f39da5854090541c599c2213
jenkins-bot [Thu, 10 Nov 2016 21:02:03 +0000 (21:02 +0000)]
Merge "API: Pretty-printed responses should always use HTTP status 200"
jenkins-bot [Thu, 10 Nov 2016 20:56:12 +0000 (20:56 +0000)]
Merge "Depedency inject remappedTableName() map via MWLBFactory"
jenkins-bot [Thu, 10 Nov 2016 20:50:15 +0000 (20:50 +0000)]
Merge "Validate getExamplesMessages() query strings"
jenkins-bot [Thu, 10 Nov 2016 20:46:42 +0000 (20:46 +0000)]
Merge "Fix ApiSandbox"
jenkins-bot [Thu, 10 Nov 2016 19:37:22 +0000 (19:37 +0000)]
Merge "CryptRand: remove newlines from logging message"
jenkins-bot [Thu, 10 Nov 2016 18:57:41 +0000 (18:57 +0000)]
Merge "Convert CREDITS to list of all known git contributors"
jenkins-bot [Thu, 10 Nov 2016 18:57:36 +0000 (18:57 +0000)]
Merge "Convert CREDITS to single list of contributors"
jenkins-bot [Thu, 10 Nov 2016 18:47:45 +0000 (18:47 +0000)]
Merge "Deprecate Message::$format (mostly)"
jenkins-bot [Thu, 10 Nov 2016 18:45:12 +0000 (18:45 +0000)]
Merge "Add Message test for implicit formatting"
Brad Jorsch [Thu, 10 Nov 2016 17:18:19 +0000 (12:18 -0500)]
Fix ApiSandbox
I2b8ef74e broke it by removing the isValid() method from
TextInputWidget.
Bug: T150454
Change-Id: Iae48c6e038ce66d294a1bf5f6852e29540ac208c
Brad Jorsch [Tue, 8 Nov 2016 21:29:04 +0000 (16:29 -0500)]
Validate getExamplesMessages() query strings
Assert that they don't begin with 'api.php?'.
Change-Id: Idf5e8e08863a379a37a427a11936e5f9ce567396
Depends-On: I8a82eecefbb0ba327d8e8bc24ec535bcf40e6429
Depends-On: I476aad09655a2822381a2c61690b4b0ad423151e
Antoine Musso [Thu, 10 Nov 2016 14:33:23 +0000 (15:33 +0100)]
CryptRand: remove newlines from logging message
5bd6de6 converted CryptRand to use the logger command but kept the
newlines in the message which is needed for wfDebug() but not with the
logger interface.
Patch also removed a call to wfGetAllCallers() from the first debug
message of generate(), leaving an uneeded debugging message.
Hence we had output such as:
---
[CryptRand] Generating cryptographic random bytes for
[CryptRand] mcrypt_create_iv generated 20 bytes of randomness.
[CryptRand] 0 bytes of randomness leftover in the buffer.
---
Drop the newlines from all debug message.
Drop the lonely debug message from generate().
Result:
---
[CryptRand] mcrypt_create_iv generated 20 bytes of randomness.
[CryptRand] 0 bytes of randomness leftover in the buffer.
---
Change-Id: I572206296fc3a0a498febb18925672a67480eb18
jenkins-bot [Thu, 10 Nov 2016 14:13:17 +0000 (14:13 +0000)]
Merge "TransformationalImageHandler: Fix use of __METHOD__ in closure"
Bartosz Dziewoński [Thu, 10 Nov 2016 13:18:48 +0000 (14:18 +0100)]
TransformationalImageHandler: Fix use of __METHOD__ in closure
Change-Id: Idff6303fac1f494ea59b88fd73245c63f2cf4a76
WMDE-Fisch [Thu, 10 Nov 2016 10:16:00 +0000 (11:16 +0100)]
Do not pass parameter as reference
See comment in https://gerrit.wikimedia.org/r/#/c/318292/7/includes/EditPage.php
Change-Id: I98df04f5445dcc87a96cde157df13786414b8c3a
jenkins-bot [Thu, 10 Nov 2016 09:47:56 +0000 (09:47 +0000)]
Merge "Fix parameter name"
WMDE-Fisch [Thu, 10 Nov 2016 09:31:43 +0000 (10:31 +0100)]
Fix parameter name
See comment in https://gerrit.wikimedia.org/r/#/c/318535/5/includes/EditPage.php
Change-Id: I4c3da3872997c20a756405099110c8acc37fa188
jenkins-bot [Thu, 10 Nov 2016 09:08:49 +0000 (09:08 +0000)]
Merge "un -> in"
Gergő Tisza [Wed, 9 Nov 2016 00:42:49 +0000 (00:42 +0000)]
Deprecate Message::$format (mostly)
Message::__toString() used the same formatting mode that the last
explicit transformation used:
$msg = new Message( 'foo' );
echo $msg; // escaped
echo $msg->plain();
echo $msg; // not escaped
This is not particularly useful and makes code review hard, so let's
get rid of it.
The same behavior with $msg->toString() is left intact (and logged)
for now.
Bug: T146416
Change-Id: Ia9b2a1dcf09d52348b2c6d8299fd849b809f6e74
jenkins-bot [Thu, 10 Nov 2016 06:00:17 +0000 (06:00 +0000)]
Merge "Revert "Don't construct SpecialPages twice""
Legoktm [Thu, 10 Nov 2016 05:48:33 +0000 (05:48 +0000)]
Revert "Don't construct SpecialPages twice"
This causes issues with transcluded special pages.
This reverts commit
ba40a63c0ee23daec4886a3e7da62b061639f19c.
Bug: T132545
Change-Id: I14d5300d6b90766532924f9d1e52c4230e2d9772
Aaron Schulz [Thu, 10 Nov 2016 05:35:57 +0000 (21:35 -0800)]
Depedency inject remappedTableName() map via MWLBFactory
Change-Id: I71d3481fc624f665bac81725026647bbb84ae608
Reedy [Wed, 9 Nov 2016 23:22:56 +0000 (23:22 +0000)]
un -> in
Change-Id: If8aecd28bcf7d6bf7c44141f83ac3c47ee4419e4
jenkins-bot [Wed, 9 Nov 2016 23:22:25 +0000 (23:22 +0000)]
Merge "Document removal of Database::getSearchEngine()"
Kunal Mehta [Wed, 9 Nov 2016 21:19:44 +0000 (13:19 -0800)]
Document removal of Database::getSearchEngine()
Bug: T147683
Change-Id: I55dcad7932e77e30f9211421489ec801810223be
jenkins-bot [Wed, 9 Nov 2016 21:40:46 +0000 (21:40 +0000)]
Merge "Alphasort lists"