Florianschmidtwelzow [Fri, 3 Oct 2014 19:19:52 +0000 (21:19 +0200)]
Fix missing mw-ui-button on Login and create page
Don't use modifiers for pages, which uses MW UI nativeley, modifiers
will only be used, when wgUseMediaWikiUIEverywhere is set to true. This
runs into inconsistent use of MWUI on one page.
Follow up: I61bb3c358f755ed9f2153d94b744c1a9da02c456
Bug: 71618
Change-Id: I99d5803818e4c2719f92cab0d9036a1cbc3943ca
jenkins-bot [Fri, 3 Oct 2014 18:33:31 +0000 (18:33 +0000)]
Merge "Fix Status serialization with cleanupCallback as Closure"
jenkins-bot [Fri, 3 Oct 2014 18:19:58 +0000 (18:19 +0000)]
Merge "API: Log usage of action=tokens"
jenkins-bot [Fri, 3 Oct 2014 18:08:27 +0000 (18:08 +0000)]
Merge "Turn a wfDebug call in MessageCache::get into a wfDebugLog call"
Brad Jorsch [Fri, 3 Oct 2014 18:06:43 +0000 (14:06 -0400)]
API: Log usage of action=tokens
Change-Id: I5fb7d4e3c7924e61747b652a5cbc3ce0a7ccef01
jenkins-bot [Fri, 3 Oct 2014 18:05:43 +0000 (18:05 +0000)]
Merge "mediawiki.toolbar: Properly deprecate #init"
jenkins-bot [Fri, 3 Oct 2014 18:05:18 +0000 (18:05 +0000)]
Merge "mediawiki.toolbar: Move documentation closer to code"
jenkins-bot [Fri, 3 Oct 2014 17:55:11 +0000 (17:55 +0000)]
Merge "Removed $wgAntiLockFlags to unify the code paths"
jenkins-bot [Fri, 3 Oct 2014 17:45:15 +0000 (17:45 +0000)]
Merge "Avoid attempting to prerender thumbnails that will fail"
Aaron Schulz [Wed, 1 Oct 2014 17:23:00 +0000 (10:23 -0700)]
Removed $wgAntiLockFlags to unify the code paths
Change-Id: Ia709ccdc9addc55c99cbff21a5ff3009b5fbb53c
jenkins-bot [Fri, 3 Oct 2014 17:41:17 +0000 (17:41 +0000)]
Merge "Special:ExpandTemplates: Use MediaWiki UI"
jenkins-bot [Fri, 3 Oct 2014 17:41:10 +0000 (17:41 +0000)]
Merge "Avoid the page join when not really needed"
Florianschmidtwelzow [Fri, 3 Oct 2014 11:49:50 +0000 (13:49 +0200)]
Special:ExpandTemplates: Use MediaWiki UI
Bug: 71433
Change-Id: Ibe965741734bb911813084dad132ece179cc0362
Gilles Dubuc [Fri, 3 Oct 2014 16:09:07 +0000 (18:09 +0200)]
Avoid attempting to prerender thumbnails that will fail
For non-vectorial content, requesting a thumbnail larger than
the original results in a 500. Prerendering in its current form
introduces an increase in 500s that dilutes the real problematic
500s, making troubleshooting harder than it needs to be.
Change-Id: I9418dee7653ad7954c3788ecdd350fc8772edd32
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/301
Brad Jorsch [Fri, 3 Oct 2014 15:57:31 +0000 (11:57 -0400)]
Fix Status serialization with cleanupCallback as Closure
We already have Status objects throw away the cleanupCallback in
__wakeup. Why not also implement __sleep to not save it in the first
place?
The immediate motivation here is that cleanupCallback could be a
Closure, which causes an exception when serialization is attempted (e.g.
when trying to save the Status if an AssembleUploadChunks job fails
verification).
Note this leaves __wakeup intact, in case of old objects where
cleanupCallback is still present in the serialized representation.
Change-Id: I3aa756cd4eb5553ce0b95e7088b929b2f529abfe
jenkins-bot [Fri, 3 Oct 2014 15:41:11 +0000 (15:41 +0000)]
Merge "Made upload jobs avoid using the user session"
jenkins-bot [Fri, 3 Oct 2014 11:56:22 +0000 (11:56 +0000)]
Merge "mediawiki.util: Insert node before updating tooltip for accesskey"
jenkins-bot [Fri, 3 Oct 2014 11:55:06 +0000 (11:55 +0000)]
Merge "mediawiki.util: Clean up nextnode logic"
Bartosz Dziewoński [Sun, 21 Sep 2014 13:26:07 +0000 (15:26 +0200)]
mediawiki.toolbar: Properly deprecate #init
Change-Id: I0271258e5f33b21c68b6224ca74123a3723c9788
Bartosz Dziewoński [Sun, 21 Sep 2014 13:24:29 +0000 (15:24 +0200)]
mediawiki.toolbar: Move documentation closer to code
Also tweaked whitespace and variable naming (b → button).
Change-Id: I52653a7756b3661f4f32985763af03232c873da4
jenkins-bot [Fri, 3 Oct 2014 11:39:10 +0000 (11:39 +0000)]
Merge "Split mediawiki.toolbar from mediawiki.action.edit"
Alexandre Emsenhuber [Mon, 1 Sep 2014 20:26:36 +0000 (22:26 +0200)]
Replace $wgConf->localVHosts by $wgLocalVirtualHosts
The former is independent of the remaining of the SiteConfiguration
class, and as thus makes more sense to be defined as an explicit
configuration setting rather that being hidden in $wgConf.
Change-Id: I25204d37c5cfffb6953fe53e14316dc3df5b5b10
Ori Livneh [Fri, 3 Oct 2014 03:52:05 +0000 (20:52 -0700)]
Turn a wfDebug call in MessageCache::get into a wfDebugLog call
It's a very hot code path, so it makes sense to be able to dive into it in
detail, and having a discrete log bucket makes that easier to do.
Change-Id: I4b547e97711b9e45a99f7b747d785690c70883ec
jenkins-bot [Fri, 3 Oct 2014 00:22:48 +0000 (00:22 +0000)]
Merge "Hygiene: Make construction of buttons easier"
jenkins-bot [Fri, 3 Oct 2014 00:10:37 +0000 (00:10 +0000)]
Merge "Switch custom code to wfParseUrl which covers the same bugfix"
jenkins-bot [Thu, 2 Oct 2014 21:19:38 +0000 (21:19 +0000)]
Merge "Special:MediaStatistics: data-sort-value also for number of files"
jenkins-bot [Thu, 2 Oct 2014 21:18:41 +0000 (21:18 +0000)]
Merge "Added some profiling calls"
jenkins-bot [Thu, 2 Oct 2014 21:12:46 +0000 (21:12 +0000)]
Merge "Removed $wgPageShowWatchingUsers"
jenkins-bot [Thu, 2 Oct 2014 21:12:34 +0000 (21:12 +0000)]
Merge "Improved timestamp precision in ProcessCacheLRU"
jenkins-bot [Thu, 2 Oct 2014 21:12:25 +0000 (21:12 +0000)]
Merge "Bumped the default Swift token expiry a bit"
Translation updater bot [Thu, 2 Oct 2014 21:04:31 +0000 (23:04 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I34e47c0855ee32b67031e1bcbc88f1bab20cdc92
Timo Tijhof [Sun, 21 Sep 2014 03:06:58 +0000 (20:06 -0700)]
Split mediawiki.toolbar from mediawiki.action.edit
Follows-up
285c52039bf4d2f9b.
Get rid of mediawiki.mediawiki.action.toolbar. Not keeping a
backwards-compat alias since this module is not supposed to be used
publicly in its current form.
Change-Id: I403216c6916e1f4d29216a55c3fe6c92eb68400b
jenkins-bot [Thu, 2 Oct 2014 20:27:51 +0000 (20:27 +0000)]
Merge "Don't rely on $wgTitle in WebRequest"
umherirrender [Thu, 2 Oct 2014 20:20:55 +0000 (22:20 +0200)]
Special:MediaStatistics: data-sort-value also for number of files
The column "Number of files" is sortable, but does not contains plain
numbers, so it needs a data-sort-value to allow js to sort correct.
Change-Id: I9b7232b755dc8dab2cf04682103085273dada737
Aaron Schulz [Thu, 2 Oct 2014 17:22:27 +0000 (10:22 -0700)]
Avoid the page join when not really needed
* That sometimes triggered a filesorts when the title for the
inequality has certain (seemingly long) values.
* Also made the continuation queries use > instead of >=.
Change-Id: I912df77ad43f025918e52d1494300d487a9deea1
Gilles Dubuc [Thu, 2 Oct 2014 15:26:37 +0000 (17:26 +0200)]
Switch custom code to wfParseUrl which covers the same bugfix
Change-Id: I60b20bd7e8f4b25acd5ef2de172786a152c0e589
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/301
jenkins-bot [Thu, 2 Oct 2014 08:39:45 +0000 (08:39 +0000)]
Merge "Set content language for ContentHandlerTest::testGetAutosummary"
jenkins-bot [Thu, 2 Oct 2014 07:02:44 +0000 (07:02 +0000)]
Merge "Make submit of Special:NewFiles progressive"
jenkins-bot [Thu, 2 Oct 2014 06:00:50 +0000 (06:00 +0000)]
Merge "Fix styling of deletion page when $wgUseMediaWikiUIEverywhere enabled"
Matthew Flaschen [Thu, 2 Oct 2014 05:06:46 +0000 (01:06 -0400)]
Make submit of Special:NewFiles progressive
Bug: 71445
Change-Id: Iba2a8e7f37c2c1af3a018740d5a9b48edc84e238
jenkins-bot [Thu, 2 Oct 2014 04:24:18 +0000 (04:24 +0000)]
Merge "Change mw-ui anchors to require mw-ui-anchor base class, and introduce mw-ui-text base class"
Shahyar [Fri, 22 Aug 2014 23:50:43 +0000 (16:50 -0700)]
Change mw-ui anchors to require mw-ui-anchor base class, and introduce mw-ui-text base class
Introduced mw-ui-text base class for plain-text, non-interactable elements which require context colors (eg. icons)
Also added mw-ui-anchor for interactable elements (such as anchors)
Note: This is not supported by IE6 at current time.
Bug: 69212
Bug: 70801
Change-Id: I4d017d0a22cb4f3ca52b6228e45c0463c110ae64
jenkins-bot [Thu, 2 Oct 2014 01:04:41 +0000 (01:04 +0000)]
Merge "API: Fix ApiQueryBacklinks logic and use *_from_namespace"
Fomafix [Sun, 13 Jul 2014 14:59:10 +0000 (14:59 +0000)]
mediawiki.util: Insert node before updating tooltip for accesskey
updateTooltipAccessKeys() uses the native accessKeyLabel property which,
in Firefox, isn't available until after the node is inserted into the
document.
Bug: 67946
Change-Id: I3b80174e2f5df1c9082d30607dbe9b63ede6b5b5
Timo Tijhof [Wed, 1 Oct 2014 23:12:55 +0000 (16:12 -0700)]
mediawiki.util: Clean up nextnode logic
Change-Id: I21469a765002897f03caca97628ad36264d49c83
Aaron Schulz [Mon, 29 Sep 2014 23:53:26 +0000 (16:53 -0700)]
Loosened the CLI restriction in RequestContext::importScopedSession()
* Jobs can be run via HTTP runners rather than just CLI ones.
The old check breaks jobs run on HHVM fcgi runners for example.
* Always check the validity of the IP for sanity.
Change-Id: I1d03c2ab6628b2d124bc7b9f6936788dea22e3e4
jenkins-bot [Wed, 1 Oct 2014 21:55:30 +0000 (21:55 +0000)]
Merge "Fix SpecialPageFactory list handling"
jenkins-bot [Wed, 1 Oct 2014 21:41:04 +0000 (21:41 +0000)]
Merge "Remove $wgGoToEdit functionality"
jenkins-bot [Wed, 1 Oct 2014 21:40:57 +0000 (21:40 +0000)]
Merge "Avoid stupid mariadb filesort in findMissingFiles.php"
jenkins-bot [Wed, 1 Oct 2014 21:24:49 +0000 (21:24 +0000)]
Merge "Workaround for thumbnail pre rendering with PHP < 5.4.7"
Aaron Schulz [Wed, 1 Oct 2014 21:21:26 +0000 (14:21 -0700)]
Avoid stupid mariadb filesort in findMissingFiles.php
Change-Id: I6267cfaf375fcc0eea8291fd7a2a0f7daa05a941
Gilles Dubuc [Wed, 1 Oct 2014 20:55:23 +0000 (22:55 +0200)]
Workaround for thumbnail pre rendering with PHP < 5.4.7
Since this code is dealing with scheme-less URLs, parse_url()
can cause issues in older versions of PHP.
Change-Id: Ic1276feed9ed51772a05c4a73c787a315b848066
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/301
Timo Tijhof [Thu, 11 Sep 2014 23:14:16 +0000 (18:14 -0500)]
SECURITY: OutputPage: Remove separation of css and js module allowance
* No longer segment module origin allowance by an "only=" content
type. Both can be sensitive security-wise and there's no valid
use case for allowing CSS anywhere you want to disallow JS. Both
can significantly impact the user interface and cause unintended
actions to be taken on the user's behalf, or desired actions to
be made practically impossible.
* While at it, also remove the ability to set the module allowance
directly. The reduceAllowedModuleOrigin method is all we need.
I couldn't find usage or mention of setAllowedModules() in
mediawiki-core nor in any other Wikimedia-hosted repository.
Bug: 70672
Change-Id: I308e794daca27a9380c67be350f8ab51f9c2de34
Brad Jorsch [Thu, 21 Aug 2014 17:39:27 +0000 (13:39 -0400)]
API: Fix ApiQueryBacklinks logic and use *_from_namespace
The original intent of this patch was to have ApiQueryBacklinks use the
*_from_namespace fields added in Icca99b6a. It does that, but in the
process several other bugs were found in the module:
* Continuation could skip pages when blredirect was used.
* The result object would be populated incorrectly if
$wgAPIMaxResultSize was hit and blredirect was used.
* Continuation could (probably) skip or (maybe) repeat pages when
blredirect was used and $wgAPIMaxResultSize was hit.
In the process of analyzing and fixing these problems, the code was
heavily refactored.
Change-Id: I32381c0f082d2f8e063af99ee353ae003c163c23
Translation updater bot [Wed, 1 Oct 2014 19:47:44 +0000 (21:47 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Id353e6c005c2cd58d7b1aa18dbd5638d8221cf1b
umherirrender [Sat, 27 Sep 2014 09:53:02 +0000 (11:53 +0200)]
Set content language for ContentHandlerTest::testGetAutosummary
This test depends on content language when comparing to a english
message text.
Change-Id: Ic50c0b6a821fb1d51d70119fbf712a18b73ce4c8
Kevin Israel [Tue, 24 Jun 2014 07:14:24 +0000 (03:14 -0400)]
Special:BookSources: Correct validation of ISBNs containing X
PHP's "equal" (==) operator considers the integer 0 to be equal to
the string 'X', and when 'X' is converted to a number, it becomes 0.
Neither is desired here.
* Fail when an X is encountered while calculating the check digit.
(X can only occur as the check digit of an ISBN-10.)
* Fixed the check digit comparisons by adding an explicit string cast.
* Used the "identical" operator to make it more obvious that no type
juggling should take place during the comparisons.
* Added some test cases.
* Removed an outdated TODO.
Bug: 67021
Change-Id: I85f53c41f403a60340e9441757fe66b9764e623c
This, that and the other [Sun, 27 Jul 2014 11:02:59 +0000 (21:02 +1000)]
Preserve log comment text field value across import attempts
This was first attempted way back in r45340, but was reverted in r45489.
Bug: 16793
Change-Id: Ieb9fb7e7e918b2e7e2b8289b3fdf82a49ea75a17
Brad Jorsch [Wed, 1 Oct 2014 03:20:04 +0000 (23:20 -0400)]
Fix SpecialPageFactory list handling
* Since Ic917c7d8/I7420b9ec, SpecialPageFactory doesn't properly cache
SpecialPageFactory::$list.
* SpecialPageFactory::resetList() has never really worked right, it
loses all the core special pages.
* SpecialPageFactory::getAliasListObject() could be called recursively
from a SpecialPage_initList hook. There's no particular reason to fail
it, just allow the original call to override the result of the
recursive one and hope it works.
Change-Id: I7adb346eab00d5849d087ddff75230a35be3ee8f
Aaron Schulz [Wed, 1 Oct 2014 17:14:27 +0000 (10:14 -0700)]
Added some profiling calls
Change-Id: Icb024c86e86a030fdea874cf5aa47fd0329e6133
Aaron Schulz [Wed, 1 Oct 2014 17:10:07 +0000 (10:10 -0700)]
Removed $wgPageShowWatchingUsers
Change-Id: I1e3d17f1954c7b4427a22cd9a781012061d3e710
jenkins-bot [Wed, 1 Oct 2014 17:04:16 +0000 (17:04 +0000)]
Merge "Use ems instead of pixels for checkbox"
jenkins-bot [Wed, 1 Oct 2014 16:59:50 +0000 (16:59 +0000)]
Merge "Clarify documentation for icons"
jenkins-bot [Wed, 1 Oct 2014 16:50:02 +0000 (16:50 +0000)]
Merge "Fix input regression affecting HTMLForms that use VForm"
Florianschmidtwelzow [Wed, 1 Oct 2014 15:51:40 +0000 (17:51 +0200)]
Use ems instead of pixels for checkbox
Mixing pixels and ems results in a negative height, which is invalid.
Use ems instead of pixels for @focusBottomBorderSize.
Follow up: Ia6adc4bda000508f14acf4214e778118efa35be0
Bug: 71506
Change-Id: Ia619916a172a501365e0104e9927c7fae9de8a3f
jenkins-bot [Wed, 1 Oct 2014 13:33:10 +0000 (13:33 +0000)]
Merge "User rights API: Abstract out some stuff about core's form into separate methods"
Alex Monk [Wed, 1 Oct 2014 12:06:10 +0000 (13:06 +0100)]
User rights API: Abstract out some stuff about core's form into separate methods
To we can make a CentralAuth API module for global user rights.
Bug: 71495
Change-Id: I139c43e5eaa1fb63b75baddbafb7caa3c964d6b5
jenkins-bot [Wed, 1 Oct 2014 07:32:00 +0000 (07:32 +0000)]
Merge "mediawiki.jqueryMsg: Support arbitrary expressions in plural forms"
jenkins-bot [Wed, 1 Oct 2014 07:26:42 +0000 (07:26 +0000)]
Merge "Use skinStyles for mediawiki.ui.icon"
Matthew Flaschen [Wed, 1 Oct 2014 06:15:02 +0000 (02:15 -0400)]
Fix input regression affecting HTMLForms that use VForm
Although the classes (e.g. mw-ui-input) are still there,
the style module was not being loaded.
This affects forms that deliberately use VForm even without
wgUseMediaWikiUIEverywhere (since they pre-date it).
This applies at least to PasswordReset, which was added in
d32891d99f185e5cf2b0e25bf947de221d4c3295 (last October).
Bug: 71448
Change-Id: Ieca36c0036d4c93244c533237eddd678564dd3c0
Matthew Flaschen [Wed, 1 Oct 2014 06:03:08 +0000 (02:03 -0400)]
Use skinStyles for mediawiki.ui.icon
This allows skin customization. This was missed since it was under
code review when the others went in.
Change-Id: I2c640fda4d2c6e40be0add52f6fc948a8e07c010
Matthew Flaschen [Tue, 30 Sep 2014 04:32:48 +0000 (00:32 -0400)]
Clarify documentation for icons
Change-Id: I3452366505bde7a75a6a922138daa6a19a235d20
Santhosh Thottingal [Sun, 28 Sep 2014 09:01:46 +0000 (14:31 +0530)]
mediawiki.jqueryMsg: Support arbitrary expressions in plural forms
In I15c167f245 mw.jqueryMsg.htmlEmitter#plural was modified to
convert the plural params to flat html. This caused extlink params
as plural forms expanded as text node and escaped.
This patch improves the plural support by:
* Allowing valid parser expressions as plural form parameters. They wont
be converted to html, parsed nodes will be preserved in plural
calculation
* For explicit plural forms like n=expression, the expression can be any
valid parser expression. They also will not be coverted to html,
nodes will be preserved
* Move the splitting by equal sign logic for explicit plural forms to
jqueryMsg, avoiding mediawiki.language#convertPlural to do
parsing logc. Explicit plural forms, if any, are passed as a parameter
to mediawiki.language#convertPlural
Includes test cases for all combinations of the above cases.
mediawiki.jqueryMsg.peg can be improved to support digit=expression as an
additional form for templateParam to better handle this. But it looks
it can potentially disturb other parser functions. Not attempted.
Bug: 70617
Change-Id: I3c3cbb6d3676903941c40b658032b4c543556e06
James D. Forrester [Tue, 30 Sep 2014 23:08:11 +0000 (16:08 -0700)]
Update OOjs UI to v0.1.0-pre (
30b0407428)
New changes:
3386c39 Make this.$.$iframe actually point to an iframe again
bb7bbf5 ClippableElement: Use 'overflow-[xy]: scroll' rather than 'auto'
71176eb TextInputWidget: Don't mix inner and outer heights in calculations
f1dd60e TextInputWidget: Work around Blink height miscalculation
954a369 WindowManager: Emit 'resize' event when a window is resized
3232d6f Try to stop user from tabbing outside of open dialog box
6c4baa3 Tool: Use FlaggedElement mixin to let tools be flagged
Change-Id: Ia0a0b45e5f210314592733114a05583973b011d6
jenkins-bot [Tue, 30 Sep 2014 22:38:47 +0000 (22:38 +0000)]
Merge "Skip MailAddressTest::testNewFromUser on windows"
jenkins-bot [Tue, 30 Sep 2014 22:01:45 +0000 (22:01 +0000)]
Merge "CSSMin: Don't generate double rules for IE < 8 when embedding SVG files"
jdlrobson [Mon, 29 Sep 2014 23:45:45 +0000 (16:45 -0700)]
Hygiene: Make construction of buttons easier
Stop littering MediaWiki with globals, provide a common
api for generating them similar to how we do text input
attributes before things get out of control.
Adds
* submitButton
* linkButton
Change-Id: I61bb3c358f755ed9f2153d94b744c1a9da02c456
jenkins-bot [Tue, 30 Sep 2014 21:49:27 +0000 (21:49 +0000)]
Merge "CSSMin: Do not base64-encode non-binary files when embedding"
jenkins-bot [Tue, 30 Sep 2014 21:42:10 +0000 (21:42 +0000)]
Merge "Update OOjs UI to v0.1.0-pre (
afa3241e8e)"
Roan Kattouw [Mon, 29 Sep 2014 23:17:34 +0000 (16:17 -0700)]
Update OOjs UI to v0.1.0-pre (
afa3241e8e)
New changes:
8daef61 TextInputWidget: Add setValidation function to change pattern used to validate text
953c46c [BREAKING CHANGE] Create a MediaWiki theme
e2a3bae PopupWidget: Position body/anchor using 'margin-left' instead of 'left'
4f50c34 Correct the left positioning of a popup wrapper
afa3241 Move references to pending.gif to the themes that provide it
Update changes:
* Update links to OOjs UI distribution files
Change-Id: Ic59650b56de44807348db4df46c538756ed9329e
Bartosz Dziewoński [Mon, 22 Sep 2014 12:21:47 +0000 (14:21 +0200)]
CSSMin: Don't generate double rules for IE < 8 when embedding SVG files
Bug: 71003
Change-Id: Ic232e8d62b164940003afdfe7cce9f964d7e9cbc
Bartosz Dziewoński [Wed, 17 Sep 2014 21:14:46 +0000 (23:14 +0200)]
CSSMin: Do not base64-encode non-binary files when embedding
Do not base64-encode non-binary files (containing only whitespace and
printable ASCII characters, which matches sane SVG files).
For SVG files the percent-encoded URIs are actually slightly longer
than the base64-encoded ones (~10%), but compress a lot better
resulting on 15-20% less data to transfer after gzip compression.
(The effect is best seen on the 'oojs-ui' module, which consists
mostly of SVG icons – especially after commenting out everything other
than 'oojs-ui.svg.css'.)
I tried this for binary files too, just in case; but as expected, they
suffer from a noticeable size increase even with compression (~15%).
Bug: 67341
Change-Id: Iddaf863b6be98570a2bb8e606f13946a96345f65
umherirrender [Sat, 27 Sep 2014 10:05:29 +0000 (12:05 +0200)]
Fix GitInfoTest::testValidJsonData on windows
GitInfo.php is replacing DIRECTORY_SEPARATOR by '-'.
On windows this is \, which was not set in the tests.
1) GitInfoTest::testValidJsonData
Failed asserting that false is true.
Change-Id: I1871c342b61a335b59a98755d8b824cc58c1543e
Translation updater bot [Tue, 30 Sep 2014 20:33:31 +0000 (22:33 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I8d868812d775114923187d2db27201080017d452
jenkins-bot [Tue, 30 Sep 2014 20:05:52 +0000 (20:05 +0000)]
Merge "Introduce Message::plaintextParam"
Erik Bernhardson [Wed, 17 Sep 2014 21:39:15 +0000 (14:39 -0700)]
Introduce Message::plaintextParam
I have run into numerous issues trying to utilize unsafe user
provided content as an argument to a Message instance. Specific
cases are enumerated in MessageTest.php
Typically the solution to using user provided text is to use
Message::rawParam, but this pushes escaping of the parameter to
the caller. This patch introduces Message::plaintextParams which
handles escaping of the string parameter to match the requested
output format.
The functionality is:
* plain and text: exactly like rawParams()
* escaped, parse and parseAsBlock: escape it but don't do brace expansion
Additionaly, similar to Message::rawParam, plaintext parameters are not
valid parser function arguments.
Change-Id: I320645cd23c98fea4bfc32ab22b7ef8d320957cb
Reza [Mon, 29 Sep 2014 22:04:04 +0000 (22:04 +0000)]
Disable "linkPrefixExtension" on Central Kurdish
Disable prefix on Ckb and format it like Fa, it currently links
"«[[Link]]»" to "<a>«Link</a>»" on Ckb but on Fa will "«<a>Link</a>»"
which per a community member is much better and expected
Change-Id: I1d17fc6ea511f13bde4fef7538117c9c2eebc6db
jenkins-bot [Tue, 30 Sep 2014 18:16:32 +0000 (18:16 +0000)]
Merge "Restore ability for getAttributes to set HTMLTextField type"
Brad Jorsch [Tue, 30 Sep 2014 16:06:56 +0000 (12:06 -0400)]
Restore ability for getAttributes to set HTMLTextField type
Change I47db5eab broke SecurePoll, which was relying on this.
Change-Id: Ib11bf9d34eb12f14b9636498c00ff4040b35f130
Gilles Dubuc [Tue, 30 Sep 2014 12:20:11 +0000 (14:20 +0200)]
Fix version comments in thumbnail prerendering code
Change-Id: I74b52d2ecc382dfc0b55615ce512e8c64d02e9cb
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/301
jenkins-bot [Tue, 30 Sep 2014 01:52:37 +0000 (01:52 +0000)]
Merge "Added missing JsonFormat::parse() RELEASE NOTES, fixed docs"
Yuri Astrakhan [Sat, 27 Sep 2014 23:58:11 +0000 (19:58 -0400)]
Added missing JsonFormat::parse() RELEASE NOTES, fixed docs
Constant values were changed to be above 0xFF - this way
we can easily decide to allow depth-parsing-limit to be OR-able:
FormatJson::parse( $value, 30 | FormatJson::FORCE_ASSOC )
Follows-up Ic0eb0a7 and I1c4f37a.
Change-Id: I9bfd67a5ca4ea1d399821549c7e63ffdecd56ad1
Alex Monk [Sat, 1 Feb 2014 20:49:12 +0000 (20:49 +0000)]
Implement autocompletion for Performer field on Special:Log
Bug: 48241
Change-Id: I5e6af5aba56de613f10f862aaf064aaa32b5b176
Aaron Schulz [Mon, 29 Sep 2014 23:20:57 +0000 (16:20 -0700)]
Made upload jobs avoid using the user session
* This causes problems with some session handlers and it is
also trickier to deal with in non CLI script without leaking
cookie headers.
Change-Id: Iaf2a57f9299e42a5f68bf85115e62e88fa0f8ed6
Sergio Santoro [Tue, 5 Aug 2014 13:11:56 +0000 (15:11 +0200)]
Add test cases for wfAppendQuery
Change-Id: I51e0e1764ad70d922466d62f1ddf3f8e3fb4568f
Timo Tijhof [Sun, 21 Sep 2014 00:00:38 +0000 (17:00 -0700)]
Remove deprecated "jquery.json" module
Announced in https://www.mail-archive.com/wikitech-l%40lists.wikimedia.org/msg78108.html
Change-Id: Icc9dec0146cd374787124b7e1ed295c77737d11b
Bartosz Dziewoński [Sat, 28 Jun 2014 11:44:19 +0000 (13:44 +0200)]
mediawiki.api: Remove deprecated function parameters
* 'ok' and 'err' parameters to various functions.
Tracked with mw.track( 'mw.deprecate' ) as 'api.cbParam'.
Deprecated since MW 1.20, printing console warnings since MW 1.23.
* 'async' parameter to mediawiki.api.category #getCategories.
Tracked with mw.track( 'mw.deprecate' ) as 'api.async'.
Deprecated and printing console warnings since MW 1.23.
Also removed is mw.Api#normalizeAjaxOptions, which is no longer needed
and which has never been used by anything outside mediawiki.api module.
Announced in https://www.mail-archive.com/wikitech-l%40lists.wikimedia.org/msg78108.html
Change-Id: I0a650fdb4affd394ae419e21d54baf790116f6f7
Ori Livneh [Mon, 3 Feb 2014 19:20:00 +0000 (20:20 +0100)]
mediawiki.user: Remove deprecated name() and anonymous() methods
Removed mw.user#name and mw.user#anonymous which have been deprecated
in favor of mw.user#getName and mw.user#isAnon since 1.20.
Announced in https://www.mail-archive.com/wikitech-l%40lists.wikimedia.org/msg78108.html
Change-Id: I3be1cfecb79faee5701708136ede133870b9940d
Brad Jorsch [Mon, 29 Sep 2014 18:40:51 +0000 (14:40 -0400)]
PasswordFactory::newFromPlaintext( null ) needs to work
Various code passes null around to mean "an invalid password". It
shouldn't all have to test for null and specially handle that.
This also fixes a codepath where User::$mNewpassword could get set to an
empty string rather than a password object, which would cause problems
later when anything else tries to use it.
Bug: 71421
Change-Id: Ib5f94b52c07e7dba89328b98fb43c86db95ee09f
jenkins-bot [Mon, 29 Sep 2014 21:34:18 +0000 (21:34 +0000)]
Merge "HistoryAction: Use correct classes for buttons"