jenkins-bot [Tue, 24 Jan 2017 01:50:35 +0000 (01:50 +0000)]
Merge "Pass the right username to 'tool-link-userrights' / 'tool-link-userrights-readonly'"
jenkins-bot [Tue, 24 Jan 2017 00:02:40 +0000 (00:02 +0000)]
Merge "mediawiki.api.options: Use sequential API requests in the remaining edge cases"
Bartosz Dziewoński [Mon, 23 Jan 2017 21:46:09 +0000 (22:46 +0100)]
mediawiki.api.options: Use sequential API requests in the remaining edge cases
Bug: T100908
Change-Id: I927c098fd750bd765ffd746d40c3f7408f99f2de
Translation updater bot [Mon, 23 Jan 2017 21:01:44 +0000 (22:01 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ied68f6be3ea1dfec0f05d6e9ca36004ade979fb3
jenkins-bot [Mon, 23 Jan 2017 20:54:09 +0000 (20:54 +0000)]
Merge "Reciprocal fallback between ca (Catalan) and oc (Occitan)"
Federico Leva [Tue, 17 Jan 2017 19:35:02 +0000 (20:35 +0100)]
Reciprocal fallback between ca (Catalan) and oc (Occitan)
The two languages are extremely close, to the point linguists have
considered one a variant of the other till not too long ago. The
two linguistic communities have strong ties according to Donneky,
2011: http://hdl.handle.net/10443/1302 . Speakers should have no
difficulty understanding each other.
A translator has compared a sample of translations in the two
languages and found them to be largely similar and compatible.
Use European date formats; no $namespaceGenderAliases for now in oc.
Discussed at:
https://translatewiki.net/wiki/Thread:Portal_talk:Ca/Joining_forces_with_Occitan
The proposal has been notified on all Catalan Wikimedia projects, see
* https://ca.wikipedia.org/wiki/Tema:Tjc8xr0z769mskl5
* https://ca.wiktionary.org/w/index.php?diff=903923
etc. has met a very positive response.
This change is not incompatible with the oc→fr fallback (I02fc9af984).
Change-Id: Ibbad7a830bc010654db8ad5679d6a0f45357d382
Florian Schmidt [Mon, 23 Jan 2017 19:09:44 +0000 (20:09 +0100)]
Remove useless title parameter in CategoryPager
The title is already added as the action of the form tag,
so adding it again as a hidden input field is pretty useless
and more confusing in the url. Therefore: Removing it.
Change-Id: I146b562357105e337f86a6ccfeb55477262f67cd
Federico Leva [Sun, 15 Jan 2017 23:08:29 +0000 (00:08 +0100)]
Language fallback from sh (Serbo-Croatian) to bs, sr-el, hr
Bosnian, Serbian and Croatian are closely related languages and have
respectively about 2700, 1400 and 1200 translations identical to that
of Serbo-Croatian, which has about 5400 in total. This demonstrates
that we can profitably reuse some translators' work to reduce the
usage of English in Serbo-Croatian despite the low level of translation
and that there is a logical order in the fallback sequence.
The information has been collected and discussed with translators at
https://translatewiki.net/wiki/Thread:Portal_talk:Sh/Language_fallback
and Wikipedia editors have been notified of the discussion with
https://sh.wikipedia.org/w/index.php?diff=
40677113&oldid=
40676567
and messages in the talk page of each individual editor.
Inherit linktrail and digit separators, but not $defaultDateFormat,
$datePreferences, $datePreferenceMigrationMap or
$namespaceGenderAliases to reduce the impact and variance.
Change-Id: I04310ee32370ae20c00ea970b3163dcb8f167eba
Florian Schmidt [Mon, 23 Jan 2017 19:06:57 +0000 (20:06 +0100)]
Fix mode of CategoryPager.php to 644
Follow up: I4811771210384a32407b7378c7428361e46da33e
Change-Id: I0c87e04ca82f9b3f18f276cb41adbe6890cb870a
jenkins-bot [Mon, 23 Jan 2017 18:11:43 +0000 (18:11 +0000)]
Merge "PHAN: conditionally load stubs"
jenkins-bot [Mon, 23 Jan 2017 17:47:28 +0000 (17:47 +0000)]
Merge "Soft deprecated EditPage::submit to avoid new use"
addshore [Mon, 23 Jan 2017 17:12:08 +0000 (18:12 +0100)]
Soft deprecated EditPage::submit to avoid new use
Currently this has no usages.
::edit can be called directly
Change-Id: I892e3de61c0513dc186d0f35e05107ed7136447d
Bartosz Dziewoński [Mon, 23 Jan 2017 16:32:23 +0000 (17:32 +0100)]
Pass the right username to 'tool-link-userrights' / 'tool-link-userrights-readonly'
Change-Id: Iba2e41942352b834acb4ecd0781313ae522c25c4
addshore [Fri, 20 Jan 2017 17:35:03 +0000 (17:35 +0000)]
PHAN: conditionally load stubs
Change-Id: I6f78c573468a393d82927d614df5bceda86a9e9c
jenkins-bot [Sun, 22 Jan 2017 20:59:33 +0000 (20:59 +0000)]
Merge "Standardize html form by using OOUI in Special:Categories"
Translation updater bot [Sun, 22 Jan 2017 20:59:21 +0000 (21:59 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: If2cf309a446a47958a10a6fc6d16498e1b52eb80
jenkins-bot [Sun, 22 Jan 2017 18:38:45 +0000 (18:38 +0000)]
Merge "Revert "ApiSandbox: Display params as JSON on request page""
Amir Sarabadani [Sun, 22 Jan 2017 03:44:53 +0000 (07:14 +0330)]
Standardize html form by using OOUI in Special:Categories
Bug: T117728
Change-Id: I4811771210384a32407b7378c7428361e46da33e
jenkins-bot [Sun, 22 Jan 2017 07:58:54 +0000 (07:58 +0000)]
Merge "mw.notification: Re-implement autoHideSeconds as string preset option"
Timo Tijhof [Fri, 20 Jan 2017 03:25:59 +0000 (03:25 +0000)]
mw.notification: Re-implement autoHideSeconds as string preset option
Instead of allowing freeform number values, make it a preset-based
string where pre-defined values are encouraged.
A numerical override is still possible by creating a new preset,
but this undocumented/private for now.
Follows-up
4b9992a0, which added this option. No usage found
as of yet in Wikimedia Git, thus no deprecation/back-compat.
Also:
* Unbreaks `#autoHideSeconds` reference in #autoHideLimit doc.
* Improve wording of #autoHideLimit doc.
Bug: T155228
Change-Id: Id84d8b616fe26b9976263f4bd6bdc70cc8a539ba
This, that and the other [Tue, 27 Dec 2016 09:51:50 +0000 (20:51 +1100)]
Parser: Trim leading whitespace from links before checking for leading :
The leading spaces on the link only cause us problems, such as for the
$noforce check 20 lines later.
Bug: T129218
Change-Id: I93a8da1f73b38fa3da362f8f27479b3039ed3f13
Translation updater bot [Sat, 21 Jan 2017 20:54:02 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I846c7cf640fe159540ba25c6abfdce30b9dc5351
jenkins-bot [Sat, 21 Jan 2017 19:47:27 +0000 (19:47 +0000)]
Merge "Revert "Added reason suggestion in block/delete/protect forms""
jenkins-bot [Sat, 21 Jan 2017 19:44:34 +0000 (19:44 +0000)]
Merge "SpecialMIMEsearch: Add a dropdown with input suggestions"
jenkins-bot [Sat, 21 Jan 2017 19:33:09 +0000 (19:33 +0000)]
Merge "Replaced all deprecated Linker methods with proper ones in core(1)"
Florianschmidtwelzow [Sat, 21 Jan 2017 18:54:21 +0000 (18:54 +0000)]
Revert "Added reason suggestion in block/delete/protect forms"
See the task, this was probably entirely my fault not having
looked at this more carefully. Technically the change is ok,
however, it seems to doesn't make much sense in combination
with the Reason dropdown box.
This reverts commit
faab2411c29a2ad0851c596f1cadfec1d7e06892.
Task: T34950
Change-Id: I1eeb9c68ff0db20d29e7d5f0fb18f0bfa3224416
jenkins-bot [Sat, 21 Jan 2017 18:54:54 +0000 (18:54 +0000)]
Merge "BlockLogFormatter: Durations are relative to block's timestamp, not Unix epoch"
TTO [Sat, 21 Jan 2017 03:57:03 +0000 (03:57 +0000)]
Fix typo in README
Change-Id: If32667e5e41d924f14ad803c470a21cd54f3f17b
jenkins-bot [Sat, 21 Jan 2017 03:35:19 +0000 (03:35 +0000)]
Merge "ApiErrorFormatter_BackCompat: Use first error, not last"
jenkins-bot [Sat, 21 Jan 2017 01:19:06 +0000 (01:19 +0000)]
Merge "Remove unused fields in SpecialUnusedimages query"
jenkins-bot [Fri, 20 Jan 2017 20:53:03 +0000 (20:53 +0000)]
Merge "Special:Upload should not crash on failing previews"
Derk-Jan Hartman [Thu, 19 Jan 2017 19:49:55 +0000 (11:49 -0800)]
Special:Upload should not crash on failing previews
A thumbnail transformation can fail, but the preview on Special:Upload
was not accounting for failed previews and caused a stacktrace on
accessing getUrl on 'false'.
Bug: T155771
Change-Id: Iff3a2ae3512a34a2d2efb981b7ea85da71aaf637
jenkins-bot [Fri, 20 Jan 2017 20:13:01 +0000 (20:13 +0000)]
Merge "Added release notes for 'ContentHandler::runLegacyHooks' removal"
jenkins-bot [Fri, 20 Jan 2017 20:12:57 +0000 (20:12 +0000)]
Merge "Add small script for common job queue admin tasks"
rlot [Fri, 20 Jan 2017 19:51:14 +0000 (20:51 +0100)]
Added release notes for 'ContentHandler::runLegacyHooks' removal
Bug: T154498
Change-Id: I37402478beaac1848feff2ed95e97bebbec5cee0
jenkins-bot [Fri, 20 Jan 2017 14:30:26 +0000 (14:30 +0000)]
Merge "Update docs/hooks.txt for ShowSearchHitTitle"
jenkins-bot [Fri, 20 Jan 2017 13:28:11 +0000 (13:28 +0000)]
Merge "Fix Selenium tests"
Željko Filipin [Thu, 19 Jan 2017 16:17:01 +0000 (17:17 +0100)]
Fix Selenium tests
The tests were broken because the feedback meesage is no longer
displayed as part of the page, but using HTML5 `required` attribute.
Bug: T155640
Change-Id: I9c46db374ec7f50262f84d721a21110aa6e81699
Yuriy Shnitkovskiy [Wed, 18 Jan 2017 20:55:20 +0000 (22:55 +0200)]
Replaced all deprecated Linker methods with proper ones in core(1)
Change-Id: Ie3a718dc1eae1507f8829fcf419c64c6846d2cb6
Thiemo Mättig [Fri, 20 Jan 2017 09:40:28 +0000 (10:40 +0100)]
Update docs/hooks.txt for ShowSearchHitTitle
Reasons:
* $text is vague. It's the label of the link. There is a function named
getTitleSnippet, which is what I'm reusing for the variable name.
* $page is vague. It's not the page of the search result, but the search
special page.
* $queryString is not a string but an array of strings.
I also updated https://www.mediawiki.org/wiki/Manual:Hooks/ShowSearchHitTitle
accordingly.
Change-Id: Ia18dbf5ccf7f9fcc8890ad01641d0b7ff3e6eee8
Translation updater bot [Fri, 20 Jan 2017 07:32:07 +0000 (08:32 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Id4e35d1705d767dfd1130533acfb0d721cc5829e
jenkins-bot [Thu, 19 Jan 2017 22:53:57 +0000 (22:53 +0000)]
Merge "Make most of DateFormatter private"
jenkins-bot [Thu, 19 Jan 2017 21:39:32 +0000 (21:39 +0000)]
Merge "SpecialContributions: Username input is not really required"
Max Semenik [Wed, 18 Jan 2017 19:01:26 +0000 (11:01 -0800)]
Make most of DateFormatter private
As discussed in https://gerrit.wikimedia.org/r/#/c/332702/ , these
methods and fields shouldn't have been marked public in the first place.
No outside users. Also, declare a couple of fields and remove unused ones.
Change-Id: I7775978c87d983784a484ee2ad901d25c42499b3
Bartosz Dziewoński [Thu, 19 Jan 2017 21:29:08 +0000 (22:29 +0100)]
SpecialContributions: Username input is not really required
Bug: T155780
Change-Id: If5cd6867029c005cf56a1628efc239955cd49931
jenkins-bot [Thu, 19 Jan 2017 21:07:36 +0000 (21:07 +0000)]
Merge "Remove unused $resourceLoader"
addshore [Thu, 19 Jan 2017 20:51:22 +0000 (20:51 +0000)]
Remove unused $resourceLoader
Change-Id: I6b5aebe2c6221ee101ec3bc4c84eafd9aeb7b0e2
James D. Forrester [Thu, 19 Jan 2017 20:33:18 +0000 (12:33 -0800)]
resources: Update OOjs UI with fixes on top of v0.18.4 (master)
Cherry-picked fixes:
*
be46e1773cd0f6b04510c325054d49835714b5f3
*
629389a777b35d131289a12cecf986e52ff65534
*
92dcdcf5351f6d499624d247b2a3ebff66346aca
*
f991c382ce3dd80ed3498bb09e81885b94f8795e
Bug: T155711
Bug: T155728
Change-Id: I741db3a17eec812b50b4befcc7eba603943b759c
Bartosz Dziewoński [Thu, 19 Jan 2017 19:56:47 +0000 (20:56 +0100)]
SpecialMIMEsearch: Add a dropdown with input suggestions
I think people usually distinguish file types by their extensions.
We shouldn't expect them to know what the valid values are here.
Change-Id: I854d48494e7b8c5eb1f49e364c5300df5cd73fe9
jenkins-bot [Thu, 19 Jan 2017 19:00:57 +0000 (19:00 +0000)]
Merge "Un-blacklist PhanUndeclaredVariable"
jenkins-bot [Thu, 19 Jan 2017 18:46:46 +0000 (18:46 +0000)]
Merge "Use HTTPS instead of HTTP for Amazon"
Bartosz Dziewoński [Thu, 19 Jan 2017 15:19:27 +0000 (16:19 +0100)]
HTMLTextField: Set the 'dir' attribute in OOUI mode
Bug: T153636
Change-Id: I7ddf6a358f8150ef252d8d8e76661fe1eb93a790
Fomafix [Thu, 19 Jan 2017 13:24:48 +0000 (14:24 +0100)]
Use HTTPS instead of HTTP for Amazon
This change is performed using:
sed -i -e 's/http:\/\/www.amazon/https:\/\/www.amazon/g' languages/messages/Messages*.php
Change-Id: I22c5e7a8d33a80b8cbe814f9735e7c24f1b004f9
jenkins-bot [Thu, 19 Jan 2017 09:59:33 +0000 (09:59 +0000)]
Merge "Use parsed HTML error responses instead of api-error-*"
jenkins-bot [Thu, 19 Jan 2017 06:50:21 +0000 (06:50 +0000)]
Merge "Add deprecated annotation to Article::doEditContent()"
jenkins-bot [Thu, 19 Jan 2017 03:54:49 +0000 (03:54 +0000)]
Merge "Add more $wgPoolCounterConf comments"
jenkins-bot [Thu, 19 Jan 2017 03:54:42 +0000 (03:54 +0000)]
Merge "Update tests/phpunit/MediaWikiTestCase.php with support for apcu"
Reedy [Thu, 19 Jan 2017 03:54:08 +0000 (03:54 +0000)]
Add deprecated annotation to Article::doEditContent()
Change-Id: I5a15b22c8b12fe77105fbd31427e8a15cde327c6
Paladox [Wed, 12 Oct 2016 14:39:46 +0000 (15:39 +0100)]
Update tests/phpunit/MediaWikiTestCase.php with support for apcu
Change-Id: I22d54e96c2c002ea53dabfd2772d2ba4c7eb96b1
Reedy [Thu, 19 Jan 2017 02:56:16 +0000 (02:56 +0000)]
Mark Article::doEditContent() as deprecated
Bug: T155696
Change-Id: Ie91b428f3a5992ba85c6ca2b2909953d8fce139b
Max Semenik [Fri, 23 Dec 2016 01:31:49 +0000 (17:31 -0800)]
Remove deprecated Parser::replaceUnusualEscapes()
Deprecated since 1.24, no callers.
Change-Id: Ib780f1a7b77d3ce624112f59c8e57820fecb6bf2
Timo Tijhof [Thu, 19 Jan 2017 02:48:38 +0000 (02:48 +0000)]
Remove unused fields in SpecialUnusedimages query
None of img_user, img_user_text, or img_description are used
by UnusedimagesPage nor ImageQueryPage.
Change-Id: Id0fdac9ac37eef097e8ca9f7bf3d66ef10bb83c2
Subin Siby [Tue, 27 Dec 2016 13:48:16 +0000 (19:18 +0530)]
Remove deprecated function Article::doEdit() and WikiPage::doEdit()
Bug: T61113
Bug: T154498
Change-Id: Ie6c1bb4ee5ee45ac2db432877a7038659231c091
Reedy [Thu, 19 Jan 2017 01:57:38 +0000 (01:57 +0000)]
Revision::getText() was removed
Bug: T154498
Change-Id: I29dcf768a9c176ca27b94359ac99cdc2b5ea930b
Reedy [Thu, 19 Jan 2017 01:49:07 +0000 (01:49 +0000)]
Article::getContent() was removed
Bug: T154498
Change-Id: I27956d494cf19d1204988807130b43f77186db9b
Roan Kattouw [Fri, 6 Jan 2017 23:51:22 +0000 (15:51 -0800)]
mediawiki.rcfilters: Add the remaining MW core filters
Add JSON definitions and i18n messages.
Bug: T149452
Change-Id: I287e9e5db9ff625bde026056efc81ce4b2401607
Aaron Schulz [Thu, 19 Jan 2017 00:27:17 +0000 (16:27 -0800)]
Add more $wgPoolCounterConf comments
Change-Id: Ic7b376dcada2b58a2f2ddc13b79e392e9d4fae6f
Aaron Schulz [Thu, 19 Jan 2017 00:02:16 +0000 (16:02 -0800)]
Add small script for common job queue admin tasks
This can handle dropping queued and re-enqueueing abandoned jobs.
Also use the DB cache table to avoid re-enqueuing duplicate jobs
if this has to get used several times for a queue during a week.
Change-Id: Ib56cf57e56f03ce6f1c4b52e3e36f228413c1056
jenkins-bot [Wed, 18 Jan 2017 22:44:01 +0000 (22:44 +0000)]
Merge "Unbreak extensions using SpecialSearchResults hook"
jenkins-bot [Wed, 18 Jan 2017 22:22:43 +0000 (22:22 +0000)]
Merge "Unbreak extensions from ShowSearchHitTitle signature change"
Chad Horohoe [Wed, 18 Jan 2017 22:21:36 +0000 (14:21 -0800)]
Unbreak extensions using SpecialSearchResults hook
Changing hook signatures with no deprecation period is a no-no.
Fixes Ib527fc3a3c39eb2e56985e5d1e4905fc4562353c
Reverts I153a7d590faceb1e2c4fe7d95a5cb931cda0c301
Bug: T155625
Change-Id: I2b408691fc4435ef24fc62360bd7ad6114f385c7
jenkins-bot [Wed, 18 Jan 2017 22:22:39 +0000 (22:22 +0000)]
Merge "Avoid fatal error with FlaggedRevs when running rebuildFileCache.php"
Chad Horohoe [Wed, 18 Jan 2017 22:05:45 +0000 (14:05 -0800)]
Unbreak extensions from ShowSearchHitTitle signature change
Fixes If78cb0c29ae394f16e465c15a8e8246c1b56dcea
Change-Id: Ia56f2eb4a5ed98f727f924666322e1c97b3ee183
rlot [Sun, 15 Jan 2017 18:49:28 +0000 (19:49 +0100)]
Removed deprecated ContentHandler hooks.
Plus removed unused "ContentHandler::runLegacyHooks"
Bug: T154498
Change-Id: Ie398fd4e06d3e286fe8e24112d0c8b4ac7d883dc
Erik Bernhardson [Wed, 18 Jan 2017 00:48:59 +0000 (16:48 -0800)]
Un-blacklist PhanUndeclaredVariable
Undeclared variables are a very common error type that we want to catch
as often as possible. To avoid needing to refactor a variety of global
level code (mostly in old-style maintenance scripts) this ignores
undeclared variables in global scope. This is still a good improvement
over what was happening previously.
Change-Id: I50b41d571724244552074b9408abbdf6160aca59
Translation updater bot [Wed, 18 Jan 2017 20:55:10 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I2ce862aae175fb1287086106a1fefb3e31de488b
jenkins-bot [Wed, 18 Jan 2017 19:25:26 +0000 (19:25 +0000)]
Merge "Remove deprecated mediawiki.UI Less variables"
jenkins-bot [Wed, 18 Jan 2017 19:23:04 +0000 (19:23 +0000)]
Merge "Remove deprecated `.mw-ui-constructive` class for text and anchors"
jenkins-bot [Wed, 18 Jan 2017 18:43:32 +0000 (18:43 +0000)]
Merge "OutputPage: Ignore protocol-relative urls in transformResourcePath()"
jenkins-bot [Wed, 18 Jan 2017 18:27:32 +0000 (18:27 +0000)]
Merge "tests: Add unit tests for OutputPage::transformResourcePath"
Timo Tijhof [Wed, 18 Jan 2017 06:07:05 +0000 (06:07 +0000)]
OutputPage: Ignore protocol-relative urls in transformResourcePath()
transformResourcePath is only supposed to be called with something
that starts with a '/' (absolute path from document root).
While the primary caller (CSSMin) only calls this method if the path
makes sense as a local file path, ResourceLoaderSkinModule did not,
and wgLogo may be set to a full url that includes a domain.
While chance made it so that protocol-including urls were already
discarded, protocol-relative urls were mistaken for being a path
inside the file system root with a duplicate slash (e.g.
'//tmp/foo.txt', as 'foo.txt' in /fmp, instead of '/foo.txt' at
http://tmp).
This should be fixed upstream in the wikimedia/relpath library,
but workaround it for now since it really shouldn't be called
with urls in the first place.
Bug: T155310
Change-Id: I9b063f1219ddeca5cc2c8a48832cdf8c9eaffe58
jenkins-bot [Wed, 18 Jan 2017 16:14:52 +0000 (16:14 +0000)]
Merge "Tweak formatting of 'restrictionsfield-help'"
Bartosz Dziewoński [Wed, 18 Jan 2017 13:08:28 +0000 (14:08 +0100)]
BlockLogFormatter: Durations are relative to block's timestamp, not Unix epoch
Also fixed legacy code in LogFormatter producing messages for IRC feed.
Bug: T55907
Change-Id: I0df19574f74210a91ce72c79188b6618f04ef9a2
jenkins-bot [Wed, 18 Jan 2017 08:00:48 +0000 (08:00 +0000)]
Merge "Pass the language code to the MessagesPreLoad hook"
Aaron Schulz [Wed, 18 Jan 2017 06:10:03 +0000 (22:10 -0800)]
Avoid fatal error with FlaggedRevs when running rebuildFileCache.php
Change-Id: I8d335c64cfc74a227528fbd85d333eaaa8157f41
Timo Tijhof [Wed, 18 Jan 2017 05:58:46 +0000 (05:58 +0000)]
tests: Add unit tests for OutputPage::transformResourcePath
Bug: T155310
Change-Id: Ic5a4af705c3734a7992037e59dc43fafe447ba12
jenkins-bot [Wed, 18 Jan 2017 01:45:21 +0000 (01:45 +0000)]
Merge "RCFilters: Clean up focus handling in capsule widget"
Bartosz Dziewoński [Wed, 18 Jan 2017 01:25:16 +0000 (02:25 +0100)]
Tweak formatting of 'restrictionsfield-help'
`<pre>` looks better for multiline code blocks than `<code>`.
Before: https://phabricator.wikimedia.org/
F5302938
After: https://phabricator.wikimedia.org/
F5302939
Change-Id: I1a180fee5e635e5f08c6730a9c390d7c4325ff9d
Roan Kattouw [Fri, 6 Jan 2017 23:59:48 +0000 (15:59 -0800)]
RCFilters: Clean up focus handling in capsule widget
Don't let the parent class's weird implementation run when the
widget is focused through other code paths (e.g. clicking on
the non-input part of it).
We still need to fix the behavior when you click in the
input twice (the first click shows the popup and the second
click hides it), but this is much better already.
Related to I21b8cff4048 in oojs-ui.
Bug: T149452
Change-Id: I08743c64ea32feace757e2a8626df2f5310cfbc9
jenkins-bot [Wed, 18 Jan 2017 01:13:32 +0000 (01:13 +0000)]
Merge "Update OOjs UI to v0.18.4"
James D. Forrester [Wed, 18 Jan 2017 00:12:07 +0000 (16:12 -0800)]
Update OOjs UI to v0.18.4
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.18.4
Change-Id: I09eacfe7597b26e33ef50e606afcee0cefca1d1c
Erik Bernhardson [Mon, 28 Nov 2016 21:59:03 +0000 (13:59 -0800)]
Extract 'did you mean' widget out of SpecialSearch
Bug: T150390
Change-Id: I41d767550ab4112fcd9cc4094b27a14c7d29169b
Erik Bernhardson [Wed, 16 Nov 2016 23:41:16 +0000 (15:41 -0800)]
Extract main search result rendering from SpecialSearch
Has a pre-existing problem related to the link offset of secondary
inline results. Specifically the offset of secondary inline starts
at the provided offset, even though there may be primary results
displayed above it.
Bug: T150390
Change-Id: Id1d6b357f45a2cf615d9412cc95dd597c724e8b6
jenkins-bot [Tue, 17 Jan 2017 23:50:03 +0000 (23:50 +0000)]
Merge "SpecialSearchResults hooks does not use by-ref anymore"
jenkins-bot [Tue, 17 Jan 2017 23:32:29 +0000 (23:32 +0000)]
Merge "Extract search form from SpecialSearch into widget"
Erik Bernhardson [Wed, 16 Nov 2016 00:10:33 +0000 (16:10 -0800)]
Extract search form from SpecialSearch into widget
Bug: T150390
Change-Id: Ibda84349e1f552641805d6236605c8718540817f
jenkins-bot [Tue, 17 Jan 2017 22:57:42 +0000 (22:57 +0000)]
Merge "Cleanup execution flow through SpecialSearch::execute()"
Stanislav Malyshev [Tue, 17 Jan 2017 22:51:51 +0000 (14:51 -0800)]
SpecialSearchResults hooks does not use by-ref anymore
In general, there's no reason to use by-ref on objects unless
the hook is supposed to replace them (this one isn't).
Change-Id: I153a7d590faceb1e2c4fe7d95a5cb931cda0c301
jenkins-bot [Tue, 17 Jan 2017 21:57:53 +0000 (21:57 +0000)]
Merge "Add test case for Opus file check"
Erik Bernhardson [Tue, 15 Nov 2016 01:11:43 +0000 (17:11 -0800)]
Cleanup execution flow through SpecialSearch::execute()
Not a big change, but makes it so there is only one path into
SpecialSearch::showResults(). Makes things a little easier to follow.
Also moves the code for checking if full text search is disabled into
execute(), makes sense to check before even trying to make a search
engine. Also moves some setup code out of execute and into the setupPage
function
Bug: T150393
Change-Id: Ib527fc3a3c39eb2e56985e5d1e4905fc4562353c