From: umherirrender Date: Sat, 9 Feb 2013 15:12:09 +0000 (+0100) Subject: Use OldLocalFile::selectFields() X-Git-Tag: 1.31.0-rc.0~20739^2 X-Git-Url: http://git.cyclocoop.org/%22.%24redirect_annul.%22?a=commitdiff_plain;h=7b9a0ec232ffbd8ae7170404c9893d45572c1d82;p=lhc%2Fweb%2Fwiklou.git Use OldLocalFile::selectFields() It is good practice to specifiy the fields in a select Change-Id: I3faa568ed6311a585da9161eccd8da3d065da250 --- diff --git a/includes/revisiondelete/RevisionDelete.php b/includes/revisiondelete/RevisionDelete.php index 5340cb9ec0..bd909d2bcb 100644 --- a/includes/revisiondelete/RevisionDelete.php +++ b/includes/revisiondelete/RevisionDelete.php @@ -454,7 +454,9 @@ class RevDel_FileList extends RevDel_List { foreach( $this->ids as $timestamp ) { $archiveNames[] = $timestamp . '!' . $this->title->getDBkey(); } - return $db->select( 'oldimage', '*', + return $db->select( + 'oldimage', + OldLocalFile::selectFields(), array( 'oi_name' => $this->title->getDBkey(), 'oi_archive_name' => $archiveNames