dépôts
/
lhc
/
web
/
wiklou.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
7b9870d
)
setTitle on a new null revision
author
umherirrender
<umherirrender_de.wp@web.de>
Sun, 27 May 2012 15:47:29 +0000
(17:47 +0200)
committer
umherirrender
<umherirrender_de.wp@web.de>
Sun, 27 May 2012 15:47:29 +0000
(17:47 +0200)
Revision::getTitle will make a query against slave to load the title on
demand. But when there is a slave lag, the slave does not know the new
revision id and the caller gets null back
Change-Id: Ia85866362715ba666d51106037e7771d6bf4a237
includes/Revision.php
patch
|
blob
|
history
diff --git
a/includes/Revision.php
b/includes/Revision.php
index
6928eb9
..
98b8a0d
100644
(file)
--- a/
includes/Revision.php
+++ b/
includes/Revision.php
@@
-1120,7
+1120,8
@@
class Revision {
$current = $dbw->selectRow(
array( 'page', 'revision' ),
- array( 'page_latest', 'rev_text_id', 'rev_len', 'rev_sha1' ),
+ array( 'page_latest', 'page_namespace', 'page_title',
+ 'rev_text_id', 'rev_len', 'rev_sha1' ),
array(
'page_id' => $pageId,
'page_latest=rev_id',
@@
-1137,6
+1138,7
@@
class Revision {
'len' => $current->rev_len,
'sha1' => $current->rev_sha1
) );
+ $revision->setTitle( Title::makeTitle( $current->page_namespace, $current->page_title ) );
} else {
$revision = null;
}