From 85d1a883691473a539a2a90ef55d553d5e9b5eca Mon Sep 17 00:00:00 2001
From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= <matma.rex@gmail.com>
Date: Wed, 11 Oct 2017 20:25:26 +0200
Subject: [PATCH] phpcs.xml: Remove missing functions from
 PrefixedGlobalFunctions 'ignoreList'

Some of these functions appear to have been removed or moved into
proper classes, so remove the unnecessary exceptions.

Also include a list of where these functions are defined.

Change-Id: I7d525f17dd52321475707d021f489857ce98894d
---
 phpcs.xml | 35 ++++++++++++++++++++++++++++++++++-
 1 file changed, 34 insertions(+), 1 deletion(-)

diff --git a/phpcs.xml b/phpcs.xml
index 29ddca34cc..4be45b13e7 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -28,7 +28,40 @@
 	</rule>
 	<rule ref="MediaWiki.NamingConventions.PrefixedGlobalFunctions">
 		<properties>
-			<property name="ignoreList" type="array" value="bfNormalizeTitleStrReplace,bfNormalizeTitleStrTr,cdbShowHelp,codepointToUtf8,compare_point,cssfilter,escapeSingleString,findAuxFile,findFiles,getEscapedProfileUrl,getFileCommentFromSourceWiki,getFileUserFromSourceWiki,hexSequenceToUtf8,mccGetHelp,mccShowUsage,mimeTypeMatch,moveToExternal,NothingFunction,NothingFunctionData,resolveStub,resolveStubs,showUsage,splitFilename,utf8ToCodepoint,utf8ToHexSequence" />
+			<!--
+			includes/compat/normal/UtfNormalUtil.php
+			* codepointToUtf8
+			* escapeSingleString
+			* hexSequenceToUtf8
+			* utf8ToCodepoint
+			* utf8ToHexSequence
+			includes/GlobalFunctions.php
+			* mimeTypeMatch
+			maintenance/benchmarks/bench_strtr_str_replace.php
+			* bfNormalizeTitleStrReplace
+			* bfNormalizeTitleStrTr
+			maintenance/cdb.php
+			* cdbShowHelp
+			maintenance/language/transstat.php
+			* showUsage
+			maintenance/mcc.php
+			* mccGetHelp
+			* mccShowUsage
+			maintenance/storage/moveToExternal.php
+			* moveToExternal
+			maintenance/storage/resolveStubs.php
+			* resolveStub
+			* resolveStubs
+			profileinfo.php
+			* compare_point
+			* getEscapedProfileUrl
+			tests/phpunit/includes/HooksTest.php
+			* NothingFunction
+			* NothingFunctionData
+			tests/qunit/data/styleTest.css.php
+			* cssfilter
+			-->
+			<property name="ignoreList" type="array" value="bfNormalizeTitleStrReplace,bfNormalizeTitleStrTr,cdbShowHelp,codepointToUtf8,compare_point,cssfilter,escapeSingleString,getEscapedProfileUrl,hexSequenceToUtf8,mccGetHelp,mccShowUsage,mimeTypeMatch,moveToExternal,NothingFunction,NothingFunctionData,resolveStub,resolveStubs,showUsage,utf8ToCodepoint,utf8ToHexSequence" />
 		</properties>
 	</rule>
 	<rule ref="MediaWiki.NamingConventions.ValidGlobalName">
-- 
2.20.1