From 41682d4f2a23cdab61482894d958ae7b4fe25438 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Thu, 24 May 2018 13:35:50 +0100 Subject: [PATCH] Remove mentions of jquery.mw-jump in code comments The idea of listening for an event and doing something, with on('focus'), is rather trivial and not worth attributing to another module, in particular when that module is being phased out :) Bug: T195256 Change-Id: Ic6a65254cbcc5e9503fece1afb7861a706713d77 --- resources/src/mediawiki.page.gallery.js | 1 - resources/src/mediawiki.special.preferences.ooui/tabs.js | 4 ++-- resources/src/mediawiki.special.preferences/tabs.legacy.js | 4 ++-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/resources/src/mediawiki.page.gallery.js b/resources/src/mediawiki.page.gallery.js index 9448ab8a78..7927f20c44 100644 --- a/resources/src/mediawiki.page.gallery.js +++ b/resources/src/mediawiki.page.gallery.js @@ -246,7 +246,6 @@ } else { // Note use of just `a`, not `a.image`, since we also want this to trigger if a link // within the caption text receives focus. - // This is based on code from the 'jquery.mw-jump' module. $content.find( 'ul.mw-gallery-packed-hover li.gallerybox' ).on( 'focus blur', 'a', function ( e ) { // Confusingly jQuery leaves e.type as focusout for delegated blur events var gettingFocus = e.type !== 'blur' && e.type !== 'focusout'; diff --git a/resources/src/mediawiki.special.preferences.ooui/tabs.js b/resources/src/mediawiki.special.preferences.ooui/tabs.js index 40c9df932d..795a2b7e97 100644 --- a/resources/src/mediawiki.special.preferences.ooui/tabs.js +++ b/resources/src/mediawiki.special.preferences.ooui/tabs.js @@ -8,8 +8,8 @@ $preferences = $( '#preferences' ); // Make sure the accessibility tip is selectable so that screen reader users take notice, - // but hide it per default to reduce interface clutter. Also make sure it becomes visible - // when selected. Similar to jquery.mw-jump + // but hide it by default to reduce visual clutter. + // Make sure it becomes visible when focused. $( '
' ).addClass( 'mw-navigation-hint' ) .text( mw.msg( 'prefs-tabs-navigation-hint' ) ) .attr( 'tabIndex', 0 ) diff --git a/resources/src/mediawiki.special.preferences/tabs.legacy.js b/resources/src/mediawiki.special.preferences/tabs.legacy.js index 0d97d68e84..598b8f8f26 100644 --- a/resources/src/mediawiki.special.preferences/tabs.legacy.js +++ b/resources/src/mediawiki.special.preferences/tabs.legacy.js @@ -27,8 +27,8 @@ $fieldsets.children( 'legend' ).addClass( 'mainLegend' ); // Make sure the accessibility tip is selectable so that screen reader users take notice, - // but hide it per default to reduce interface clutter. Also make sure it becomes visible - // when selected. Similar to jquery.mw-jump + // but hide it by default to reduce visual clutter. + // Make sure it becomes visible when focused. $( '
' ).addClass( 'mw-navigation-hint' ) .text( mw.msg( 'prefs-tabs-navigation-hint' ) ) .attr( 'tabIndex', 0 ) -- 2.20.1