Happy-melon [Fri, 15 Apr 2011 22:11:33 +0000 (22:11 +0000)]
Follow-up r86041: fix redirect in PurgeAction, and pass query parameters through the form so they can be put back on to the redirect at the end.
Brian Wolff [Fri, 15 Apr 2011 21:53:55 +0000 (21:53 +0000)]
(follow-up r86121) Use strict comparision.
Third times the charm...
Brian Wolff [Fri, 15 Apr 2011 20:57:24 +0000 (20:57 +0000)]
(bug 28561 - follow-up r4185) remove rule .small * {font-size: 94%} causes anything nested to be super-small
I'm not sure what the intent was, but this rule will make something like:
<span class="small">fo<b>o</b></span>
have the second o in foo be smaller then the first. Even without this rule, nested instances
of class="small" will still be smaller than a single instance, so it only causes weirdness.
Raimond Spekking [Fri, 15 Apr 2011 20:02:58 +0000 (20:02 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-04-15 19:40:00 UTC)
Aaron Schulz [Fri, 15 Apr 2011 18:40:25 +0000 (18:40 +0000)]
* Pass around parser options instead of users and made some parser options consistency fixes
* Moved makeParserOptions to Article.php
* Renamed currentIncludeVersions -> getRevIncludes
* Renamed updatePageCache -> setPageCache
* Moved FlaggedRevs::getCacheKey up
Brian Wolff [Fri, 15 Apr 2011 18:39:43 +0000 (18:39 +0000)]
(follow-up r69626) Make it so the intl normalizer_normalize function is not
fed an invalid sequence in UtfNormal::cleanUp
normalizer_normalize seems to return false if fed an invalid unicode sequence (Which is quite different
from what our built in normalization functions do). So use quickIsNFC if it returns false.
(Noticed when investigating bug 28541).
Chad Horohoe [Fri, 15 Apr 2011 18:06:03 +0000 (18:06 +0000)]
Followup r83755: You removed them, you didn't deprecate them (there is a difference). If you're going to remove them, go the whole way rather than having people think they might still work.
Sam Reed [Fri, 15 Apr 2011 17:44:19 +0000 (17:44 +0000)]
More function documentation
Brian Wolff [Fri, 15 Apr 2011 17:23:44 +0000 (17:23 +0000)]
(follow-up r86100) Make categorypage not die as much while transitioning between 1.16 -> 1.17 schema
Basically re-putting in the intent of r83544 per suggestion on CR of r86100
Jure Kajzer [Fri, 15 Apr 2011 11:19:13 +0000 (11:19 +0000)]
* added E_DEPRECATED into wfSupressWarnings
merge into 1.17 if required PHP version will be 5.3+
Jure Kajzer [Fri, 15 Apr 2011 10:48:02 +0000 (10:48 +0000)]
* updated tableName function changed addIdentifierQuotes, added isQuotedIdentifier and removeIdentifierQuotes
* quoting objects in Oracle is poorly supported prior to 10g (it still has bugs in 10g) so i wish to avoid it for as long as possible
* i've added /*Q*/ marker to avoid double-prefixing of table names
* tableName quoted parameter is usable only in cases where you call it directly in functions where it might occur that tableName can get called twice it is unusable as the tableName gets prefixed twice
Oracle documentation is generally crappy. They claim a lot of things but some of those claims depend on a gazillion of factors and in case of one of this factors being a bit off have no general solution. Object name quoting is one of such things and is general practice amongst oracle DBAs that if you write the code directly you can use them but if you write abstracted or embedded code it's best to stay away if you can.
Leo Koppelkamm [Fri, 15 Apr 2011 08:31:05 +0000 (08:31 +0000)]
r86108: Fix var name
Leo Koppelkamm [Fri, 15 Apr 2011 08:23:29 +0000 (08:23 +0000)]
Followup ro r86088: Use data-sort-type instead of classes to specify the parser-type; add support for data-sort-value; strip legacy code (CR)
Leo Koppelkamm [Fri, 15 Apr 2011 07:28:02 +0000 (07:28 +0000)]
Updating jQuery from 1.4.2->1.4.4, for better data-* support. 1.4.4 contains the patch from r74326 in core
Nimish Gautam [Fri, 15 Apr 2011 00:23:37 +0000 (00:23 +0000)]
added explanation of the BeforeWelcomeCreation hook
Brian Wolff [Thu, 14 Apr 2011 23:28:11 +0000 (23:28 +0000)]
(bug 28540) revert r83544 - It really breaks things when using uca-default collation (As noticed on tw)
Various functions (particuarly the getFirstCharacter ones) all expect to have the human readable sortkey.
Passing them the binary sortkey results in the getFirstChar headers to be totally wrong. It also
causes paging not to work since the sortkey gets double encoded.
This issue probably wasn't noticed, since it wouldn't be visible on the uppercase collation
as uppercasing the first letter won't affect the first character headings, nor does double uppercasing
something matter.
Also changed one of the variable names from $rawSortkey to $humanSortkey as it confused me
(raw as in before turning to binary, or raw as in the real non-human readable sortkey)
Leo Koppelkamm [Thu, 14 Apr 2011 21:47:00 +0000 (21:47 +0000)]
Completely rewritten table sorting script.
Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732
1. Sites can specify custom collations.
The script accepts an object "tableSorterCollation" which contains a lookup
table, how specific characters should be treated.
For example, after setting "tableSorterCollation={'ä':'ae', 'ß':'ss'};" in the
site's common.js any string containing an ä or Ä will be sorted as if it were a
'ae'.
2. Table rows can be forced to use a specific data type.
By setting class="sort-{Parsername}", the row will be parsed with the specified
algorithm. class="sort-date" would force date sorting etc.
The following parsers are available: text, IPAddress, number, url, currency,
date, isoDate, usLongDate, time
3. Execution time is reduced by half or more.
Sorting a 935 row * 8 columns table:
Browser Before After
-------- ------ -----
Chrome 10 90ms 42ms
Safari 5 115ms 48ms
Firefox 4 412ms 87ms
IE8 720ms 115ms
4. Based on the content language and the mdy vs dmy preference, the parser can
understand dates such as "17. März '11". wgMonthNames=[] and
wgMonthNamesShort=[]
in the content language and the mdy vs dmy preference are exported to js; A
table containing the following dates would be sorted correctly:
17. Jan. 01
23 Feb 1992
9.02.05
13 November 2001
14 Oktober '76
Was tested in ie6-8, chrome, safari 5, ff3 & ff4
Sam Reed [Thu, 14 Apr 2011 21:21:28 +0000 (21:21 +0000)]
Followup r85944, move UtfNormalDefins stuff out of extensions profiling area
Bryan Tong Minh [Thu, 14 Apr 2011 21:09:16 +0000 (21:09 +0000)]
Follow-up r83302: Check permissions
Leo Koppelkamm [Thu, 14 Apr 2011 20:50:28 +0000 (20:50 +0000)]
Another table parser test
Leons Petrazickis [Thu, 14 Apr 2011 20:03:37 +0000 (20:03 +0000)]
Followup r85885: Better error message for an insufficient pagesize in a DB2 database.
Alexandre Emsenhuber [Thu, 14 Apr 2011 20:00:25 +0000 (20:00 +0000)]
Fix warning: Missing argument 1 for wfDeprecated(), called in includes/Article.php on line 580 and defined in includes/GlobalFunctions.php on line 3094
Raimond Spekking [Thu, 14 Apr 2011 19:49:05 +0000 (19:49 +0000)]
Localisation updates for ToolserverI18N messages from translatewiki.net (2011-04-14 19:30:00 UTC)
Leo Koppelkamm [Thu, 14 Apr 2011 19:28:45 +0000 (19:28 +0000)]
Followup to r86064 (List with double line-breaks inside tables). Also contains patch for Bug 16700 by Mormegil (Additional linebreak though nested templates). Parsertests for both
Alexandre Emsenhuber [Thu, 14 Apr 2011 19:01:04 +0000 (19:01 +0000)]
Update undelete.php to use short option aliases.
People using --u and --r will need to change either to -u or --user for --u and to -r or --reason for --r.
Sam Reed [Thu, 14 Apr 2011 18:46:37 +0000 (18:46 +0000)]
Ensure $collationConds is defined on all paths
Leo Koppelkamm [Thu, 14 Apr 2011 18:45:04 +0000 (18:45 +0000)]
Fix for r85990, which broke lists inside tables; adding test for it
Leo Koppelkamm [Thu, 14 Apr 2011 17:46:59 +0000 (17:46 +0000)]
Adding some parser test for tables. Fixing one parser test, which broke due to changes in a string in MessagesSr_ec.php
Brian Wolff [Thu, 14 Apr 2011 17:42:12 +0000 (17:42 +0000)]
Allow people to use ' entity (sinqle quote character: ') in wikitext.
It probably wasn't included originally, as its not part of html4,
but was introduced in XML/XHTML1. Since we do all sorts of weird stuff
with ' characters (italic/bold) its probably good to allow lowly users to
have an easy to remember way of escaping it.
There's also a whole bunch of entities in html5 that we should maybe consider
decoding as well.
Leo Koppelkamm [Thu, 14 Apr 2011 17:04:49 +0000 (17:04 +0000)]
Changing icons used in installer to GNOME ones, like the rest of vector skin. Also fixing Bug 28298 (one border extens a few pixel too much in installer)
Niklas Laxström [Thu, 14 Apr 2011 16:09:07 +0000 (16:09 +0000)]
Removed unmatched wfProfileOut
Leo Koppelkamm [Thu, 14 Apr 2011 16:06:02 +0000 (16:06 +0000)]
Followup to r86047: Rewrite the radio-button updater & move everything to action.history. Also move to fixCompare version by Helder, since HTMLdiff is scrapped
Niklas Laxström [Thu, 14 Apr 2011 16:05:59 +0000 (16:05 +0000)]
Added one @since annotation I had to check out
Max Semenik [Thu, 14 Apr 2011 15:56:40 +0000 (15:56 +0000)]
Added wrapper mw.api() for API calls
Happy-melon [Thu, 14 Apr 2011 15:11:30 +0000 (15:11 +0000)]
Changes to SpecialPage: deprecate any syntax for defining pages other than $wgSpecialPage['PageName'] = 'ClassName', including SpecialRedirectToSpecial, which is ugly and nasty anyway.
Leo Koppelkamm [Thu, 14 Apr 2011 13:52:08 +0000 (13:52 +0000)]
Followup to r86047: Declare dependency to JUI button more cleanly
Happy-melon [Thu, 14 Apr 2011 13:27:50 +0000 (13:27 +0000)]
Recommit r84805, but without removing UsersPager, which is actually a Good Thing to use for this class of queries. Yay for the end of global-function-based special pages in core. About fifteen left in extensions now...
Leo Koppelkamm [Thu, 14 Apr 2011 13:18:39 +0000 (13:18 +0000)]
History: Adding JS that converts buttons to links for better UX. Patch based on one by Matthew Flaschen. Fixes Bug 16165
Leo Koppelkamm [Thu, 14 Apr 2011 13:09:02 +0000 (13:09 +0000)]
Updating jQuery UI to 1.8.11 (was 1.8.2). Also loosening button css, since j.ui.button works for non <button> elements as well
Happy-melon [Thu, 14 Apr 2011 12:17:24 +0000 (12:17 +0000)]
Follow-up r 86041 per CR and IRC:
* Article constructor needs to be called with zero as second parameter
* Run stylize.php over new files
* Add Action::getLang() for consistency with other context accessors
* Fix declaration of FormAction::alterForm(), doesn't need to be passed by reference
* Fix inline use of Credits::getCredits() in SkinTemplate and SkinLegacy
Niklas Laxström [Thu, 14 Apr 2011 11:58:52 +0000 (11:58 +0000)]
Fix regression introduced in r82451. Only happens when getAllHeaders was not called before LanguageSelector hook was executed, not sure in which conditions this happens or not.
Niklas Laxström [Thu, 14 Apr 2011 11:37:03 +0000 (11:37 +0000)]
Move $rxTc initialization next to where it is used
Happy-melon [Thu, 14 Apr 2011 10:38:29 +0000 (10:38 +0000)]
r86001, now with less scariness :P I took out the delete action and did purge instead, which is a much more self-contained action-with-a-form. Also implement a few changes suggested by Brion on IRC last night.
Leo Koppelkamm [Thu, 14 Apr 2011 10:02:51 +0000 (10:02 +0000)]
Fixing line-break issues with r85922
Tim Starling [Thu, 14 Apr 2011 07:10:59 +0000 (07:10 +0000)]
(bug 28507) Fix for r85844: that revision was not actually sufficient to fix bug 28235, since URLs can have more than one question mark in them.
Platonides [Wed, 13 Apr 2011 23:50:33 +0000 (23:50 +0000)]
Move </td> and </th> to its own line (unless it's an empty cell)
Fixes the other r86004 test case and r86010 one.
Nimish Gautam [Wed, 13 Apr 2011 23:47:01 +0000 (23:47 +0000)]
Created BeforeWelcomeCreation hook to be run before any welcome message gets displayed
Platonides [Wed, 13 Apr 2011 23:36:49 +0000 (23:36 +0000)]
Another evil test to join r86004 (didn't produce malformed output in the pre-r85922 parser)
Happy-melon [Wed, 13 Apr 2011 23:36:27 +0000 (23:36 +0000)]
Revert r86001: Brion says it's too scary :D will recommit in pieces
Platonides [Wed, 13 Apr 2011 23:19:27 +0000 (23:19 +0000)]
Follow up r85922 moving the </caption> to another line, fixing one of the tests added in r86004.
Platonides [Wed, 13 Apr 2011 23:16:22 +0000 (23:16 +0000)]
Add a couple of broken tests showing why having the table closing tags in the same line is not a good idea.
Platonides [Wed, 13 Apr 2011 23:12:25 +0000 (23:12 +0000)]
Follow up r85991. For some reason I committed the test for r85921 parser, not for r85922
Happy-melon [Wed, 13 Apr 2011 23:04:07 +0000 (23:04 +0000)]
New infrastructure for actions, as discussed on wikitech-l. Fairly huge commit.
* Actions come in two flavours: the show-a-form-then-do-something-with-the-result (delete, protect, edit, etc) and the just-do-something (watch, rollback, patrol, etc). Create abstract base classes Action and FormlessAction to support these two cases. HTMLForm is an integral part of the form-based structure.
* Look mum, no globals! :D Fully context-based.
* Implement watch/unwatch, credits and delete actions in the new system as proof-of-concept. This also gives the delete frontend a much-needed overhaul.
* Stub out the newly-deprecated functions from Article.php. This already reduces its linecount by about 15%, and there are plenty more actions still to do.
* Centralising actions like this is going to render a lot of hooks type-incompatible. There's simply nowhere you can put the ArticleConfirmDelete hook, for instance, where it can be passed an OutputPage as the second parameter. On the other hand, we can implement new hooks like ActionModifyFormFields and ActionBeforeFormDisplay, which can do much prettier stuff to the forms, like adding extra fields the 'right' way. Update LiquidThreads to use these new hooks where appropriate.
Happy-melon [Wed, 13 Apr 2011 22:30:13 +0000 (22:30 +0000)]
Unbundle OutputPage::showErrorPage() in Exception.php to allow ErrorPageError objects to be passed a Message object for a more complicated display.
Platonides [Wed, 13 Apr 2011 22:20:14 +0000 (22:20 +0000)]
Readd support for headings inside tables, broken in r85922 and reported on its CodeReview.
Added testcase for it.
It changes again Parser24.
Raimond Spekking [Wed, 13 Apr 2011 20:02:04 +0000 (20:02 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-04-13 19:20:00 UTC)
Leo Koppelkamm [Wed, 13 Apr 2011 20:01:23 +0000 (20:01 +0000)]
Tables: Fix Bug 20078, add test for it
Leo Koppelkamm [Wed, 13 Apr 2011 19:46:09 +0000 (19:46 +0000)]
Followup to r85922: Adapt to MW-coding style
Happy-melon [Wed, 13 Apr 2011 16:51:22 +0000 (16:51 +0000)]
Look mum, no globals! Implement a RequestContext for HTMLForm, passed in the constructor. Currently this is optional with B/C; at a later date it should be made compulsory. Doing this removes the need to call $form->setTitle() on every single use; only when you want to set the title to something other than the page context title. Implemented the new syntax in a sample of forms. Also fix a few minor errors in HTMLForm.php that my IDE complained about.
Happy-melon [Wed, 13 Apr 2011 14:30:55 +0000 (14:30 +0000)]
Implement user-is-blocked and wiki-is-read-only as exceptions.
Happy-melon [Wed, 13 Apr 2011 14:27:59 +0000 (14:27 +0000)]
Follow-up r85929: update MediaWiki::articleFromTitle() call in SearchEngine.php
Sam Reed [Wed, 13 Apr 2011 13:09:17 +0000 (13:09 +0000)]
Related to bug 28470 (Doxygen not updating)
Move require_once( MWInit::compiledPath( 'includes/normal/UtfNormalDefines.php' ) ); to Setup.php
Might want relocating in Setup.php though
Leo Koppelkamm [Wed, 13 Apr 2011 12:44:33 +0000 (12:44 +0000)]
Followup to r85922: Output th instead of td for tfoot
Leo Koppelkamm [Wed, 13 Apr 2011 11:24:38 +0000 (11:24 +0000)]
Followup to r85922: Fix STRICT error, rmv redundant whitespace
Neil Kandalgaonkar [Wed, 13 Apr 2011 05:40:51 +0000 (05:40 +0000)]
reverting some changes unintentionally committed in r85939
Neil Kandalgaonkar [Wed, 13 Apr 2011 05:31:22 +0000 (05:31 +0000)]
followup to r85929 -- missing the break;s for non-default cases.
Aaron Schulz [Wed, 13 Apr 2011 00:50:44 +0000 (00:50 +0000)]
* Removed getSelectOptions, which did nothing other than send FOR UPDATE on some slave queries to barely used features
* Removed only Core use of forUpdate(); same issue
Happy-melon [Tue, 12 Apr 2011 23:28:23 +0000 (23:28 +0000)]
Follow-up r85928: back out unrelated changes.
Happy-melon [Tue, 12 Apr 2011 23:02:02 +0000 (23:02 +0000)]
Follow-up r85928: AutoLoader entry.
Happy-melon [Tue, 12 Apr 2011 23:00:49 +0000 (23:00 +0000)]
Implement a $context and getContext/setContext methods for Article (and its subclasses).
Happy-melon [Tue, 12 Apr 2011 22:59:17 +0000 (22:59 +0000)]
allow methods to generate a "user does not have required permissions" error by throwing an exception rather than calling $wgOut->permissionRequired(). Currently somewhat circular as the exception goes back to OutputPage::showErrorPage(), but hopefully that global dependency can be reduced in future.
Leo Koppelkamm [Tue, 12 Apr 2011 21:27:24 +0000 (21:27 +0000)]
Platonides [Tue, 12 Apr 2011 20:56:35 +0000 (20:56 +0000)]
$wgDBprefix shall be converted to uppercase per r85786
Platonides [Tue, 12 Apr 2011 20:48:19 +0000 (20:48 +0000)]
I forgot to commit this in r85906
Happy-melon [Tue, 12 Apr 2011 20:38:16 +0000 (20:38 +0000)]
Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc.
* Fix parsing of the three major entry points (index.php, api.php, load.php) back to PHP 4.4.9. We don't care what happens if you actually try to run these files on old versions, but the entry files need to parse correctly.
* consign /includes/templates/PHP4.php and /includes/templates/NoLocalSettings.php to the fiery pit of hell where they belong.
* Prevent loading of any other files for PHP < 5. WebStart.php was rendered unparseable in PHP 4 by the introduction of try/catch blocks in r85327.
* Die outright with a pretty error message on PHP < 5.2.3 as well as PHP 4. All versions of PHP below that throw parse errors of various sorts.
* Reimplement wfDie() to provide an entry-point-dependent die-with-readable-error-message function (for instance, we want a pretty human-readable page in index.php, something wrapped in CSS/JS /*...*/ comment block in load.php, etc).
* Standardise the appearance of the catastrophic errors thrown at the top of the stack with the ones lower down (exception-within-exception, etc). There isn't really a way to do this without duplication, AFAICT.
Sam Reed [Tue, 12 Apr 2011 20:30:25 +0000 (20:30 +0000)]
Reverting r85784 for good measure too
(Pending better solution)
Sam Reed [Tue, 12 Apr 2011 20:27:26 +0000 (20:27 +0000)]
Revert r85776, r85782 pending better solution
Aaron Schulz [Tue, 12 Apr 2011 20:26:56 +0000 (20:26 +0000)]
Added pageDataFromId return type to docs
Aaron Schulz [Tue, 12 Apr 2011 20:21:16 +0000 (20:21 +0000)]
* Made pageDataFromTitle protected (unused elsewhere)
* Split out selectFields() for easier use of loadPageData()
* Marked Revision::selectFields as public (was used as such)
Bryan Tong Minh [Tue, 12 Apr 2011 19:25:56 +0000 (19:25 +0000)]
Add support for importing/exporting files. This can be done by embedding the image as base64 in the XML stream or by copying the images directory manually and pointing the importer to the base images directory.
Currently only backend code available and a few member variables need to be modified to enable the functionality.
Export.php:
* Add <rel> and <sha1base36> elememnts to the XML output
* Add optional <archivename> and <contents> elements to the XML output. <contents> contains an encoding attribute, which is currently only set to base64.
Import.php:
* Add Import::$mImageBasePath which should point to the images/ directory to import from
* Add methods to WikiRevision (terrible name btw) to set the rel, hash, archivename and filesrc.
* Cleanup and made WikiRevision::importUpload working. It's still quite a mess though
OldLocalFiel.php:
* Fix a few timestamp related things from r85635
Raimond Spekking [Tue, 12 Apr 2011 19:17:37 +0000 (19:17 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-04-12 19:00:00 UTC)
Platonides [Tue, 12 Apr 2011 18:59:19 +0000 (18:59 +0000)]
Follow up r85888: Add the parameter to DatabasePostgres.php and DatabaseOracle.php
Follow up r85884: The parent tableName() should work now for DatabaseMssql.php
Platonides [Tue, 12 Apr 2011 18:54:51 +0000 (18:54 +0000)]
Change the duplicateTableStructure() to use the original names.
It is now duplicateTableStructure() duty to addIdentifierQuotes() them.
Fixed bug for mysql < 4.1 where the new name would be quoted twice.
Always quote identifier in Oracle, doing otherwise seems a bug (can someone confirm?)
Platonides [Tue, 12 Apr 2011 18:52:16 +0000 (18:52 +0000)]
Follow up r85888
Ryan Kaldari [Tue, 12 Apr 2011 17:32:59 +0000 (17:32 +0000)]
less redundant wording, follow up to r85894
Leons Petrazickis [Tue, 12 Apr 2011 17:18:35 +0000 (17:18 +0000)]
Addressing comments by Krinkle on r85885. Removing commented-out code. Verified that there is no more of it.
Ryan Kaldari [Tue, 12 Apr 2011 17:11:43 +0000 (17:11 +0000)]
updating release notes, follow up to r85847 and r83212
Siebrand Mazeland [Tue, 12 Apr 2011 17:08:59 +0000 (17:08 +0000)]
Fix typo in r85885.
Brion Vibber [Tue, 12 Apr 2011 17:08:31 +0000 (17:08 +0000)]
Revert r84856: restore version that works before destruction of the UsersPager class
Ryan Kaldari [Tue, 12 Apr 2011 17:07:58 +0000 (17:07 +0000)]
Livonian
Leons Petrazickis [Tue, 12 Apr 2011 17:07:01 +0000 (17:07 +0000)]
Addressing comment by IAlex. Setting svn:eol-style to native and removing ?> from end of file.
Brion Vibber [Tue, 12 Apr 2011 17:04:56 +0000 (17:04 +0000)]
Revert r84805: broke CentralAuth by removing base UsersPager class used in other special pages
Platonides [Tue, 12 Apr 2011 17:00:08 +0000 (17:00 +0000)]
Add parameter to tableName() to get the bare table name.
Siebrand Mazeland [Tue, 12 Apr 2011 16:58:50 +0000 (16:58 +0000)]
Update wording for messages added in r85976.
Platonides [Tue, 12 Apr 2011 16:57:44 +0000 (16:57 +0000)]
No need to quote just to avoid the prefixes.
Leons Petrazickis [Tue, 12 Apr 2011 16:35:41 +0000 (16:35 +0000)]
Fixes to DB2 support. DB2 support integration with 1.17 Installer and Updater. Developed by Andre, Tiago, Diego, and Cesar as described in wikitech-l message. Reviewed by me.
Platonides [Tue, 12 Apr 2011 16:34:12 +0000 (16:34 +0000)]
Abstract tableName() by adding new function isQuotedIdentifier() to databases.
This fixes bug in DatabaseOracle.php tableName() on line 671 and allows it to call
the parent implementation instead of copying it with different quotes.
Adapt Mssql addIdentifierQuotes(). Replace its addIdentifierQuotes calls with addQuotes
as it's what it really is. The serialize() is probably unneeded, since I don't think it will
ever be called with objects but I kept it anyway.
Jack Phoenix [Tue, 12 Apr 2011 15:46:00 +0000 (15:46 +0000)]
follow-up to r85876: fix some coding style issues (some of which were not introduced in r85876) + tweak docs (we don't usually mark author(s)/copyright holder(s) on individual functions, only on whole files)
Max Semenik [Tue, 12 Apr 2011 15:37:51 +0000 (15:37 +0000)]
Made install.php fail gracefully on PHP4
Purodha B Blissenbach [Tue, 12 Apr 2011 13:01:14 +0000 (13:01 +0000)]
Add new message of r85876 to messge maintenance list.