Daniel Friesen [Sun, 3 Apr 2011 12:55:48 +0000 (12:55 +0000)]
Followup r85250; Revert a static method back to use of $wgRequest... :/ damnit resourceloader...
Daniel Friesen [Sun, 3 Apr 2011 12:46:36 +0000 (12:46 +0000)]
Continue with r85240; Move getSkin from User to RequestContext, do it without globals, strip out the non-functional $title related stuff, and update Skin to use a RequestContext.
Daniel Friesen [Sun, 3 Apr 2011 12:37:07 +0000 (12:37 +0000)]
Followup r85244; Fix a small issue with the case of a variable name.
Daniel Friesen [Sun, 3 Apr 2011 12:04:04 +0000 (12:04 +0000)]
Followup r85244; Define all methods as static, implement a DummyLinker to forward calls for passing to hooks and finish off anything in the way.
Daniel Friesen [Sun, 3 Apr 2011 11:44:11 +0000 (11:44 +0000)]
Drop connetion between Skin and Linker and turn Linker into a staticly usable class.
Daniel Friesen [Sun, 3 Apr 2011 11:33:10 +0000 (11:33 +0000)]
Followup r85229; Drop this unnecessary reference on the user from ChangesList::newFromUser.
Daniel Friesen [Sun, 3 Apr 2011 11:09:49 +0000 (11:09 +0000)]
Followup r85240; Commit the additional file that was part of that change. ;) this wouldn't have happened if we were using git... seriously!
Siebrand Mazeland [Sun, 3 Apr 2011 10:52:54 +0000 (10:52 +0000)]
Update profiling.
Daniel Friesen [Sun, 3 Apr 2011 10:41:14 +0000 (10:41 +0000)]
Implement the RequestContext class. Some credit to IAlex, ;) other credit for me and that plethora of bugs and hicoughs I had to deal with in impelenting it.
http://www.mediawiki.org/wiki/Requests_for_comment/Context_object (it's little different though)
Alexandre Emsenhuber [Sun, 3 Apr 2011 09:44:50 +0000 (09:44 +0000)]
* Drop 5.1 compat code
* Fix one more PHP version requirement
Daniel Friesen [Sun, 3 Apr 2011 08:49:16 +0000 (08:49 +0000)]
Followup r85228; Small fix for ()> syntax error that should have been ()->
Niklas Laxström [Sun, 3 Apr 2011 08:33:53 +0000 (08:33 +0000)]
Follow-up r85226, r85227: add @since annotations
Daniel Friesen [Sun, 3 Apr 2011 06:26:58 +0000 (06:26 +0000)]
Followup r85227; Back out changes related to avoiding calls to OutputPage from includable special pages. After some re-examination we replace the OutputPage and OutputPage is coded in a way to avoid poluting global things with things like the use of header(); in set* calls, so setting things on OutputPage while in an includable special page just gets discarded.
Aaron Schulz [Sun, 3 Apr 2011 05:53:07 +0000 (05:53 +0000)]
* Removed isset() checks - redundant given Parser::version
* For sanity in insertOn(), if the template/file version arrays are null, don't hit the DB - just assume they are empty
* Refactored mFlags handling in FlaggedRevision
* Use accessors for ParserOutput template/file versions
* Added OutputPage accessors for template/file versions
* Changed instance of NS_IMAGE -> NS_FILE
Daniel Friesen [Sun, 3 Apr 2011 05:46:42 +0000 (05:46 +0000)]
Followup r85227. Convert all IncludableSpecialPages to use context properly (they are the worse offenders), and fix some bugs related to inculudable special pages and their context.
Daniel Friesen [Sun, 3 Apr 2011 04:37:13 +0000 (04:37 +0000)]
Followup r85227, update 4 special pages to properly use the context.
Daniel Friesen [Sun, 3 Apr 2011 04:36:02 +0000 (04:36 +0000)]
Start managing output and input context from special pages themselves instead of using globals. We already had a setContext, Special page implementations should be properly utalizing that data.
Daniel Friesen [Sun, 3 Apr 2011 03:59:47 +0000 (03:59 +0000)]
Start better utalizing OutputPage as the focal point for things related to the output of the page. Like getTitle use $out->get{User,Skin} instead of $wgUser and $wgUser->getSkin() for things where the user or skin is being used for output generation back to $out instead of using globals with bad structure.
Rotem Liss [Sat, 2 Apr 2011 20:52:28 +0000 (20:52 +0000)]
Localization update for he.
Alexandre Emsenhuber [Sat, 2 Apr 2011 18:59:47 +0000 (18:59 +0000)]
Made index.php's profiling cosistent with other entry scripts
Alexandre Emsenhuber [Sat, 2 Apr 2011 18:38:42 +0000 (18:38 +0000)]
* Moved all <link> definitions in OutputPage::getHeadLinks() instead of having them in a *lot* of different functions
* Also moved there generic <meta> and removed OutputPage::addDefaultMeta() with its $called static local variable which was breaking the output when generating multiple pages on the same request (rebuildFileCache.php, dumpHTML.php) since that function could only be executed completely once for all instances, and not once per instance
* Moved default module from OutputPage::output() to its own function and don't call it when executing a body only request, since it's useless in that case
* Call Skin::setMembers() from Skin::initPage() instead of Skin::outputPage()
Aaron Schulz [Sat, 2 Apr 2011 16:49:47 +0000 (16:49 +0000)]
(bug 28348) Don't call wfTimestamp() twice really fast in recordUpload2() and expect the values to be the same. Previously the file prop cache value for the upload timestamp could fall out of sync for a while due to this (like being off by one second).
Jack Phoenix [Sat, 2 Apr 2011 14:53:02 +0000 (14:53 +0000)]
follow-up to r85193: missed one file
Jack Phoenix [Sat, 2 Apr 2011 14:50:31 +0000 (14:50 +0000)]
ImagePage.php: add missing braces + other code style tweaks
Bryan Tong Minh [Sat, 2 Apr 2011 14:49:12 +0000 (14:49 +0000)]
Get the thumbmime from the handler instead of guessing it with UnregisteredLocalFile.
Jack Phoenix [Sat, 2 Apr 2011 14:48:22 +0000 (14:48 +0000)]
mark some public functions as such
Alexandre Emsenhuber [Sat, 2 Apr 2011 09:50:20 +0000 (09:50 +0000)]
Respect $wgScriptExtension in SearchEngine::getOpenSearchTemplate() and SearchEngine::getMWSuggestTemplate()
Alexandre Emsenhuber [Sat, 2 Apr 2011 09:34:22 +0000 (09:34 +0000)]
Removed deprecated Image class per documentation; no use in core or extensions
Max Semenik [Sat, 2 Apr 2011 08:41:48 +0000 (08:41 +0000)]
Removed archive(), deprecated and not used
Niklas Laxström [Sat, 2 Apr 2011 08:22:52 +0000 (08:22 +0000)]
Followup r80398: fix overspecific css rules which broke
Max Semenik [Sat, 2 Apr 2011 07:34:07 +0000 (07:34 +0000)]
Cleaned up the mess of message text being passed instead of keys to wfMsg() and friends by CLI installer. No surprise we had to remove angle brackets from the resulting output
Mark A. Hershberger [Sat, 2 Apr 2011 04:49:29 +0000 (04:49 +0000)]
Fix Bug#24308 where, on some platforms the date_create() function fails when the timezone isn't specified.
Sam Reed [Sat, 2 Apr 2011 00:27:03 +0000 (00:27 +0000)]
Remove unused global, fix double defined global
Sam Reed [Sat, 2 Apr 2011 00:26:40 +0000 (00:26 +0000)]
Fix casing of SpecialListUsers
Happy-melon [Fri, 1 Apr 2011 23:13:15 +0000 (23:13 +0000)]
Follow-up r85025: fix the you're-trying-to-block-yourself-you-twit warning, and make it an actual checkbox confirmation. Also use said confirmation for reblocks, and HideUser (bug 18678). Mark a static function from HTMLForm which is called from SpecialBlock as explicitly public.
Brion Vibber [Fri, 1 Apr 2011 21:14:52 +0000 (21:14 +0000)]
Memory stress test for UtfNormal issue re bug 28146
This pulls the source texts used for the UtfNormalBench.php benchmarks, repeats them into much larger strings, and attempts to reproduce an out-of-memory error in the middle of UtfNormal::cleanUp():
$ php
Testing testdata/washington.txt (English text)...
quickIsNFCVerify 1078.3ms 14,969,652 bytes/s (changed)
cleanUp 992.1ms 16,270,594 bytes/s (no change)
Testing testdata/berlin.txt (German text)...
PHP Fatal error: Allowed memory size of
136314880 bytes exhausted (tried to allocate 71 bytes) in /var/www/trunk/includes/normal/UtfNormal.php on line 285
Exact failure point may require adjustment depending on platform, etc.
Raimond Spekking [Fri, 1 Apr 2011 20:53:41 +0000 (20:53 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-04-01 20:38:00 UTC)
Trevor Parscal [Fri, 1 Apr 2011 20:48:50 +0000 (20:48 +0000)]
Added charset property to HTTP Content-Type fields when serving CSS and JavaScript via ResourceLoader - resolves bug #28208.
Niklas Laxström [Fri, 1 Apr 2011 19:30:08 +0000 (19:30 +0000)]
Reword this message per IRC cabbage
Max Semenik [Fri, 1 Apr 2011 18:24:37 +0000 (18:24 +0000)]
We developers are so elitist, running shiny machines with all PHP extensions in the world installed, that we couldn't notice that "no scaler found" message didn't work from the beginning! :P
Trevor Parscal [Fri, 1 Apr 2011 18:05:15 +0000 (18:05 +0000)]
Fixed issue where reference error can be thrown - response to comments on r84985
Sam Reed [Fri, 1 Apr 2011 17:29:15 +0000 (17:29 +0000)]
Followup r84825
Allow obtaining of an import token if users have the importupload right
Chad Horohoe [Fri, 1 Apr 2011 15:57:20 +0000 (15:57 +0000)]
Revert r64853 (add $wgLogAutocreatedAccounts to enable/disable account autocreation logging, bug 19161). Per the *extremely lengthy* discussion that is still ongoing, this fails to solve the underlying problem and has undesired side-effects.
I don't know what the proper solution is (other than introducing user preferences, like bug 28369 suggests, is not the answer)...but the status quo of what we had is better than this half-assed solution that *nobody* likes.
Aryeh Gregor [Fri, 1 Apr 2011 14:50:29 +0000 (14:50 +0000)]
Document what settings are disabled by $wgHtml5
Bug 28350.
Purodha B Blissenbach [Fri, 1 Apr 2011 11:28:18 +0000 (11:28 +0000)]
Fix for r85114, see code reviev
at http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85114
Purodha B Blissenbach [Fri, 1 Apr 2011 10:46:56 +0000 (10:46 +0000)]
Fix r85110, see code review
at http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85110
Alexandre Emsenhuber [Fri, 1 Apr 2011 09:50:09 +0000 (09:50 +0000)]
Drop 5.1 compatibility calls to session_set_cookie_params() and setcookie() since we require 5.2.3+ now
Purodha B Blissenbach [Fri, 1 Apr 2011 09:35:44 +0000 (09:35 +0000)]
Add optional PLURAL parameter to messages 'userrights-changeable-col' and 'userrights-unchangeable-col'
Alexandre Emsenhuber [Fri, 1 Apr 2011 09:35:39 +0000 (09:35 +0000)]
Moved constant initialisation to class definition instead of constructor
Brion Vibber [Thu, 31 Mar 2011 23:40:51 +0000 (23:40 +0000)]
* (bug 27893) Edit-on-doubleclick now applies only on view and purge actions;
no longer triggers unexpectedly on delete, history etc.
Purodha B Blissenbach [Thu, 31 Mar 2011 23:23:11 +0000 (23:23 +0000)]
Fix omission of r85007,
see code review at http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85007
Happy-melon [Thu, 31 Mar 2011 23:09:02 +0000 (23:09 +0000)]
Fix for r85005: the getUserPermissionsErrors() calls were each returning a badaccess error when the user didn't have their particular permission, even if they had the other one, exclude these errors since they're already covered by the $user->isAllowedAny() check above. Also fix processForm() to check isAllowed('import') for transwiki; this wasn't being done which meant users with importupload but not import (an unlikely combination to be fair) could still spoof the form.
Brion Vibber [Thu, 31 Mar 2011 23:02:38 +0000 (23:02 +0000)]
Tweak doc comment per bug 28340
Ryan Lane [Thu, 31 Mar 2011 21:16:22 +0000 (21:16 +0000)]
This script didn't actually work, and was a live hack. This is a followup to the fixme in r79021.
Raimond Spekking [Thu, 31 Mar 2011 19:42:16 +0000 (19:42 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-31 19:24:00 UTC)
Max Semenik [Thu, 31 Mar 2011 14:11:42 +0000 (14:11 +0000)]
Follow-up r85021: fix comment
Happy-melon [Thu, 31 Mar 2011 10:29:10 +0000 (10:29 +0000)]
Document blocklist-target message, per TWN request translatewiki.net/wiki/Thread:Support/Please_document_MediaWiki:Blocklist-target
Niklas Laxström [Thu, 31 Mar 2011 10:21:30 +0000 (10:21 +0000)]
Don't differentiate between user accounts and IPs in special page names.
BTW: Special:Block says "Block user" in page title followed immediately "Block user" as legend for fieldset.
Siebrand Mazeland [Thu, 31 Mar 2011 07:12:16 +0000 (07:12 +0000)]
Fix grammar for singular. Spotted by McDutchie.
OverlordQ [Wed, 30 Mar 2011 20:56:03 +0000 (20:56 +0000)]
Followup to r85021, fix caller in updater maintenance script
Happy-melon [Wed, 30 Mar 2011 20:05:17 +0000 (20:05 +0000)]
Follow-up r85025 - use strict comparison
Raimond Spekking [Wed, 30 Mar 2011 20:03:22 +0000 (20:03 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-30 19:35:00 UTC)
Sam Reed [Wed, 30 Mar 2011 19:44:39 +0000 (19:44 +0000)]
Fixup a couple more undefined variables
Sam Reed [Wed, 30 Mar 2011 19:39:59 +0000 (19:39 +0000)]
Fixup undefined $stores in if like renamewiki does it
Sam Reed [Wed, 30 Mar 2011 19:00:11 +0000 (19:00 +0000)]
Fixup/add documentation
Remove some unused variables
Sam Reed [Wed, 30 Mar 2011 18:56:31 +0000 (18:56 +0000)]
Swap = to == in conditional
Max Semenik [Wed, 30 Mar 2011 18:45:13 +0000 (18:45 +0000)]
Fixed fatal in r84971
Sam Reed [Wed, 30 Mar 2011 18:40:36 +0000 (18:40 +0000)]
Move duplicated Site class into own class in Maintenance.php, include in 2 users
Sam Reed [Wed, 30 Mar 2011 18:37:25 +0000 (18:37 +0000)]
Fix class name
Sam Reed [Wed, 30 Mar 2011 18:34:38 +0000 (18:34 +0000)]
Fix missing parameter to cacheUpdate
Happy-melon [Wed, 30 Mar 2011 18:06:05 +0000 (18:06 +0000)]
Follow-up r85020 per CR - use strict comparison
Happy-melon [Wed, 30 Mar 2011 18:00:11 +0000 (18:00 +0000)]
(bug 23408) give admins a warning before letting them block themselves. Also tweak the logic so that loading the interface for one already-blocked user, then actually submitting a block on a different user, shows the confirmation again if the second user is already blocked.
Platonides [Wed, 30 Mar 2011 17:41:58 +0000 (17:41 +0000)]
Add a couple of brace test cases.
Happy-melon [Wed, 30 Mar 2011 17:37:25 +0000 (17:37 +0000)]
(bug 19942) remove deprecated HTML attributes (cellpadding, align, valign) from TablePager.
Max Semenik [Wed, 30 Mar 2011 17:32:20 +0000 (17:32 +0000)]
(bug 28237) Installer doesn't create extension tables
Happy-melon [Wed, 30 Mar 2011 17:04:03 +0000 (17:04 +0000)]
(bug 18937) avoid broken wikimarkup (four apostrophes together) in MediaWiki:Confirmrecreate when there is no deletion reason, by using a separate message.
Happy-melon [Wed, 30 Mar 2011 16:44:13 +0000 (16:44 +0000)]
(bug 17009) remove hiddenStructure. Wasn't even applied across all skins anyway, would have been broken in cologneblue, standard, etc.
Chad Horohoe [Wed, 30 Mar 2011 14:33:37 +0000 (14:33 +0000)]
Merge some deployment changes to trunk: r82738 (as HISTORY), r81962
Purodha B Blissenbach [Wed, 30 Mar 2011 13:52:32 +0000 (13:52 +0000)]
Add optional parameter $1 for PLURAL use to messages userrights-groupsmember and userrights-groupsmember-auto
Happy-melon [Wed, 30 Mar 2011 12:58:09 +0000 (12:58 +0000)]
Additional release notes for r85005, which I meant to commit as two separate revisions as one needs to be backported (grr...)
Happy-melon [Wed, 30 Mar 2011 12:53:13 +0000 (12:53 +0000)]
(bug 15641) tweak Title::checkUserBlock() so that Title::getUserPermissionsErrors() more comprehensively prevents blocked users from performing various actions; particularly prevents blocked admins from protecting or deleting their own talk page.
Sam Reed [Wed, 30 Mar 2011 12:04:54 +0000 (12:04 +0000)]
Fixup some ambiguously defined variables
Cast a substr back to int
Sam Reed [Wed, 30 Mar 2011 12:04:25 +0000 (12:04 +0000)]
Use unused $fallback_languages
Purodha B Blissenbach [Wed, 30 Mar 2011 06:35:32 +0000 (06:35 +0000)]
Fix new typos introduced in r84799.
Russ Nelson [Wed, 30 Mar 2011 01:49:38 +0000 (01:49 +0000)]
missing closedir() and ... protected the readdir against opendir() failing
Trevor Parscal [Tue, 29 Mar 2011 22:08:57 +0000 (22:08 +0000)]
Swtiched to using console.log if present so that when errors occur inside of modules they are shown, even if you aren't in debug mode. This helps avoid the common pitfall of forgetting to export a symbol to the global space, because in debug mode everything is exported to the global space whereas in production mode it's wrapped in a closure.
Raimond Spekking [Tue, 29 Mar 2011 20:19:59 +0000 (20:19 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-29 20:00:00 UTC)
Max Semenik [Tue, 29 Mar 2011 19:00:23 +0000 (19:00 +0000)]
Tweaks for key generation:
* Don't show that scary message for every key, just once with list of them all
* If we're on Windows, we will probably be unable to open /dev/urandom, right?
* Tweaked the meaning of warning message, previously it sounded a bit like "we couldn't generate the key at all"
Chad Horohoe [Tue, 29 Mar 2011 18:47:35 +0000 (18:47 +0000)]
Place a warning about Postgres, since we haven't quite ironed out the final problems
Krinkle [Tue, 29 Mar 2011 18:36:36 +0000 (18:36 +0000)]
using jQuery hide() and show() instead of accessing the dom element directly from the jQuery object (either use jQuery or dont..).
Chad Horohoe [Tue, 29 Mar 2011 17:34:00 +0000 (17:34 +0000)]
minor cleanup
Chad Horohoe [Tue, 29 Mar 2011 17:06:26 +0000 (17:06 +0000)]
(bug 26481) $wgUpgradeKey/$wgSecretKey values sometimes not filled - only happened when you upgrade without LocalSettings and tried to create a new one
Purodha B Blissenbach [Mon, 28 Mar 2011 22:02:23 +0000 (22:02 +0000)]
Acknowledge that the e-mail address of the initial wiki sysop is optional.
Aaron Schulz [Mon, 28 Mar 2011 21:40:50 +0000 (21:40 +0000)]
Reverted r84918 per CR
Raimond Spekking [Mon, 28 Mar 2011 20:30:46 +0000 (20:30 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-27 20:06:00 UTC)
Russ Nelson [Mon, 28 Mar 2011 19:57:48 +0000 (19:57 +0000)]
findFileFromKey, newFileFromKey, $fileFactoryKey, and $oldFileFactoryKey weren't used by anything in .../extensions nor .../phase3
Roan Kattouw [Mon, 28 Mar 2011 15:01:20 +0000 (15:01 +0000)]
BREAKING CHANGE: Ignore cmtype when cmsort=timestamp is set, and bypass the per-type queries in the sort=timestamp case; they were causing performance problems, reported as bug 28291. This breaks backwards compatibility (gracefully, the cltype parameter is silently ignored) with earlier deployed versions of 1.17wmf1 but not with any released version, hence no RELEASE-NOTES
Daniel Friesen [Mon, 28 Mar 2011 03:57:18 +0000 (03:57 +0000)]
Followup r79639, add a new parser test for gallery items not using a namespace prefix.
Daniel Friesen [Mon, 28 Mar 2011 03:38:43 +0000 (03:38 +0000)]
Followup r81928, make proper use of $this->output instead of echo.
Daniel Friesen [Mon, 28 Mar 2011 03:25:36 +0000 (03:25 +0000)]
Followup r79433, hide realname from output when realnames are a hidden pref.