From: Sam Reed <reedy@users.mediawiki.org>
Date: Sun, 5 Jun 2011 19:22:49 +0000 (+0000)
Subject: * (bug 28002) Internal error in ApiFormatRaw::getMimeType
X-Git-Tag: 1.31.0-rc.0~29698
X-Git-Url: http://git.cyclocoop.org/%22.%24info%5B?a=commitdiff_plain;h=f1ece7a090b3f68c1ff3c646073b65bf59522d95;p=lhc%2Fweb%2Fwiklou.git

* (bug 28002) Internal error in ApiFormatRaw::getMimeType

If we just return when no titles, we don't format anything, and everything breaks

Might aswell just unconditionally export, as even with no titles, we still get all the siteinfo and such
---

diff --git a/RELEASE-NOTES-1.19 b/RELEASE-NOTES-1.19
index 82e5ca0ab9..28a1dae8a3 100644
--- a/RELEASE-NOTES-1.19
+++ b/RELEASE-NOTES-1.19
@@ -98,6 +98,7 @@ production.
 * (bug 29267) always give the servername for meta=siteinfo&siprop=dbrepllag
 * (bug 28897) rvparse doesn’t seem to work with rvsection
 * (bug 25734) API: possible issue with revids validation
+* (bug 28002) Internal error in ApiFormatRaw::getMimeType
 
 === Languages updated in 1.19 ===
 
diff --git a/includes/api/ApiQuery.php b/includes/api/ApiQuery.php
index ded1ea54a1..ac679ae552 100644
--- a/includes/api/ApiQuery.php
+++ b/includes/api/ApiQuery.php
@@ -484,10 +484,6 @@ class ApiQuery extends ApiBase {
 				}
 			}
 		}
-		// only export when there are titles
-		if ( !count( $exportTitles ) ) {
-			return;
-		}
 
 		$exporter = new WikiExporter( $this->getDB() );
 		// WikiExporter writes to stdout, so catch its