From: Bartosz Dziewoński <matma.rex@gmail.com>
Date: Mon, 21 Nov 2016 14:30:57 +0000 (+0100)
Subject: mw.Upload.BookletLayout: Improve error message when not all logged-in users can upload
X-Git-Tag: 1.31.0-rc.0~4790^2
X-Git-Url: http://git.cyclocoop.org/%22.%24info%5B?a=commitdiff_plain;h=eb25a6dd0243eece02ec6587a0633165991443cd;p=lhc%2Fweb%2Fwiklou.git

mw.Upload.BookletLayout: Improve error message when not all logged-in users can upload

Bug: T139257
Change-Id: I0ba4d0deba68d76bbcb01ee2202f82d392a68107
---

diff --git a/resources/src/mediawiki/mediawiki.Upload.BookletLayout.js b/resources/src/mediawiki/mediawiki.Upload.BookletLayout.js
index 100714a862..c7ebfd8a51 100644
--- a/resources/src/mediawiki/mediawiki.Upload.BookletLayout.js
+++ b/resources/src/mediawiki/mediawiki.Upload.BookletLayout.js
@@ -187,8 +187,11 @@
 					// If the user can't upload anything, don't give them the option to.
 					api.getUserInfo().then( function ( userInfo ) {
 						if ( userInfo.rights.indexOf( 'upload' ) === -1 ) {
-							// TODO Use a better error message when not all logged-in users can upload
-							booklet.getPage( 'upload' ).$element.msg( 'api-error-mustbeloggedin' );
+							if ( mw.user.isAnon() ) {
+								booklet.getPage( 'upload' ).$element.msg( 'api-error-mustbeloggedin' );
+							} else {
+								booklet.getPage( 'upload' ).$element.msg( 'api-error-badaccess-groups' );
+							}
 						}
 						return $.Deferred().resolve();
 					} )