From: umherirrender <umherirrender_de.wp@web.de>
Date: Mon, 29 Dec 2014 18:24:20 +0000 (+0100)
Subject: Fix warning on Special:ListGroupRights for group with invalid group page
X-Git-Tag: 1.31.0-rc.0~12844^2
X-Git-Url: http://git.cyclocoop.org/%22.%24info%5B?a=commitdiff_plain;h=a9eae0b6308d2d3746156677355163cd7381e7e8;p=lhc%2Fweb%2Fwiklou.git

Fix warning on Special:ListGroupRights for group with invalid group page

Avoids
Notice: Linker::link: Requires $target to be a Title object. [Called
from SpecialListGroupRights::execute in
\includes\specials\SpecialListgrouprights.php at line 97]

Change-Id: Ie90ea33b0f57861985a296380e4ee7296dac79af
---

diff --git a/includes/specials/SpecialListgrouprights.php b/includes/specials/SpecialListgrouprights.php
index 8b9a0ee450..828a93b9b9 100644
--- a/includes/specials/SpecialListgrouprights.php
+++ b/includes/specials/SpecialListgrouprights.php
@@ -86,13 +86,14 @@ class SpecialListGroupRights extends SpecialPage {
 			$grouppageLocalized = !$msg->isBlank() ?
 				$msg->text() :
 				MWNamespace::getCanonicalName( NS_PROJECT ) . ':' . $groupname;
+			$grouppageLocalizedTitle = Title::newFromText( $grouppageLocalized );
 
-			if ( $group == '*' ) {
-				// Do not make a link for the generic * group
+			if ( $group == '*' || !$grouppageLocalizedTitle ) {
+				// Do not make a link for the generic * group or group with invalid group page
 				$grouppage = htmlspecialchars( $groupnameLocalized );
 			} else {
 				$grouppage = Linker::link(
-					Title::newFromText( $grouppageLocalized ),
+					$grouppageLocalizedTitle,
 					htmlspecialchars( $groupnameLocalized )
 				);
 			}