From: Brion Vibber <brion@users.mediawiki.org>
Date: Wed, 19 Aug 2009 18:22:31 +0000 (+0000)
Subject: Cleanup for r54264 "* Don't suppress warnings while developing, wasting my time for... 
X-Git-Tag: 1.31.0-rc.0~40199
X-Git-Url: http://git.cyclocoop.org/%22.%24info%5B?a=commitdiff_plain;h=6792448843370abb772750df45c96264590b35a2;p=lhc%2Fweb%2Fwiklou.git

Cleanup for r54264 "* Don't suppress warnings while developing, wasting my time for debugging"
Remove the warning suppression entirely; if you're seeing any warnings come up here it's probably because you forgot an isset() :) Please find and fix any such items.
---

diff --git a/skins/Vector.php b/skins/Vector.php
index 99f6d53c69..6461ec3526 100644
--- a/skins/Vector.php
+++ b/skins/Vector.php
@@ -366,15 +366,11 @@ class VectorTemplate extends QuickTemplate {
 	 * Outputs the entire contents of the XHTML page
 	 */
 	public function execute() {
-		global $wgRequest, $wgOut, $wgContLang, $wgDevelopmentWarnings;
+		global $wgRequest, $wgOut, $wgContLang;
 
 		$this->skin = $this->data['skin'];
 		$action = $wgRequest->getText( 'action' );
 
-		// Suppress warnings to prevent notices about missing indexes in
-		// $this->data (is this really the best way to handle this?)
-		$wgDevelopmentWarnings && wfSuppressWarnings();
-
 		// Build additional attributes for navigation urls
 		$nav = $this->skin->buildNavigationUrls();
 		foreach ( $nav as $section => $links ) {
@@ -578,8 +574,6 @@ class VectorTemplate extends QuickTemplate {
 	</body>
 </html>
 <?php
-		// We're done with abusing arrays now...
-		$wgDevelopmentWarnings && wfRestoreWarnings();
 	}
 
 	/**