From 51f400bc93957b70880cb3affbfcb8498388f24a Mon Sep 17 00:00:00 2001
From: Sam Reed <reedy@users.mediawiki.org>
Date: Fri, 9 Mar 2012 23:33:42 +0000
Subject: [PATCH] Documentation, spaces, braces, explicit member variables

---
 includes/installer/Installer.php           |  8 ++++++--
 includes/specials/SpecialContributions.php | 11 +++++++++++
 includes/specials/SpecialVersion.php       |  2 +-
 3 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/includes/installer/Installer.php b/includes/installer/Installer.php
index 67e167d84d..d6a0c869f9 100644
--- a/includes/installer/Installer.php
+++ b/includes/installer/Installer.php
@@ -1094,12 +1094,16 @@ abstract class Installer {
 		if( $utf8 ) {
 			$useNormalizer = 'utf8';
 			$utf8 = utf8_normalize( $not_normal_c, UtfNormal::UNORM_NFC );
-			if ( $utf8 !== $normal_c ) $needsUpdate = true;
+			if ( $utf8 !== $normal_c ) {
+				$needsUpdate = true;
+			}
 		}
 		if( $intl ) {
 			$useNormalizer = 'intl';
 			$intl = normalizer_normalize( $not_normal_c, Normalizer::FORM_C );
-			if ( $intl !== $normal_c ) $needsUpdate = true;
+			if ( $intl !== $normal_c ) {
+				$needsUpdate = true;
+			}
 		}
 
 		// Uses messages 'config-unicode-using-php', 'config-unicode-using-utf8', 'config-unicode-using-intl'
diff --git a/includes/specials/SpecialContributions.php b/includes/specials/SpecialContributions.php
index 501ccee517..054047412e 100644
--- a/includes/specials/SpecialContributions.php
+++ b/includes/specials/SpecialContributions.php
@@ -220,6 +220,7 @@ class SpecialContributions extends SpecialPage {
 		}
 		$nt = $userObj->getUserPage();
 		$talk = $userObj->getTalkPage();
+		$links = '';
 		if ( $talk ) {
 			$tools = $this->getUserLinks( $nt, $talk, $userObj );
 			$links = $this->getLanguage()->pipeList( $tools );
@@ -545,6 +546,11 @@ class ContribsPager extends ReverseChronologicalPager {
 	var $namespace = '', $mDb;
 	var $preventClickjacking = false;
 
+	/**
+	 * @var array
+	 */
+	protected $mParentLens;
+
 	function __construct( IContextSource $context, array $options ) {
 		parent::__construct( $context );
 
@@ -709,6 +715,7 @@ class ContribsPager extends ReverseChronologicalPager {
 
 	/**
 	 * Do a batched query to get the parent revision lengths
+	 * @param $revIds array
 	 * @return array
 	 */
 	private function getParentLengths( array $revIds ) {
@@ -751,6 +758,7 @@ class ContribsPager extends ReverseChronologicalPager {
 	 * was not written by the target user.
 	 *
 	 * @todo This would probably look a lot nicer in a table.
+	 * @param $row
 	 * @return string
 	 */
 	function formatRow( $row ) {
@@ -902,6 +910,9 @@ class ContribsPager extends ReverseChronologicalPager {
 		$this->preventClickjacking = true;
 	}
 
+	/**
+	 * @return bool
+	 */
 	public function getPreventClickjacking() {
 		return $this->preventClickjacking;
 	}
diff --git a/includes/specials/SpecialVersion.php b/includes/specials/SpecialVersion.php
index 597863b207..2b44337bb6 100644
--- a/includes/specials/SpecialVersion.php
+++ b/includes/specials/SpecialVersion.php
@@ -725,7 +725,7 @@ class SpecialVersion extends SpecialPage {
 		}
 
 		preg_match( "/ref: (.*)/",
-			file_get_contents( $HEADfile), $m );
+			file_get_contents( $HEADfile ), $m );
 
 		$REFfile = "{$BASEDIR}{$m[1]}";
 		if( !file_exists( $REFfile ) ) {
-- 
2.20.1