From 27e6e298885542536bcef6dd23161bcb733d5b0a Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Mon, 6 Jun 2016 17:27:37 -0700 Subject: [PATCH] Remove getOptions() checks from getStashKey() entirely It only avoided a tiny edge case of options lag, which is not worth the complexity. Change-Id: I94bc35fc89eb46436a23b10aee1b7d339859c7ea --- includes/api/ApiStashEdit.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/includes/api/ApiStashEdit.php b/includes/api/ApiStashEdit.php index 01153a58c9..6b3c26e9c9 100644 --- a/includes/api/ApiStashEdit.php +++ b/includes/api/ApiStashEdit.php @@ -412,9 +412,7 @@ class ApiStashEdit extends ApiBase { sha1( $content->serialize( $content->getDefaultFormat() ) ), // Account for user name related variables like signatures $user->getId(), - md5( $user->getName() ), - (string)$user->getOption( 'nickname' ), - (int)$user->getBoolOption( 'fancysig' ) + md5( $user->getName() ) ] ) ); return wfMemcKey( 'prepared-edit', md5( $title->getPrefixedDBkey() ), $hash ); -- 2.20.1