From: Aaron Schulz <aschulz@wikimedia.org>
Date: Tue, 14 Oct 2014 21:58:26 +0000 (-0700)
Subject: Removed extra "tries" increment in the redis job queue
X-Git-Tag: 1.31.0-rc.0~13556
X-Git-Url: http://git.cyclocoop.org/%22.%24image2.%22?a=commitdiff_plain;h=a6814c9df38176726fdd53b4310ec045cee0ace9;p=lhc%2Fweb%2Fwiklou.git

Removed extra "tries" increment in the redis job queue

* This could result in jobs getting one less extra tries than they should

Change-Id: Ia2e82ca0965f6ce9e1354820eb03f40f047a949c
---

diff --git a/includes/jobqueue/JobQueueRedis.php b/includes/jobqueue/JobQueueRedis.php
index b87c678a36..e6724f7432 100644
--- a/includes/jobqueue/JobQueueRedis.php
+++ b/includes/jobqueue/JobQueueRedis.php
@@ -614,7 +614,6 @@ LUA;
 				if attempts < ARGV[3] then
 					-- Claim expired and retries left: re-enqueue the job
 					redis.call('lPush',kUnclaimed,id)
-					redis.call('hIncrBy',kAttempts,id,1)
 					released = released + 1
 				else
 					-- Claim expired and no retries left: mark the job as dead