From: Huji <huji@users.mediawiki.org>
Date: Fri, 24 Oct 2008 13:34:17 +0000 (+0000)
Subject: (bug 12764) Special:LonelyPages shows transcluded pages
X-Git-Tag: 1.31.0-rc.0~44626
X-Git-Url: http://git.cyclocoop.org/%22.%24image2.%22?a=commitdiff_plain;h=49846ef7f23644a0b9621d85cf12eeebb78ec435;p=lhc%2Fweb%2Fwiklou.git

(bug 12764) Special:LonelyPages shows transcluded pages
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 0e33791d54..1d850d61ff 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -282,6 +282,7 @@ The following extensions are migrated into MediaWiki 1.14:
 * (bug 5101) Image from Commons doesn't show up when searched in Wikipedia search box
 * (bug 14609) User's namespaces to be searched default not updated after adding new namespace
 * Purge form uses valid XHTML and (bug 8992) uses $wgRequest instead of $_SERVER
+* (bug 12764) Special:LonelyPages shows transcluded pages
 
 === API changes in 1.14 ===
 
diff --git a/includes/specials/SpecialLonelypages.php b/includes/specials/SpecialLonelypages.php
index 5aafac7dd5..90da25fdc3 100644
--- a/includes/specials/SpecialLonelypages.php
+++ b/includes/specials/SpecialLonelypages.php
@@ -29,7 +29,7 @@ class LonelyPagesPage extends PageQueryPage {
 
 	function getSQL() {
 		$dbr = wfGetDB( DB_SLAVE );
-		list( $page, $pagelinks ) = $dbr->tableNamesN( 'page', 'pagelinks' );
+		list( $page, $pagelinks, $templatelinks ) = $dbr->tableNamesN( 'page', 'pagelinks', 'templatelinks' );
 
 		return
 		  "SELECT 'Lonelypages'  AS type,
@@ -39,9 +39,12 @@ class LonelyPagesPage extends PageQueryPage {
 		     FROM $page
 		LEFT JOIN $pagelinks
 		       ON page_namespace=pl_namespace AND page_title=pl_title
+		LEFT JOIN $templatelinks
+				ON page_namespace=tl_namespace AND page_title=tl_title
 		    WHERE pl_namespace IS NULL
 		      AND page_namespace=".NS_MAIN."
-		      AND page_is_redirect=0";
+		      AND page_is_redirect=0
+			  AND tl_namespace IS NULL";
 
 	}
 }
diff --git a/languages/messages/MessagesEn.php b/languages/messages/MessagesEn.php
index 998c59a6ca..39fb8c2cc8 100644
--- a/languages/messages/MessagesEn.php
+++ b/languages/messages/MessagesEn.php
@@ -2041,7 +2041,7 @@ Each row contains links to the first and second redirect, as well as the target
 'specialpage-empty'               => 'There are no results for this report.',
 'lonelypages'                     => 'Orphaned pages',
 'lonelypages-summary'             => '', # do not translate or duplicate this message to other languages
-'lonelypagestext'                 => 'The following pages are not linked from other pages in {{SITENAME}}.',
+'lonelypagestext'                 => 'The following pages are not linked from or transcluded into other pages in {{SITENAME}}.',
 'uncategorizedpages'              => 'Uncategorized pages',
 'uncategorizedpages-summary'      => '', # do not translate or duplicate this message to other languages
 'uncategorizedcategories'         => 'Uncategorized categories',