Cleanup to r43657, don't really need strlen() here.

diff --git a/includes/filerepo/ForeignAPIRepo.php b/includes/filerepo/ForeignAPIRepo.php
index b4b08e8..a6773e1 100644 (file)
--- a/includes/filerepo/ForeignAPIRepo.php
+++ b/includes/filerepo/ForeignAPIRepo.php
@@ -128,8 +128,7 @@ class ForeignAPIRepo extends FileRepo {
                        $foreignUrl = $this->getThumbUrl( $name, $width, $height );
                        
                        // We need the same filename as the remote one :)
-                       $fileName = ltrim( substr( $foreignUrl, strrpos( $foreignUrl, '/' ),
-                                                               strlen ( $foreignUrl ) ), '/' );
+                       $fileName = ltrim( substr( $foreignUrl, strrpos( $foreignUrl, '/' ) ), '/' );
                        $path = 'thumb/' . $this->getHashPath( $name ) . $name . "/";
                        if ( !is_dir($wgUploadDirectory . '/' . $path) ) {
                                wfMkdirParents($wgUploadDirectory . '/' . $path);