From dd3410c46e4150e74f91ae6f03df1851db1e3ff4 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Mon, 4 Sep 2017 18:04:28 +0200 Subject: [PATCH] SpecialUpload: Stop loading 'mediawiki.action.edit' The comment says it's for support, but that's not true anymore, as the CharInsert extension itself takes care of loading its script on Special:Upload (see CharInsert::onBeforePageDisplay()). Back in the day, this module included a lot more stuff related to the edit toolbar and such, so this might have been warranted, but there is nothing useful for uploading left in it anymore. It's very unintuitive that it would be loaded there; folks did not realize that it is the case and recent changes to the module started causing issues on Special:Upload. Bug: T174935 Change-Id: I11e886801a27f796e5a5935ec9c93b1329cc5b87 --- includes/specials/SpecialUpload.php | 1 - 1 file changed, 1 deletion(-) diff --git a/includes/specials/SpecialUpload.php b/includes/specials/SpecialUpload.php index 4cdc78f341..d0eb8e3742 100644 --- a/includes/specials/SpecialUpload.php +++ b/includes/specials/SpecialUpload.php @@ -1256,7 +1256,6 @@ class UploadForm extends HTMLForm { $out->addJsConfigVars( $scriptVars ); $out->addModules( [ - 'mediawiki.action.edit', // For support 'mediawiki.special.upload', // Extras for thumbnail and license preview. ] ); } -- 2.20.1