From 9270d4956dce471c7bd42aa5fec24ddd67d49873 Mon Sep 17 00:00:00 2001
From: Brion Vibber <brion@users.mediawiki.org>
Date: Sat, 13 Mar 2004 09:25:09 +0000
Subject: [PATCH] Minor enhanced recentchanges fix for Safari; put <a>s inside
 the two <span>s to prevent a rogue underline from being displayed under the
 arrow icons

---
 includes/Skin.php | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/includes/Skin.php b/includes/Skin.php
index 26205f268b..1d87bafd74 100644
--- a/includes/Skin.php
+++ b/includes/Skin.php
@@ -1842,11 +1842,10 @@ class Skin {
 		$rci = "RCI{$this->rcCacheIndex}" ;
 		$rcl = "RCL{$this->rcCacheIndex}" ;
 		$rcm = "RCM{$this->rcCacheIndex}" ;
-		$tl = "<a href='javascript:toggleVisibility(\"{$rci}\",\"{$rcm}\",\"{$rcl}\")'>" ;
+		$toggleLink = "javascript:toggleVisibility(\"{$rci}\",\"{$rcm}\",\"{$rcl}\")" ;
 		$arrowdir = $wgLang->isRTL() ? "l" : "r";
-		$tl .= "<span id='{$rcm}'><img src='{$wgUploadPath}/Arr_{$arrowdir}.png' width='12' height='12' border='0'></span>" ;
-		$tl .= "<span id='{$rcl}' style='display:none'><img src='{$wgUploadPath}/Arr_d.png' width='12' height='12' border='0'></span>" ;
-		$tl .= "</a>" ;
+		$tl  = "<span id='{$rcm}'><a href='$toggleLink'><img src='{$wgUploadPath}/Arr_{$arrowdir}.png' width='12' height='12' border='0' /></a></span>" ;
+		$tl .= "<span id='{$rcl}' style='display:none'><a href='$toggleLink'><img src='{$wgUploadPath}/Arr_d.png' width='12' height='12' border='0' /></a></span>" ;
 		$r .= $tl ;
 
 		# Main line
-- 
2.20.1