From 736b26c6c54b47ac61c7b1eccc21ac482396037c Mon Sep 17 00:00:00 2001 From: Prateek Saxena Date: Thu, 10 Sep 2015 01:01:45 +0530 Subject: [PATCH] mw.Upload.Dialog: Use getValidity instead of deprecated isValid Change-Id: Iada6aeb804108453104b15e4a78ab05af8c2717b --- .../src/mediawiki/mediawiki.Upload.Dialog.js | 20 +++++++------------ 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/resources/src/mediawiki/mediawiki.Upload.Dialog.js b/resources/src/mediawiki/mediawiki.Upload.Dialog.js index 96db7cc1d3..596e777560 100644 --- a/resources/src/mediawiki/mediawiki.Upload.Dialog.js +++ b/resources/src/mediawiki/mediawiki.Upload.Dialog.js @@ -437,19 +437,13 @@ // Validation function checkValidity() { - var validityPromises = [ - dialog.filenameWidget.isValid(), - dialog.descriptionWidget.isValid() - ]; - - $.when.apply( $, validityPromises ).done( function () { - var allValid, - values = Array.prototype.slice.apply( arguments ); - allValid = values.every( function ( value ) { - return value; - } ); - - dialog.actions.setAbilities( { save: allValid } ); + $.when( + dialog.filenameWidget.getValidity(), + dialog.descriptionWidget.getValidity() + ).done( function () { + dialog.actions.setAbilities( { save: true } ); + } ).fail( function () { + dialog.actions.setAbilities( { save: false } ); } ); } this.filenameWidget.on( 'change', checkValidity ); -- 2.20.1