From 620e909a97936ec27a91594f6f4e925657b9180d Mon Sep 17 00:00:00 2001 From: Tim Starling Date: Fri, 23 May 2008 09:00:08 +0000 Subject: [PATCH] Fixed sloppy usage of Database::selectField() in getPreviousRevisionID() and getNextRevisionID() --- includes/Title.php | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/includes/Title.php b/includes/Title.php index fa80f68a0b..0a227d5ad3 100644 --- a/includes/Title.php +++ b/includes/Title.php @@ -2932,8 +2932,13 @@ class Title { public function getPreviousRevisionID( $revision, $flags=0 ) { $db = ($flags & GAID_FOR_UPDATE) ? wfGetDB( DB_MASTER ) : wfGetDB( DB_SLAVE ); return $db->selectField( 'revision', 'rev_id', - 'rev_page=' . intval( $this->getArticleId($flags) ) . - ' AND rev_id<' . intval( $revision ) . ' ORDER BY rev_id DESC' ); + array( + 'rev_page' => $this->getArticleId($flags), + 'rev_id < ' . intval( $revision ) + ), + __METHOD__, + array( 'ORDER BY' => 'rev_id DESC' ) + ); } /** @@ -2946,8 +2951,13 @@ class Title { public function getNextRevisionID( $revision, $flags=0 ) { $db = ($flags & GAID_FOR_UPDATE) ? wfGetDB( DB_MASTER ) : wfGetDB( DB_SLAVE ); return $db->selectField( 'revision', 'rev_id', - 'rev_page=' . intval( $this->getArticleId($flags) ) . - ' AND rev_id>' . intval( $revision ) . ' ORDER BY rev_id' ); + array( + 'rev_page' => $this->getArticleId($flags), + 'rev_id > ' . intval( $revision ) + ), + __METHOD__, + array( 'ORDER BY' => 'rev_id' ) + ); } /** -- 2.20.1