From 3cfb43ee4f3f783516ec0a6a3cc787b909f0e450 Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Mon, 15 Aug 2011 21:04:11 +0000 Subject: [PATCH] Revert r94041: PHP Notice: Undefined index: SERVER_PROTOCOL in /home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/includes/Exception.php on line 185 This code appears to be trying to output something like 'HTTP/1.1 500 MediaWiki Error', but using $_SERVER['SERVER_PROTOCOL']. And it seems to output it on things that run in phpunit tests. Seems pretty broken? --- includes/Exception.php | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/includes/Exception.php b/includes/Exception.php index 10a409cbd1..5a972ca358 100644 --- a/includes/Exception.php +++ b/includes/Exception.php @@ -182,25 +182,12 @@ class MWException extends Exception { $wgOut->output(); } else { - header( $_SERVER['SERVER_PROTOCOL'] . ' 500 MediaWiki Error', true, 500 ); - header( 'Content-type: text/html; charset=UTF-8' ); - header( 'Cache-control: none' ); - header( 'Pragma: nocache' ); - $hookResult = $this->runHooks( get_class( $this ) . "Raw" ); if ( $hookResult ) { die( $hookResult ); } - echo " - - -" . $this->getPageTitle() . " - - -"; echo $this->getHTML(); - echo "\n"; die(1); } } -- 2.20.1