From 352edb42723f553a765b96d4ee9526c4ca8960f6 Mon Sep 17 00:00:00 2001 From: Prateek Saxena Date: Fri, 11 Sep 2015 11:17:37 +0530 Subject: [PATCH] mw.widgets.CategorySelector: Return {string}[] from getNewMenuItems' promise The object that was being returned only replicated the data with no added ease of use to the method that was consuming it. Change-Id: Ieabc6b12ea2ba28e3ef80e451dd2b9e8190ff1e8 --- .../mw.widgets.CategorySelector.js | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/resources/src/mediawiki.widgets/mw.widgets.CategorySelector.js b/resources/src/mediawiki.widgets/mw.widgets.CategorySelector.js index 09ac7b29bf..a15cd8707c 100644 --- a/resources/src/mediawiki.widgets/mw.widgets.CategorySelector.js +++ b/resources/src/mediawiki.widgets/mw.widgets.CategorySelector.js @@ -51,14 +51,14 @@ // Remove if items' data already exists filteredItems = items.filter( function ( item ) { - return existingItems.indexOf( item.data ) === -1; + return existingItems.indexOf( item ) === -1; } ); // Map to an array of OO.ui.MenuOptionWidgets filteredItems = filteredItems.map( function ( item ) { return new OO.ui.MenuOptionWidget( { - data: item.data, - label: item.label + data: item, + label: item } ); } ); @@ -89,12 +89,7 @@ return mw.Title.newFromText( name, catNsId ).getMainText(); } ); - deferred.resolve( categoryNames.map( function ( category ) { - return { - data: category, - label: category - }; - } ) ); + deferred.resolve( categoryNames ); } ); return deferred.promise(); -- 2.20.1