From 0ec4a015078011dba7650de2d655ae572dc2a87a Mon Sep 17 00:00:00 2001
From: Siebrand Mazeland <s.mazeland@xs4all.nl>
Date: Mon, 18 Nov 2013 05:25:43 +0100
Subject: [PATCH] Set visibility on class properties for *Dependency classes

Set visibility to private for properties that are not referenced outside
of the class itself, and when the class is not currently being subclassed.

Change-Id: I427c6de5a0a29b43cff755db0eb8a750db620173
---
 includes/cache/CacheDependency.php | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/includes/cache/CacheDependency.php b/includes/cache/CacheDependency.php
index 57d9af863f..27f136ae83 100644
--- a/includes/cache/CacheDependency.php
+++ b/includes/cache/CacheDependency.php
@@ -148,7 +148,8 @@ abstract class CacheDependency {
  * @ingroup Cache
  */
 class FileDependency extends CacheDependency {
-	var $filename, $timestamp;
+	private $filename;
+	private $timestamp;
 
 	/**
 	 * Create a file dependency
@@ -218,9 +219,10 @@ class FileDependency extends CacheDependency {
  * @ingroup Cache
  */
 class TitleDependency extends CacheDependency {
-	var $titleObj;
-	var $ns, $dbk;
-	var $touched;
+	private $titleObj;
+	private $ns;
+	private $dbk;
+	private $touched;
 
 	/**
 	 * Construct a title dependency
@@ -287,8 +289,8 @@ class TitleDependency extends CacheDependency {
  * @ingroup Cache
  */
 class TitleListDependency extends CacheDependency {
-	var $linkBatch;
-	var $timestamps;
+	private $linkBatch;
+	private $timestamps;
 
 	/**
 	 * Construct a dependency on a list of titles
@@ -393,7 +395,8 @@ class TitleListDependency extends CacheDependency {
  * @ingroup Cache
  */
 class GlobalDependency extends CacheDependency {
-	var $name, $value;
+	private $name;
+	private $value;
 
 	function __construct( $name ) {
 		$this->name = $name;
@@ -415,7 +418,8 @@ class GlobalDependency extends CacheDependency {
  * @ingroup Cache
  */
 class ConstantDependency extends CacheDependency {
-	var $name, $value;
+	private $name;
+	private $value;
 
 	function __construct( $name ) {
 		$this->name = $name;
-- 
2.20.1