From: Roan Kattouw Date: Tue, 28 Feb 2012 02:36:29 +0000 (+0000) Subject: Fix scoping in r112451: isReady was accidentally used as a global variable X-Git-Tag: 1.31.0-rc.0~24473 X-Git-Url: http://git.cyclocoop.org/%22.%24h.%22?a=commitdiff_plain;h=fd56227ac3aec7fe313f2479d078e14ce4a1260a;p=lhc%2Fweb%2Fwiklou.git Fix scoping in r112451: isReady was accidentally used as a global variable --- diff --git a/resources/mediawiki.action/mediawiki.action.edit.js b/resources/mediawiki.action/mediawiki.action.edit.js index c5e38fffa6..6b10485253 100644 --- a/resources/mediawiki.action/mediawiki.action.edit.js +++ b/resources/mediawiki.action/mediawiki.action.edit.js @@ -9,7 +9,7 @@ // If you want to add buttons, use // mw.toolbar.addButton( imageFile, speedTip, tagOpen, tagClose, sampleText, imageId, selectText ); addButton : function() { - if ( isReady ) { + if ( this.isReady ) { this.insertButton.apply( this, arguments ); } else { this.buttons.push( [].slice.call( arguments ) ); @@ -48,7 +48,7 @@ onReady : function() { this.$toolbar = $( '#toolbar' ); - isReady = true; + this.isReady = true; // Legacy // Merge buttons from mwCustomEditButtons var buttons = [].concat( this.buttons, window.mwCustomEditButtons );