From: Amir E. Aharoni <amir.aharoni@mail.huji.ac.il>
Date: Fri, 7 Aug 2015 14:35:05 +0000 (+0300)
Subject: Fix the display of the libraries in Special:Version for RTL wikis
X-Git-Tag: 1.31.0-rc.0~10474^2
X-Git-Url: http://git.cyclocoop.org/%22.%24h.%22?a=commitdiff_plain;h=e137f50536dd96f3cb4e470e8e3add76c473502a;p=lhc%2Fweb%2Fwiklou.git

Fix the display of the libraries in Special:Version for RTL wikis

Bug: T108325
Change-Id: I3c9a675fa7330d46090a64c003bcaf66ddf4260f
---

diff --git a/includes/specials/SpecialVersion.php b/includes/specials/SpecialVersion.php
index 4fb67727cf..e598f0bfa9 100644
--- a/includes/specials/SpecialVersion.php
+++ b/includes/specials/SpecialVersion.php
@@ -541,6 +541,10 @@ class SpecialVersion extends SpecialPage {
 				return $arr['name'];
 			}, $info['authors'] );
 			$authors = $this->listAuthors( $authors, false, "$IP/vendor/$name" );
+
+			// We can safely assume that the libraries' names and descriptions
+			// are written in English and aren't going to be translated,
+			// so set appropriate lang and dir attributes
 			$out .= Html::openElement( 'tr' )
 				. Html::rawElement(
 					'td',
@@ -551,9 +555,9 @@ class SpecialVersion extends SpecialPage {
 						array( 'class' => 'mw-version-library-name' )
 					)
 				)
-				. Html::element( 'td', array(), $info['version'] )
-				. Html::element( 'td', array(), $this->listToText( $info['licenses'] ) )
-				. Html::element( 'td', array(), $info['description'] )
+				. Html::element( 'td', array( 'dir' => 'auto' ), $info['version'] )
+				. Html::element( 'td', array( 'dir' => 'auto' ), $this->listToText( $info['licenses'] ) )
+				. Html::element( 'td', array( 'lang' => 'en', 'dir' => 'ltr' ), $info['description'] )
 				. Html::rawElement( 'td', array(), $authors )
 				. Html::closeElement( 'tr' );
 		}