From: Tim Starling <tstarling@wikimedia.org>
Date: Tue, 14 Nov 2017 09:33:46 +0000 (+1100)
Subject: Do not limit filesize when running a maintenance script
X-Git-Tag: 1.31.0-rc.0~1527^2
X-Git-Url: http://git.cyclocoop.org/%22.%24h.%22?a=commitdiff_plain;h=b0af2fbe421144966de9b466a9c97a1dbeda8ec5;p=lhc%2Fweb%2Fwiklou.git

Do not limit filesize when running a maintenance script

Starting HHVM may require writing very large files, so it can't have the
same file size limit as image scaling etc. The memory limit was already
disabled for much the same reason.

This is the only caller of wfShellWikiCmd() in core which proceeds to
call wfShellExec().

Bug: T145819
Change-Id: I1ab35edbbdb63c2d6f5f578cba2547be79a965ef
---

diff --git a/includes/SiteConfiguration.php b/includes/SiteConfiguration.php
index 7a01a6575b..2d1d961dec 100644
--- a/includes/SiteConfiguration.php
+++ b/includes/SiteConfiguration.php
@@ -556,7 +556,7 @@ class SiteConfiguration {
 				]
 			);
 			// ulimit5.sh breaks this call
-			$data = trim( wfShellExec( $cmd, $retVal, [], [ 'memory' => 0 ] ) );
+			$data = trim( wfShellExec( $cmd, $retVal, [], [ 'memory' => 0, 'filesize' => 0 ] ) );
 			if ( $retVal != 0 || !strlen( $data ) ) {
 				throw new MWException( "Failed to run getConfiguration.php." );
 			}