From: Greg Sabino Mullane <greg@users.mediawiki.org>
Date: Fri, 22 Jun 2007 22:00:58 +0000 (+0000)
Subject: getLag() returns false, not 0. Add reminder about future code refactoring.
X-Git-Tag: 1.31.0-rc.0~52435
X-Git-Url: http://git.cyclocoop.org/%22.%24h.%22?a=commitdiff_plain;h=85ae757734dc370e87fff120ff8a31fd5dbe4bc2;p=lhc%2Fweb%2Fwiklou.git

getLag() returns false, not 0. Add reminder about future code refactoring.
---

diff --git a/includes/DatabasePostgres.php b/includes/DatabasePostgres.php
index ef20292a5d..4b1ba1c584 100644
--- a/includes/DatabasePostgres.php
+++ b/includes/DatabasePostgres.php
@@ -155,6 +155,7 @@ class DatabasePostgres extends Database {
 
 		$this->mOpened = true;
 		## If this is the initial connection, setup the schema stuff and possibly create the user
+		## TODO: Move this out of open()
 		if (defined('MEDIAWIKI_INSTALL')) {
 			global $wgDBname, $wgDBuser, $wgDBpassword, $wgDBsuperuser, $wgDBmwschema,
 				$wgDBts2schema;
@@ -1177,11 +1178,10 @@ END;
 	/**
 	 * How lagged is this slave?
 	 *
-	 * @return int
 	 */
 	public function getLag() {
 		# Not implemented for PostgreSQL
-		return 0;
+		return false;
 	}
 
 } // end DatabasePostgres class