From f0f3e77dd370681e054b121ac32cb825c7441b13 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Tue, 12 Feb 2019 10:52:31 -0800 Subject: [PATCH] rdbms: avoid duplicate spammy logging in LoadBalancer::getRandomNonLagged This is already logged in LoadMonitor in getServerStates() in a less spammy way (due to APC caching of server states). Bug: T215611 Change-Id: Id70fdfa62eff9cb6446deea5e197f4c0af4928aa --- includes/libs/rdbms/loadbalancer/LoadBalancer.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/libs/rdbms/loadbalancer/LoadBalancer.php b/includes/libs/rdbms/loadbalancer/LoadBalancer.php index b3f9efffab..f2e4e3d7d1 100644 --- a/includes/libs/rdbms/loadbalancer/LoadBalancer.php +++ b/includes/libs/rdbms/loadbalancer/LoadBalancer.php @@ -305,7 +305,7 @@ class LoadBalancer implements ILoadBalancer { $host = $this->getServerName( $i ); if ( $lag === false && !is_infinite( $maxServerLag ) ) { - $this->replLogger->error( + $this->replLogger->debug( __METHOD__ . ": server {host} is not replicating?", [ 'host' => $host ] ); unset( $loads[$i] ); -- 2.20.1