From e7d0bae982c7a1593603ef5bb1e8cc0aa0d2030c Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Thu, 18 Sep 2008 17:01:36 +0000 Subject: [PATCH] Cleanup for r40944: * Break up giant long incomprehensible line * Use SpecialPage::getTitleFor() rather than Title::newFromText() so we get proper localization of special page name * No need to pass 'block' to Special:Log twice; just put it in the query to match actual paging behavior * HTML-escape the blocklog-fulllog message for good measure * No need to pass 'known' option to linker -- it knows that Special: pages are good --- includes/specials/SpecialBlockip.php | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/includes/specials/SpecialBlockip.php b/includes/specials/SpecialBlockip.php index 01afac1b86..e6931cb9d0 100644 --- a/includes/specials/SpecialBlockip.php +++ b/includes/specials/SpecialBlockip.php @@ -422,7 +422,13 @@ class IPBlockForm { $out->addHtml( Xml::element( 'h2', NULL, LogPage::logName( 'block' ) ) ); $count = LogEventsList::showLogExtract( $out, 'block', $title->getPrefixedText(), '', 10 ); if($count > 10){ - $out->addHtml( $wgUser->getSkin()->link(Title::newFromText('Special:Log/block'), wfMsg('blocklog-fulllog'), array(), array('type' => 'block', 'page' => $title->getPrefixedText()), array('known') ) ); + $out->addHtml( $wgUser->getSkin()->link( + SpecialPage::getTitleFor( 'Log' ), + wfMsgHtml( 'blocklog-fulllog' ), + array(), + array( + 'type' => 'block', + 'page' => $title->getPrefixedText() ) ) ); } } -- 2.20.1