From 7d11e65dcc3382402ab91ec77cdfdf07cc924c5c Mon Sep 17 00:00:00 2001 From: Siebrand Mazeland Date: Sun, 17 Nov 2013 23:18:01 +0100 Subject: [PATCH] Declare visibility on class properties of LCStore* classes No direct references found in core or extensions outside of the classes themselves. None of these are subclassed, so set all of them to private. Change-Id: Id599c0830c1e6d3679c7ae55147f4444f8252987 --- includes/cache/LocalisationCache.php | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/includes/cache/LocalisationCache.php b/includes/cache/LocalisationCache.php index 2c9d8ae364..7d029bcd6f 100644 --- a/includes/cache/LocalisationCache.php +++ b/includes/cache/LocalisationCache.php @@ -1022,8 +1022,8 @@ interface LCStore { * (See ObjectCache.php) */ class LCStoreAccel implements LCStore { - var $currentLang; - var $keys; + private $currentLang; + private $keys; public function __construct() { $this->cache = wfGetCache( CACHE_ACCEL ); @@ -1071,15 +1071,15 @@ class LCStoreAccel implements LCStore { * This will work on any MediaWiki installation. */ class LCStoreDB implements LCStore { - var $currentLang; - var $writesDone = false; + private $currentLang; + private $writesDone = false; /** * @var DatabaseBase */ - var $dbw; - var $batch; - var $readOnly = false; + private $dbw; + private $batch; + private $readOnly = false; public function get( $code, $key ) { if ( $this->writesDone ) { @@ -1174,7 +1174,10 @@ class LCStoreDB implements LCStore { * See Cdb.php and http://cr.yp.to/cdb.html */ class LCStoreCDB implements LCStore { - var $readers, $writer, $currentLang, $directory; + private $readers; + private $writer; + private $currentLang; + private $directory; function __construct( $conf = array() ) { global $wgCacheDirectory; -- 2.20.1