From: RazeSoldier Date: Thu, 23 Aug 2018 16:18:07 +0000 (+0800) Subject: Use "break" instead of "continue" X-Git-Tag: 1.34.0-rc.0~4263^2 X-Git-Url: http://git.cyclocoop.org/%22.%20generer_url_ecrire%28%22sites_tous%22%2C%22%22%29.%20%22?a=commitdiff_plain;h=24ffbd9bd182944daa8b12244b729562cd5f50db;p=lhc%2Fweb%2Fwiklou.git Use "break" instead of "continue" "continue" statements are equivalent to "break". In PHP 7.3, will generate a warning. Bug: T200595 Change-Id: I244ecb2e1ce5a76295f014fb1becd8d263196846 --- diff --git a/includes/json/FormatJson.php b/includes/json/FormatJson.php index 1ab17a06f5..fbcb3bd3b8 100644 --- a/includes/json/FormatJson.php +++ b/includes/json/FormatJson.php @@ -271,7 +271,7 @@ class FormatJson { $lookAhead = ( $idx + 1 < $maxLen ) ? $str[$idx + 1] : ''; $lookBehind = ( $idx - 1 >= 0 ) ? $str[$idx - 1] : ''; if ( $inString ) { - continue; + break; } elseif ( !$inComment && ( $lookAhead === '/' || $lookAhead === '*' ) diff --git a/languages/LanguageConverter.php b/languages/LanguageConverter.php index c098518a96..cb0f66f1b7 100644 --- a/languages/LanguageConverter.php +++ b/languages/LanguageConverter.php @@ -773,7 +773,7 @@ class LanguageConverter { $warningDone = true; } $startPos += 2; - continue; + break; } // Recursively parse another rule $inner .= $this->recursiveConvertRule( $text, $variant, $startPos, $depth + 1 );