Revert r38068 "SpecialMovepageBeforeMove hook from Wikia codebase - allows extensions...

This passes a MovePageForm, which seems unwise. It won't apply to the edit API, and generally seems like a weak interface -- an internal UI object is passed instead of specific information, leaving it unstable to future changes.

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index e006157..0f53430 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -28,8 +28,6 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 
 * (bug 8068) New __INDEX__ and __NOINDEX__ magic words allow user control of
   search engine indexing on a per-article basis.
-* Added SpecialMovepageBeforeMove hook to allow extensions to interfere with
-  page moves (useful for blacklist-type extensions, for example)
 
 === Bug fixes in 1.14 ===
 

diff --git a/docs/hooks.txt b/docs/hooks.txt
index cbd008c..2ef8cc9 100644 (file)
--- a/docs/hooks.txt
+++ b/docs/hooks.txt
@@ -1131,9 +1131,6 @@ $movePage: MovePageForm object
 $oldTitle: old title (object)
 $newTitle: new title (object)
 
-'SpecialMovepageBeforeMove': Called before moving a page
-&$movePage: MovePageForm object
-
 'SpecialPageExecuteAfterPage': called after executing a special page
 Warning: Not all the special pages call this hook
 $specialPage: SpecialPage object

diff --git a/includes/specials/SpecialMovepage.php b/includes/specials/SpecialMovepage.php
index 5cda361..9f8bd3e 100644 (file)
--- a/includes/specials/SpecialMovepage.php
+++ b/includes/specials/SpecialMovepage.php
@@ -264,10 +264,6 @@ class MovePageForm {
                        return;
                }
 
-               if( ! wfRunHooks( 'SpecialMovepageBeforeMove', array(&$this) ) ) {
-                       return;
-               }
-
                $ot = $this->oldTitle;
                $nt = $this->newTitle;