Revert r90483, if tesla has problems, it should get proper permissions to the affecte...
authorPlatonides <platonides@users.mediawiki.org>
Tue, 21 Jun 2011 15:06:59 +0000 (15:06 +0000)
committerPlatonides <platonides@users.mediawiki.org>
Tue, 21 Jun 2011 15:06:59 +0000 (15:06 +0000)
commitf5dec1eefaf593fb424178ce6f4d9a979c862ee0
tree934a0a595c3457e20e84d3b8ee6dfb37fe179ef4
parent3764b63a5d6fd434b8d2d32ae5fb0f35e952f100
Revert r90483, if tesla has problems, it should get proper permissions to the affected folders (or change the test to use a temp folder)
The test was not consistent, since first time it would use the svn file, which renames it... and on next run it would be missing!
I added the '.' to the unlik() step so it properly cleans up. Opened bug 29512 for the strange UploadStash behavior.

However, although it passes now most of the times, it sometimes fails with the strange exception:
Only variables should be passed by reference

phase3/includes/upload/UploadStash.php:143
phase3/tests/phpunit/includes/upload/UploadStashTest.php:22
phase3/tests/phpunit/MediaWikiTestCase.php:64
phase3/tests/phpunit/MediaWikiPHPUnitCommand.php:20
phase3/tests/phpunit/phpunit.php:60
tests/phpunit/includes/upload/UploadStashTest.php
tests/phpunit/includes/upload/bug29408 [deleted file]