From 33c1b6042f73b601c245a32f9dd66e3f9f131357 Mon Sep 17 00:00:00 2001 From: MatmaRex Date: Fri, 5 Oct 2012 20:09:18 +0200 Subject: [PATCH] don't overwrite $item['single-id'] in makeListItem in SkinTemplate This makes it possible to use it with links that are supposed to use custom ids, but stock tooltips. Change-Id: I2e3ed92bd23dbaebf0c404979343b463c8c357cf --- includes/SkinTemplate.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/SkinTemplate.php b/includes/SkinTemplate.php index c6547473cb..f8f29bc86d 100644 --- a/includes/SkinTemplate.php +++ b/includes/SkinTemplate.php @@ -1748,7 +1748,7 @@ abstract class BaseTemplate extends QuickTemplate { foreach ( array( 'id', 'class', 'active', 'tag' ) as $k ) { unset( $link[$k] ); } - if ( isset( $item['id'] ) ) { + if ( isset( $item['id'] ) && !isset( $item['single-id'] ) ) { // The id goes on the
  • not on the for single links // but makeSidebarLink still needs to know what id to use when // generating tooltips and accesskeys. -- 2.20.1