jenkins-bot [Wed, 28 Aug 2019 12:56:25 +0000 (12:56 +0000)]
Merge "skins: Skin::getSkinNameMessages() method is now deprecated"
jenkins-bot [Wed, 28 Aug 2019 12:56:19 +0000 (12:56 +0000)]
Merge "skins: Remove use of deprecated MessageCache::singleton()"
Bartosz Dziewoński [Wed, 28 Aug 2019 11:47:03 +0000 (13:47 +0200)]
Re-add missing messages in languages/i18n/exif/qqq.json
Added in
7c68604e4c5e3f61884d529a37a2878c3155d343, incorrectly removed
by translation updater in
7881d44f690cc1e7415bb6cbaedc02d586a64498?
Checks are failing because of this.
Change-Id: I264f0f1cf3dcd69bbf8d43ad057a81e3f39ed623
D3r1ck01 [Wed, 28 Aug 2019 09:46:06 +0000 (09:46 +0000)]
Merge "Localisation updates from https://translatewiki.net."
jenkins-bot [Wed, 28 Aug 2019 09:19:14 +0000 (09:19 +0000)]
Merge "Move Title::isNamespaceProtected() to PermissionManager."
jenkins-bot [Wed, 28 Aug 2019 09:02:59 +0000 (09:02 +0000)]
Merge "Fix entites typos"
jenkins-bot [Wed, 28 Aug 2019 08:44:18 +0000 (08:44 +0000)]
Merge "LockManagerGroup tweaks"
jenkins-bot [Wed, 28 Aug 2019 08:44:12 +0000 (08:44 +0000)]
Merge "profiler: Rename Profile::setTemplated to Profile::setAllowOutput"
jenkins-bot [Wed, 28 Aug 2019 08:32:06 +0000 (08:32 +0000)]
Merge "Document that img_description_id is a comment id"
Aryeh Gregor [Thu, 15 Aug 2019 18:07:36 +0000 (21:07 +0300)]
LockManagerGroup tweaks
One small change that was supposed to be in
5a6c18a0863 but didn't make
it into the patch version that got merged, and removal of some long-dead
code.
phan objected to the use of new $class without being explicitly
reassured that $class is, in fact, a string. I don't know why.
Change-Id: Ifa00c59ab4464109414f21db37e3a6db21decdf3
Translation updater bot [Wed, 28 Aug 2019 07:31:09 +0000 (09:31 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I8380b27a31ae89200aa7e7ccf38424acb244e288
jenkins-bot [Wed, 28 Aug 2019 06:57:34 +0000 (06:57 +0000)]
Merge "Let Html::element do the HTML encoding"
jenkins-bot [Wed, 28 Aug 2019 06:57:28 +0000 (06:57 +0000)]
Merge "parserTests: Add parser test with filename containing single quotes"
Zoranzoki21 [Wed, 28 Aug 2019 04:36:04 +0000 (06:36 +0200)]
Fix entites typos
Bug: T201491
Change-Id: I241fda87b0e53e804f6bdd48eb975a79e9f176d2
jenkins-bot [Wed, 28 Aug 2019 04:29:38 +0000 (04:29 +0000)]
Merge "Revert actor changes to populateLogSearch.php"
jenkins-bot [Wed, 28 Aug 2019 04:29:31 +0000 (04:29 +0000)]
Merge "MessageCache: Add STRAIGHT_JOIN to avoid planner oddness"
jenkins-bot [Wed, 28 Aug 2019 01:11:43 +0000 (01:11 +0000)]
Merge "resources: Also add jQuery Migrate to foreign-resources.yaml"
Timo Tijhof [Wed, 28 Aug 2019 00:20:47 +0000 (01:20 +0100)]
profiler: Rename Profile::setTemplated to Profile::setAllowOutput
This is set from three places:
1) SkinTemplate.php, 2) Maintenance.php, and 3) load.php.
These last two are very much *not* HTML-templated output.
Rename these this method pair to getAllowOutput/setAllowOutput instead,
which is less confusing going forward. No known callers outside of
core (updated in the next commit), but I'll keep compat for one
release cycle just in case.
Change-Id: I828f95332dca3c6766b2b485ffb71762542b42d7
jenkins-bot [Tue, 27 Aug 2019 23:28:10 +0000 (23:28 +0000)]
Merge "Follow-up
225b462: Remove 'apisandbox-api-disabled' i18n too"
Timo Tijhof [Tue, 27 Aug 2019 15:51:54 +0000 (16:51 +0100)]
MessageCache: Increase APC 'messages-big' expiry from 1min to 1h
Bug: T218207
Change-Id: Ic5d2a556912e2a16ee899eec3a0670f00dec9a8c
jenkins-bot [Tue, 27 Aug 2019 22:48:04 +0000 (22:48 +0000)]
Merge "mw.Uri: Add support for array parameters with explicit indexes"
James D. Forrester [Tue, 27 Aug 2019 22:47:18 +0000 (15:47 -0700)]
Follow-up
225b462: Remove 'apisandbox-api-disabled' i18n too
Initially removed, lost in rebase.
Bug: T224429
Change-Id: Ibb9c0ab1dcd2b3119cda570552d54ff866677d95
Derick Alangi [Tue, 27 Aug 2019 22:04:22 +0000 (23:04 +0100)]
skins: Skin::getSkinNameMessages() method is now deprecated
No longer used per CS below;
https://codesearch.wmflabs.org/search/?q=getSkinNameMessages&i=nope&files=&repos=
Change-Id: I2be9f417444024c3612db3e771a385ce5ed12ec4
Derick Alangi [Tue, 27 Aug 2019 22:01:04 +0000 (23:01 +0100)]
skins: Remove use of deprecated MessageCache::singleton()
Change-Id: I1c6d3874dd78023d743a418039c23adb55578f98
jenkins-bot [Tue, 27 Aug 2019 22:21:57 +0000 (22:21 +0000)]
Merge "Recognize exif values for Apple iOS photo modes"
Bartosz Dziewoński [Tue, 27 Aug 2019 20:14:01 +0000 (22:14 +0200)]
mw.Uri: Add support for array parameters with explicit indexes
When the new 'arrayParams' option is set, query strings like
`&foo[0]=a&foo[1]=b` will be parsed as a single parameter `foo`
containing an array, rather than two separate parameters.
The new option also affects the behavior of array parameters like
`&foo[]=a&foo[]=b`, which will be parsed as a parameter named `foo`
rather than `foo[]`, and disables array handling for parameters that
don't contain an array index at the end.
Unlike in PHP, this does not handle associative or multi-dimensional
arrays, but that may be improved in the future.
Bug: T231382
Change-Id: I48d4bb3fdf0ea7f5eb133c59bf63651ba356fc42
Reedy [Tue, 27 Aug 2019 07:40:29 +0000 (08:40 +0100)]
Revert "Output more MW version info in update.php"
Left changes to SpecialVersion.php
This reverts commit
e73328601d51674e8fef89c3db12b30ceafd702f.
Bug: T227489
Change-Id: I673b6a6abb73e93d2253fc554f94ef9c833dae0c
Derk-Jan Hartman [Tue, 27 Aug 2019 20:31:43 +0000 (22:31 +0200)]
Recognize exif values for Apple iOS photo modes
CustomRendered value 2-8 are used by Apple to indicate the processing
modes used like HDR, Portrait and Panorama.
Bug: T231385
Change-Id: I767a81a8bebdf25c230b104d35236a4b38cbe4ed
jenkins-bot [Tue, 27 Aug 2019 19:49:54 +0000 (19:49 +0000)]
Merge "Special:NewFiles: Drop 'newbies' feature"
jenkins-bot [Tue, 27 Aug 2019 19:45:27 +0000 (19:45 +0000)]
Merge "Special:Contributions: Drop 'newbies' feature"
James D. Forrester [Fri, 2 Aug 2019 19:32:23 +0000 (12:32 -0700)]
Special:NewFiles: Drop 'newbies' feature
Change-Id: I946d7027db0fec90d8af68f9370fdd7fe5fd61e0
James D. Forrester [Fri, 2 Aug 2019 19:06:31 +0000 (12:06 -0700)]
Special:Contributions: Drop 'newbies' feature
This old, low-value feature has been replaced by the much more featureful
functionality on RecentChanges, which has the added advantage of using an
efficient query.
Bug: T220447
Change-Id: I2e6e12b2ad627ecc346883878811ec0164cd03da
jenkins-bot [Tue, 27 Aug 2019 18:35:09 +0000 (18:35 +0000)]
Merge "WebStart: Avoid DB or uselang for nonwrite-api-promise-error message"
jenkins-bot [Tue, 27 Aug 2019 18:33:05 +0000 (18:33 +0000)]
Merge "MessageCache: Remove $wgMsgCacheExpiry configuration var"
jenkins-bot [Tue, 27 Aug 2019 18:31:18 +0000 (18:31 +0000)]
Merge "MessageCache: Minor wgMsgCacheExpiry doc fix, and clear constant access"
jenkins-bot [Tue, 27 Aug 2019 18:25:54 +0000 (18:25 +0000)]
Merge "BadFileLookup::isBadFile() expects null, not false"
Aryeh Gregor [Tue, 27 Aug 2019 17:21:28 +0000 (20:21 +0300)]
BadFileLookup::isBadFile() expects null, not false
This deviation in behavior from wfIsBadImage() is accounted for in that
function, but I didn't account for it when changing callers to use the
service.
Bug: T231340
Bug: T231353
Change-Id: Iddf177770fb1763ed295d694ed6bab441ea9ab73
Timo Tijhof [Tue, 27 Aug 2019 15:35:49 +0000 (16:35 +0100)]
MessageCache: Remove $wgMsgCacheExpiry configuration var
This variable has never been set to anything other than the default value of
24 hours as introduced in 2003 (r2203, r2204; or
036ff960ce,
edf6b38626).
The variable has never changed in core, it's not overridden at WMF,
and MessageCache is not constructed anywhere other than ServiceWiring.php
anywhere in repos on Wikimedia Gerrit, indexed by MediaWiki Codesearch,
or any GitHub-hosted repository (incl Wikia repos and WikiHow mirrors).
I've also checked all GitHub-hosted repos for boilerplates and/or public
settings files from devs or prod, and couldn't find any example of
this being overridden (after filtering out copies of the core files
themselves). Rather than having to support potentially hard-to-predict
interactions betweeen caching layers by checking its state, make it
a constant so we can code reason about it more easily.
Change-Id: Ie2e139001aae3ac54b509d94a3d917bb408eaca0
jenkins-bot [Tue, 27 Aug 2019 17:23:05 +0000 (17:23 +0000)]
Merge "Remove hard deprecation of PasswordPolicyChecks::checkPopularPasswordBlacklist"
jenkins-bot [Tue, 27 Aug 2019 17:04:14 +0000 (17:04 +0000)]
Merge "Restore some previous constructor calls"
Reedy [Tue, 27 Aug 2019 16:53:27 +0000 (17:53 +0100)]
Remove hard deprecation of PasswordPolicyChecks::checkPopularPasswordBlacklist
It's causing quite a bit of WMF log spam because it's still used in wmf-config
Partial revert of I4c90e361b7538efeb0c5efa7ca61aed2e468591c
Change-Id: I7d1282e4260e7a42bee35b81d77470eb40dea818
jenkins-bot [Tue, 27 Aug 2019 16:29:10 +0000 (16:29 +0000)]
Merge "Avoid PHP warning due to bogus second tideways_xhprof_enable() argument"
Timo Tijhof [Tue, 27 Aug 2019 15:26:20 +0000 (16:26 +0100)]
MessageCache: Minor wgMsgCacheExpiry doc fix, and clear constant access
The class used is typed against BagOStuff so access the constant
from there instead.
Bug: T218207
Change-Id: Ie22d6aa5877fb5e8e2ae0b3be87f4b28f45ad763
jenkins-bot [Tue, 27 Aug 2019 16:21:21 +0000 (16:21 +0000)]
Merge "rdbms: remove unused $fulltextEnabled field from DatabaseSqlite"
jenkins-bot [Tue, 27 Aug 2019 15:53:34 +0000 (15:53 +0000)]
Merge "Hard deprecate new SearchResult() and introduce RevisionSearchResult"
jenkins-bot [Tue, 27 Aug 2019 15:41:15 +0000 (15:41 +0000)]
Merge "LockManagerGroupFactory to replace singletons"
jenkins-bot [Tue, 27 Aug 2019 15:34:43 +0000 (15:34 +0000)]
Merge "Use correct metadata when adding exact query match"
David Causse [Thu, 1 Aug 2019 20:38:46 +0000 (22:38 +0200)]
Hard deprecate new SearchResult() and introduce RevisionSearchResult
Transitional step for the transformation of SearchResult into an
abstract base class:
- RevisionSearchResult is introduced to behave like SearchResult
- methods are currently shared between RevisionSearchResult and
SearchResult in the RevisionSearchResultTrait
Bug: T228626
Change-Id: I13d132de50f6c66086b7f9055d036f2e76667b27
jenkins-bot [Tue, 27 Aug 2019 15:26:47 +0000 (15:26 +0000)]
Merge "mail: Avoid use of global state and use MediaWiki services DI"
jenkins-bot [Tue, 27 Aug 2019 15:22:40 +0000 (15:22 +0000)]
Merge "Use UserIdentity::isRegistered instead of User::isAnon in BlockManager"
jenkins-bot [Tue, 27 Aug 2019 14:30:12 +0000 (14:30 +0000)]
Merge "Use ->getTitle() instead of ->mTitle to get the title from Parser"
Derick Alangi [Mon, 26 Aug 2019 13:03:35 +0000 (14:03 +0100)]
mail: Avoid use of global state and use MediaWiki services DI
Change-Id: If335cb6a220ebc5eb7487e51ee097f9d2afa0d2d
jenkins-bot [Tue, 27 Aug 2019 13:13:43 +0000 (13:13 +0000)]
Merge "wdio: Switch to dots reporter for brevity"
Ed Sanders [Tue, 27 Aug 2019 11:15:54 +0000 (12:15 +0100)]
Use correct metadata when adding exact query match
Bug: T230819
Change-Id: If85fa1cbad1f3ef9ab2cb0da966a98aafffad05e
Aryeh Gregor [Tue, 27 Aug 2019 10:32:47 +0000 (13:32 +0300)]
Document that img_description_id is a comment id
It took me a bit of time to figure this out, and it seems non-obvious,
so I thought a comment would be appropriate.
Change-Id: Ibe7220ed8f9355e3025c257057754eb4d72384b9
Fomafix [Tue, 27 Aug 2019 10:29:39 +0000 (12:29 +0200)]
Use ->getTitle() instead of ->mTitle to get the title from Parser
This allows to make mTitle a private property.
Change-Id: If953546cf4bb0324e4ae41d2195254c37c0ad3b4
Aryeh Gregor [Thu, 15 Aug 2019 18:07:36 +0000 (21:07 +0300)]
LockManagerGroupFactory to replace singletons
100% test coverage of code that appears to be working and used, in both
LockManagerGroupFactory and also LockManagerGroup. Where possible I
wrote it as unit tests. One preexisting code path seems to be broken and
I marked the test as skipped. Two methods look unused and perhaps not
especially helpful, so I didn't write tests for them yet in case we want
to just get rid of them instead.
Change-Id: Iaa7354f31c451b87773468609c674a3bf1d4382f
Translation updater bot [Tue, 27 Aug 2019 08:14:39 +0000 (10:14 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I52497a0a7f1d15ca6643556e3967d9302572a40f
Matěj Suchánek [Tue, 27 Aug 2019 07:56:38 +0000 (09:56 +0200)]
Restore some previous constructor calls
Follow-up to If07f10075a51fbbe9de24464cb6844faaad94780
and I082152b64141f1a9a4085bba23fe81a99ec8d886.
It will make getRequest use the provided context again.
Change-Id: I60b2598edcb0daed076876482e1e9d6cbf815eb2
Thalia [Mon, 26 Aug 2019 23:21:04 +0000 (00:21 +0100)]
Use UserIdentity::isRegistered instead of User::isAnon in BlockManager
BlockManager::getBlockFromCookieValue accepts a UserIdentity, so should
only call methods defined in that interface.
Change-Id: If30df15b800cceee0ad052a2e0524df8b28d9901
jenkins-bot [Tue, 27 Aug 2019 05:09:07 +0000 (05:09 +0000)]
Merge "TablePager: put parent construct call back at end"
Elliott Eggleston [Tue, 27 Aug 2019 03:42:07 +0000 (22:42 -0500)]
TablePager: put parent construct call back at end
Restores position of parent constructor call, changed in commit
I082152b64141f1a.
The parent constructor calls getIndexField(), which depends on the
mSort value already being set.
Bug: T231261
Change-Id: If07f10075a51fbbe9de24464cb6844faaad94780
jenkins-bot [Tue, 27 Aug 2019 03:03:42 +0000 (03:03 +0000)]
Merge "Add more information to exception thrown"
Max Semenik [Tue, 27 Aug 2019 02:03:09 +0000 (19:03 -0700)]
Add more information to exception thrown
It's not just about the preference name, because current user's properties
are used for validation too.
Bug: T231029
Change-Id: I268b959017bb0dce2b4295d5302a544bfa3513eb
jenkins-bot [Tue, 27 Aug 2019 01:19:16 +0000 (01:19 +0000)]
Merge "Add help link to Special:NewSection"
jenkins-bot [Tue, 27 Aug 2019 00:32:25 +0000 (00:32 +0000)]
Merge "Add SearchResultTrait"
DannyS712 [Tue, 27 Aug 2019 00:24:23 +0000 (00:24 +0000)]
Add help link to Special:NewSection
Bug: T231260
Change-Id: I856f5256b45c3961186f27c3b0b190998e297c1a
jenkins-bot [Mon, 26 Aug 2019 23:36:44 +0000 (23:36 +0000)]
Merge "Setup: Remove scopedProfileIn() calls"
jenkins-bot [Mon, 26 Aug 2019 23:36:36 +0000 (23:36 +0000)]
Merge "REST: call MediaWiki::preOutputCommit and doPostOutputShutdown"
jenkins-bot [Mon, 26 Aug 2019 23:30:12 +0000 (23:30 +0000)]
Merge "SpecialNewSection: Fix handling of 'preloadparams'"
jenkins-bot [Mon, 26 Aug 2019 23:14:38 +0000 (23:14 +0000)]
Merge "Clean up LinkRenderer usage in IndexPager and extensions"
jenkins-bot [Mon, 26 Aug 2019 22:00:46 +0000 (22:00 +0000)]
Merge "Revert "Make LocalisationCache a service""
jenkins-bot [Mon, 26 Aug 2019 22:00:39 +0000 (22:00 +0000)]
Merge "objectcache: SqlBagOStuff cleanups for sqlite and postgres"
jenkins-bot [Mon, 26 Aug 2019 21:23:28 +0000 (21:23 +0000)]
Merge "rdbms: simplify comment in LoadBalancer::reuseConnection()"
jenkins-bot [Mon, 26 Aug 2019 21:21:34 +0000 (21:21 +0000)]
Merge "rdbms: rename $db => $conn in remaining places in LoadBalancer"
jenkins-bot [Mon, 26 Aug 2019 20:43:19 +0000 (20:43 +0000)]
Merge "Setup: Move wgRCLinkDays logic from Setup to ChangesListSpecialPage"
James D. Forrester [Mon, 26 Aug 2019 19:41:08 +0000 (12:41 -0700)]
resources: Also add jQuery Migrate to foreign-resources.yaml
Change-Id: I218235fa3da0c64f111c7fe2afffeba6a30b6e21
Brad Jorsch [Wed, 7 Aug 2019 21:24:47 +0000 (17:24 -0400)]
Revert actor changes to populateLogSearch.php
In all the past patches, we missed the fact that this maintenance script
is run as an upgrade from MW pre-1.16 to MW 1.16. It's apparently not
intended to be run outside of the upgrade process.
Thus, let's revert the changes that were made to the script in I8d825eb0
and I4764c1c7. Instead, the script need only detect that the pre-1.16
schema it's looking for doesn't exist anymore and bail out.
Bug: T188327
Change-Id: I7e03b45ef6d43b9069f0399089ab06e136a89fbc
Aaron Schulz [Mon, 26 Aug 2019 17:24:36 +0000 (10:24 -0700)]
rdbms: remove unused $fulltextEnabled field from DatabaseSqlite
Change-Id: Idad680485f6cf6b521a0ea33c02d30e78d1d6b50
Brad Jorsch [Mon, 26 Aug 2019 19:12:30 +0000 (15:12 -0400)]
MessageCache: Add STRAIGHT_JOIN to avoid planner oddness
For some unknown reason, when the `actor` table has few enough NS8 rows
compared to `page` MariaDB 10.1.37 decides it makes more sense to fetch
everything from `actor` then join `revision` then `page` rather than
fetching the rows from `page` in the first place.
We can work around it by telling it to not reorder the query, but then
we also have to reorder it ourselves to put `page` first instead of
`revision`.
Bug: T231196
Change-Id: I2b2fb209e648d1e407c5c2d32d3ac9e574e361d5
jenkins-bot [Mon, 26 Aug 2019 19:05:14 +0000 (19:05 +0000)]
Merge "Use local variabe $services instead of MediaWikiServices::getInstance()"
jenkins-bot [Mon, 26 Aug 2019 18:45:00 +0000 (18:45 +0000)]
Merge "Disambiguate confusing $fromReplica variable in BlockManager"
Bartosz Dziewoński [Mon, 26 Aug 2019 18:02:57 +0000 (20:02 +0200)]
SpecialNewSection: Fix handling of 'preloadparams'
The parent class RedirectSpecialPage handles array parameters
automatically, and we need to specify the name without the '[]',
same as in RedirectSpecialArticle.
Bug: T231088
Change-Id: I52838a39f3311fe612c466903d7eda95fecedfa7
Amir Sarabadani [Mon, 26 Aug 2019 16:28:26 +0000 (18:28 +0200)]
Aaron Schulz [Thu, 15 Aug 2019 13:26:51 +0000 (09:26 -0400)]
objectcache: SqlBagOStuff cleanups for sqlite and postgres
Make createTables() work for Postgres. Also add and use new
initSqliteDatabase() method for SQLite.
Also use ConvertibleTimestamp instead of wfTimestamp
Change-Id: I8e4505775e57fc6cd7380afa015fc0901a1bfc1b
Aaron Schulz [Mon, 26 Aug 2019 16:15:04 +0000 (09:15 -0700)]
rdbms: rename $db => $conn in remaining places in LoadBalancer
Change-Id: I7e419cdc97d03616d5ee011a97fca658d0d79cad
jenkins-bot [Mon, 26 Aug 2019 15:09:13 +0000 (15:09 +0000)]
Merge "language: Move ConverterRule to includes/ and add test case"
Fomafix [Mon, 26 Aug 2019 14:08:10 +0000 (16:08 +0200)]
Use local variabe $services instead of MediaWikiServices::getInstance()
Change-Id: Ieb6230231d9b916fd1366e7b473db00c87ac4428
Timo Tijhof [Sun, 25 Aug 2019 17:55:34 +0000 (18:55 +0100)]
language: Move ConverterRule to includes/ and add test case
Add a very basic test that creates an instance, invokes it
with an empty string, and asserts the types and values returned
by the public methods used in LanguageConverter::applyManualConv.
Bug: T225756
Change-Id: I3600260e712f019243ba5f00890011e694444e43
Aryeh Gregor [Mon, 26 Aug 2019 09:54:19 +0000 (12:54 +0300)]
Pass correct store to rebuildLocalisationCache.php
e4468a1d6b6 completely broke rebuildLocalisationCache.php by
unconditionally passing in LCStoreDB( [] ) instead of constructing the
correct object.
Bug: T231183
Change-Id: I0d52662e8745cf0e10091169b3b08eff48ef2b8f
Aryeh Gregor [Mon, 26 Aug 2019 09:41:56 +0000 (12:41 +0300)]
Correctly register storeDirectory in l10n cache
e4468a1d6b6 made LocalisationCache a service and refactored a bunch of
setup code. In doing so, when processing 'storeDirectory' from
$wgLocalisationCacheConf, it accidentally started treating empty
non-null values (such as the default "false") as storage paths instead
of meaning "fall back to $wgCacheDirectory". This would have broken all
config that used file store for LocalisationCache and did not specify
'storeDirectory'.
Bug: T231183
Change-Id: I9ff16be628996b202599e3bb2feed088af03775f
Translation updater bot [Mon, 26 Aug 2019 06:32:31 +0000 (08:32 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I85f8b577290b04d60af1fa4f9151a6756a658aa8
Aaron Schulz [Mon, 26 Aug 2019 06:04:24 +0000 (23:04 -0700)]
rdbms: simplify comment in LoadBalancer::reuseConnection()
Change-Id: Ie6ea6ac7617b1f026b0ee7b8b76c287ec0da9e34
jenkins-bot [Mon, 26 Aug 2019 04:35:59 +0000 (04:35 +0000)]
Merge "title: Fix flaky TitlePermissionTest::testUserBlock"
Tim Starling [Fri, 16 Aug 2019 04:38:48 +0000 (14:38 +1000)]
REST: call MediaWiki::preOutputCommit and doPostOutputShutdown
As in api.php. Among other things, this enables profiling.
Move EntryPoint test out of unit/ so that it passes.
Use ob_start()/ob_end_clean() instead of assuming an output buffer is
open, so that EntryPoint::execute() can be run from CLI mode.
Change-Id: I38162a9eac6fd5acfed2035b87cac4a97ffd50d6
Timo Tijhof [Sun, 25 Aug 2019 22:19:48 +0000 (23:19 +0100)]
Setup: Move wgRCLinkDays logic from Setup to ChangesListSpecialPage
This is only needed when viewing SpecialRecentChanges (or a related
page). Move the consuming logic to that class, where it can be
maintained as part of the rest of the code. This also makes it
more testable and makes config easier to work with or load from
elsewhere in the future. Aside from some dynamic default values,
configuration should generally not mutate. If there is some domain-
specific way to consume it, the relevant component should be
responsible for doing so. This also means we defer such logic to
where it is needed, instead of unconditionally for all possible
features that might be used.
Bug: T189966
Change-Id: If17608909711d98ac560b6d64f72ba7913a561a9
jenkins-bot [Sun, 25 Aug 2019 22:15:02 +0000 (22:15 +0000)]
Merge "resourceloader: Add coverage for internal Context::getReqBase()"
jenkins-bot [Sun, 25 Aug 2019 22:12:00 +0000 (22:12 +0000)]
Merge "rdbms: refactor caching in LoadBalancer::getReadOnlyReason()"
Aaron Schulz [Sun, 25 Aug 2019 22:03:33 +0000 (15:03 -0700)]
Avoid PHP warning due to bogus second tideways_xhprof_enable() argument
Change-Id: I3d86d74e8a97eb578f392f9f1d918cc628d2bf4b
Aaron Schulz [Tue, 16 Jul 2019 06:06:13 +0000 (23:06 -0700)]
rdbms: refactor caching in LoadBalancer::getReadOnlyReason()
Avoid nesting of the same getWithSetCallback() cache updates.
Also favor accuracy over initial cache use for the case where
there is already a master connection. Add missing "lockTSE"
flag to protect against stampedes updating stale values.
Change serverIsReadOnly() to use SELECT in mysql instead of
SHOW to avoid internal temporary tables.
Bug: T227838
Change-Id: I2b0d680c9c3bdc7aaa1d1e1d6beb2dd203a815f1