Krinkle [Tue, 11 Sep 2012 03:30:38 +0000 (03:30 +0000)]
Merge "enhance jquery.spinner, keeping backwards compatibility"
MatmaRex [Mon, 3 Sep 2012 15:08:46 +0000 (17:08 +0200)]
enhance jquery.spinner, keeping backwards compatibility
Replaced single `id` argument to $.createSpinner with an options object.
The options allow one to set the id (as before), spinner size (small or
large), and its display mode (inline or block). Analogic change was made
to $.fn.injectSpinner.
Default options are kept the same as they used to be, and old-style calls
still work. However, the definition of .mw-spinner CSS class has been
changed (although, with a bit of hairy code, it could be kept
compatible...).
These changes should be enough to allow us to replace old usages of
.mw-small-spinner and .mw-ajax-loader classes, as defined in shared.css.
This is a reimplementation of the idea described in Ie55ffb6b.
Copied spinner.gif and ajax-loader.gif from /skins/common/images/.
Change-Id: I0ff71ba1eef299e0e699df84c68f1be1c20492f7
Aaron Schulz [Tue, 11 Sep 2012 00:31:46 +0000 (00:31 +0000)]
Merge "Don't exit too quickly when reporting an exception."
Catrope [Mon, 10 Sep 2012 20:15:59 +0000 (13:15 -0700)]
Fix fatal error in rcprop=loginfo
There was a recentchanges row on enwiki whose rc_params looked like
array('4::tags'=>array('db-g11')), and the tag name wasn't set
recursively so the inner array didn't get a tag name.
This still generates invalid XML of course, because <4::tags> isn't a
valid tag, but at least it doesn't fatal any more. RAWR XML GRUMBLE
Change-Id: Ibb775df4bd010bdce5632914f789230d8626c9e7
Aaron [Wed, 5 Sep 2012 17:58:26 +0000 (10:58 -0700)]
Made backend sync script handle random errors better.
Change-Id: I3ad5d9d0768480d8be4bb480fe653238d203a95c
Aaron [Mon, 10 Sep 2012 21:01:29 +0000 (14:01 -0700)]
[FileBackend] Added concatenate() failure logging.
Change-Id: Iebc0f6e4caf57e44903dd3f0db6e3f95d589f13e
Translation updater bot [Mon, 10 Sep 2012 19:44:17 +0000 (19:44 +0000)]
Merge "Localisation updates from translatewiki.net."
Catrope [Mon, 10 Sep 2012 19:32:22 +0000 (19:32 +0000)]
Merge "[FileBackend] Treat NoSuchObjectException as a normal error in streamFile()."
Translation updater bot [Mon, 10 Sep 2012 19:24:20 +0000 (19:24 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I05c180264b8505cf5897256b360ad624aaf1284f
Alexandre Emsenhuber [Mon, 10 Sep 2012 17:55:20 +0000 (19:55 +0200)]
Convert last usages of wfMsg*() to wfMessage().
Change-Id: Ia0f8c196a77edd0cd60cb1a4880342e831e8b49d
IAlex [Mon, 10 Sep 2012 17:33:37 +0000 (17:33 +0000)]
Merge "Replace some occurrences of wfMsg* by alternatives. Undeprecated wfMsgReplaceArgs."
Translation updater bot [Sun, 9 Sep 2012 19:28:28 +0000 (19:28 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I048314321c9e2213fd957e1a43a4005953a85188
Aaron Schulz [Sun, 9 Sep 2012 17:54:16 +0000 (10:54 -0700)]
[FileBackend] Treat NoSuchObjectException as a normal error in streamFile().
Change-Id: I6b64e524a7f3cba6cabe5282f5915cd05dbf8ad0
Alexandre Emsenhuber [Sun, 9 Sep 2012 13:12:02 +0000 (15:12 +0200)]
Don't exit too quickly when reporting an exception.
MWExceptionHander::handle() already exist at the end of its task,
so there's no need to have other die() calls.
There were some problems with that:
- wfLogProfilingData() was only called after reporting some exception
- MWExceptionHandler::report() was not consistent between web and
command-linerequests
- MWException::reportHTML() was also not consistent when using the
OutputPage object or not
Also removed MWExceptionHander::escapeEchoAndDie() since it's not needed anymore.
Change-Id: Ibb679c425ef0271a65f623c7b8541ec9bec70eb0
Aaron Schulz [Sun, 9 Sep 2012 04:40:17 +0000 (21:40 -0700)]
Use quickImport() for upload chunk storage calls.
* Using store() is slower and causes problems with multiwrite backends,
since the other temp storage calls already wrap doQuickOperations().
* Modified quickImport() to accept stored files as the source parameter.
Change-Id: I3b32b46ce6b5562bb661ec49255630236aeaa44c
Aaron Schulz [Sun, 9 Sep 2012 02:19:38 +0000 (02:19 +0000)]
Merge "Renamed $pairs => $triples."
Aaron Schulz [Sun, 9 Sep 2012 02:15:27 +0000 (19:15 -0700)]
Renamed $pairs => $triples.
Change-Id: Ia87880ed00e734c577e0ab6d07cdac5c8b1dd619
Aaron Schulz [Sun, 9 Sep 2012 00:10:12 +0000 (17:10 -0700)]
Reduced max TempFSFile::factory() attempts since it uses 12 hex chars.
Change-Id: I93dd53f391e74b953c89b4225ab691850ccc66ef
Translation updater bot [Sat, 8 Sep 2012 18:54:36 +0000 (18:54 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Iaa597b7e816596e2b7e7663c60a17002f49bb332
umherirrender [Sat, 8 Sep 2012 14:15:27 +0000 (16:15 +0200)]
Some changes to Special:ListUsers and Special:ActiveUsers
* Change raw database quoting
* Use new syntax for aliased columns
* Change AND condition into array syntax
* Spacing
* Change raw html to Html::element
Change-Id: Ifebe807ab1c2d5a3e8b6bb22087b6d0040c5794f
IAlex [Sat, 8 Sep 2012 13:50:34 +0000 (13:50 +0000)]
Merge "Replace deprecated methods."
IAlex [Sat, 8 Sep 2012 13:46:08 +0000 (13:46 +0000)]
Merge "Fix Title::getRedirectsHere to respect interwiki prefix"
IAlex [Sat, 8 Sep 2012 05:46:50 +0000 (05:46 +0000)]
Merge "Made DBABagOStuff return values match the base class better."
IAlex [Sat, 8 Sep 2012 05:40:40 +0000 (05:40 +0000)]
Merge "Made default BagOStuff::incr() function more like memcached."
umherirrender [Sat, 8 Sep 2012 04:57:10 +0000 (06:57 +0200)]
Fix Title::getRedirectsHere to respect interwiki prefix
Respecting rd_interwiki is needed to act the same way than
Special:Whatlinkshere. For local redirects it is needed to also check
for NULL, not only the empty string
Change-Id: I4f3f242d69054dcbb3c7a02441991196ba140986
Siebrand [Fri, 7 Sep 2012 23:30:18 +0000 (23:30 +0000)]
Merge "(bug 40058) Parse newwindow message."
Aaron Schulz [Fri, 7 Sep 2012 22:36:24 +0000 (22:36 +0000)]
Merge "Use $this to get the Title object in SkinTemplate::buildNavUrls()"
Siebrand Mazeland [Fri, 7 Sep 2012 22:28:16 +0000 (00:28 +0200)]
Replace deprecated methods.
Also updated code formatting.
Change-Id: I188b5d29c9496383df10c391b29e9d26e59e8aeb
Translation updater bot [Fri, 7 Sep 2012 22:20:29 +0000 (22:20 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Ied795a8d85a9ff888131061fd8ec0ef35027ca42
daniel [Mon, 27 Aug 2012 12:46:23 +0000 (14:46 +0200)]
Fix transaction nesting caused by LocalFile.
The transaction bracket in LocalFile::recordUpload2 used to span a call
to WikiPage::doEdit, which in turn opens a transaction. Nesting transactions
this way does not work: the first transaction is committed prematurely when
the second one starts. This may cause serious database corruption and
generally exciting behavior.
This change commits LocalFile's own transaction before any interaction
with WikiPage. There may be a race condition here, but that case seems to
be already handled in the code. Also, in the previous "broken" state, all
transactional protection got lost anyway - so this should at least be no
worse than what we had.
This may be changed back if and when we have support for nested
transactions.
Change-Id: I20d90fedb2d19c64ccf0f3942ddda756fe511c12
IAlex [Fri, 7 Sep 2012 21:06:06 +0000 (21:06 +0000)]
Merge "Avoid redundant logging UPDATE query."
Aaron Schulz [Fri, 7 Sep 2012 20:49:32 +0000 (20:49 +0000)]
Merge "New hook, 'SearchResultInitFromTitle'"
Dereckson [Thu, 30 Aug 2012 14:42:49 +0000 (16:42 +0200)]
(bug 40072) Add semantic CSS classes to identify changes list items
In the special pages containing changes list, adding the following
CSS classes to revision rows:
- mw-changeslist-date
- mw-changeslist-title
- mw-changeslist-separator (matching the dots, ". .")
This enhancement has been implemented to the following special pages:
- [[Special:Contributions]]
- [[Special:DeletedContributions]]
- [[Special:RecentChanges]]
- [[Special:Watchlist]]
It's also implemented on pages history.
Change-Id: I2385ef21d9aed4bdbe4971bfcfa28efaf058e7dd
Alex Monk [Thu, 6 Sep 2012 16:24:48 +0000 (17:24 +0100)]
(bug 40058) Parse newwindow message.
Change-Id: Ibd24a2cbadecd0dbfeaa06d86d55dd2bcaeefa7d
Alexandre Emsenhuber [Fri, 7 Sep 2012 20:03:56 +0000 (22:03 +0200)]
Improve documentation of maintenance scripts.
Change-Id: I768abad1ad4642263519d39c50c88437aed47e15
Alexandre Emsenhuber [Fri, 7 Sep 2012 18:04:11 +0000 (20:04 +0200)]
Removed purgeStaleMemcachedText.php and refreshImageCount.php scripts
Both are Wikimedia-specific scripts and are now obsolete:
- purgeStaleMemcachedText.php is a script to purge memcached entries
for revision text older than an hardcoded date of December 2012.
This script is already in the WikimediaMaintenance extension.
- refreshImageCount.php is a hack to fix a schema update script dating
to 2006.
Change-Id: I2ae469063eba502e662f80c38d5816c371550352
Aaron [Fri, 7 Sep 2012 17:17:12 +0000 (10:17 -0700)]
Avoid redundant logging UPDATE query.
Change-Id: I277f311ea92ff3470039d9416e720573debba44a
IAlex [Fri, 7 Sep 2012 17:01:46 +0000 (17:01 +0000)]
Merge "(bug 39956) MediaWiki's info action should vertically align cell values to top * Fixed spacing"
Daniel Kinzler [Fri, 7 Sep 2012 09:12:34 +0000 (09:12 +0000)]
Merge "New hook 'AfterFinalPageOutput' which is called at the end of OutputPage::output()"
Daniel Kinzler [Fri, 7 Sep 2012 09:10:03 +0000 (09:10 +0000)]
Merge "Alpha-sort lists of api modules in ApiQuery"
IAlex [Fri, 7 Sep 2012 08:59:08 +0000 (08:59 +0000)]
Merge "Replace non standard 'tt' with 'code' for better HTML5 conformity"
raymond [Fri, 7 Sep 2012 08:52:49 +0000 (10:52 +0200)]
Replace non standard 'tt' with 'code' for better HTML5 conformity
See http://www.w3.org/wiki/HTML/Elements/tt
Change-Id: I902a6cab5310cd726c84cbd87840bce2c0d51eda
Daniel Werner [Thu, 5 Jul 2012 14:21:21 +0000 (16:21 +0200)]
New hook 'AfterFinalPageOutput' which is called at the end of OutputPage::output()
Called before final ob_end_flush() which will send the buffered output to the client. This allows for last-minute modification of the output within the buffer by using ob_get_clean().
- patch-set2: moved the hook before OutputPage::sendCacheControl() is called, as suggested by Reedy.
Change-Id: I264a37ac74e0c18ff141f82156e669ece3212c2d
Tim Starling [Fri, 7 Sep 2012 05:13:38 +0000 (15:13 +1000)]
Remove @deprecated from wfTimestamp()
Adding abbreviated wrappers for lengthy function invocations is good
practice, it improves code readability. If all we ever had was
MWTimestamp, and we had a million instances of
$timestamp = new MWTimestamp( $ts );
$mwTimestamp = $timestamp->getTimestamp( TS_MW );
I would introduce a global function or class static method wrapper to
clean up those invocations. But I don't have to, because we already have
the wrapper.
Change-Id: I9149a7626676a0115a0a877f27d8b65e6e868de9
Reedy [Thu, 6 Sep 2012 22:20:05 +0000 (22:20 +0000)]
Merge "(bug 32552) Drop unused database field cat_hidden"
Reedy [Thu, 6 Sep 2012 21:29:10 +0000 (22:29 +0100)]
Add some trailing whitespace
Change-Id: I0d43d82e2d78f86e50fac82f10bd1d7cebac176c
Translation updater bot [Thu, 6 Sep 2012 19:46:32 +0000 (19:46 +0000)]
Merge "Localisation updates from translatewiki.net."
Translation updater bot [Thu, 6 Sep 2012 19:39:21 +0000 (19:39 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I1a45240e7604142bc0270b2e1cc64f035ff60cf0
Derk-Jan Hartman [Thu, 6 Sep 2012 19:37:28 +0000 (21:37 +0200)]
(bug 33445) Remove default right margin on wikitables.
This makes sure that wikitables can be full width.
When right or left floating a table, use class="wikitable floatleft"
or class="wikitable floatright" to explicitly add a proper margin.
Change-Id: I107d8d8da0a07055c320767cadb7a691f344a394
Brion Vibber [Thu, 6 Sep 2012 19:10:57 +0000 (12:10 -0700)]
try/catch for bug 40037 weird timestamps in exif
Change-Id: I474bb796328baab6ca123d68c3ce7cf78fccfd3a
madman [Thu, 6 Sep 2012 13:49:13 +0000 (13:49 +0000)]
(bug 39956) MediaWiki's info action should vertically align cell values to top
* Fixed spacing
Change-Id: Ic20ff3d7985b4cd2457a09f9cd0c76367e9e3980
Aaron Schulz [Thu, 6 Sep 2012 18:37:42 +0000 (18:37 +0000)]
Merge "(bug 30445) Update 'revdelete-reason-dropdown'"
Siebrand [Thu, 6 Sep 2012 18:36:39 +0000 (18:36 +0000)]
Merge "Remove usage of wfTime() in benchmarks and backupTextPassTest.php"
Reedy [Thu, 6 Sep 2012 18:26:23 +0000 (19:26 +0100)]
Alpha-sort lists of api modules in ApiQuery
$ocd++;
Change-Id: I3dbf763d360822f2c39e97622b2ca32b9c322ee5
Nikerabbit [Thu, 6 Sep 2012 17:58:22 +0000 (17:58 +0000)]
Merge "Remove <code> which no longer makes sense."
Aaron Schulz [Thu, 6 Sep 2012 17:54:59 +0000 (17:54 +0000)]
Merge "Revert "thumb.php now handles short and long thumbnail name formats when possible.""
Aaron Schulz [Thu, 6 Sep 2012 17:52:33 +0000 (17:52 +0000)]
Revert "thumb.php now handles short and long thumbnail name formats when possible."
Doesn't quite work, since $img->transform() still saved the thumb under the normal name.
This reverts commit
5b33e66b749b525f745dc3c0e814f072fd136479
Alexandre Emsenhuber [Thu, 6 Sep 2012 17:47:17 +0000 (19:47 +0200)]
Remove usage of wfTime() in benchmarks and backupTextPassTest.php
Left the usage in GlobalTest.php since these are tests for
that function.
This function is only a wrapper to microtime( true ),
so it can easily be replaced and deprecated at some point.
Change-Id: I4f7c1f6705e10e2664f8e9be51d86ed5c8ff1e1c
Catrope [Thu, 6 Sep 2012 17:42:29 +0000 (17:42 +0000)]
Merge "thumb.php now handles short and long thumbnail name formats when possible."
Catrope [Thu, 6 Sep 2012 17:33:20 +0000 (17:33 +0000)]
Merge "[FileBackend] Work-around low header value limits in Swift."
Aaron [Thu, 6 Sep 2012 17:15:10 +0000 (10:15 -0700)]
[FileBackend] Work-around low header value limits in Swift.
* Also added sanity check to makeContentDisposition() and made the file name optional
Change-Id: Ie4bfef743d11227631606498f026e693dd8d21f3
umherirrender [Fri, 3 Aug 2012 19:33:18 +0000 (21:33 +0200)]
(bug 32552) Drop unused database field cat_hidden
For the hiddencat feature the page prop table is used
Change-Id: If01d3394617ab8aec1a9b50c20bfe923df08732c
Reedy [Wed, 5 Sep 2012 22:25:38 +0000 (23:25 +0100)]
Move 3 RELEASE-NOTES entries from the API section
Change-Id: I2f2cff7dfca71b145740d8f2ec1face68639f58a
Siebrand Mazeland [Thu, 6 Sep 2012 13:37:56 +0000 (15:37 +0200)]
Remove <code> which no longer makes sense.
Change-Id: I96fe92aecae3aa61d35fe8a9d2f1bf62859a37d3
Aaron Schulz [Thu, 6 Sep 2012 05:25:41 +0000 (05:25 +0000)]
Merge "[Bug 35738] remove zone info from ipv6 addresses"
daniel [Wed, 5 Sep 2012 19:11:42 +0000 (21:11 +0200)]
[Bug 35738] remove zone info from ipv6 addresses
Patch provided by Nick Kuznia
Change-Id: Icccf10974746e8e27000ab45de28d0f1836ec8aa
Alexandre Emsenhuber [Wed, 5 Sep 2012 19:52:03 +0000 (21:52 +0200)]
Do strict check for $par in Special:Log
Otherwise Special:Log/0 would not behave as expected.
Change-Id: I47ac43ca71bd7384f19c51a11f114240b0cc0702
Reedy [Thu, 6 Sep 2012 00:03:16 +0000 (00:03 +0000)]
Merge "add moveoverredirect to result of api move"
Reedy [Wed, 5 Sep 2012 22:21:54 +0000 (23:21 +0100)]
* (bug 39665) Cache AllowedGenerator array so it doesn't autoload all query classes on every request.
Change-Id: I541ecf931a2bbe766bf31f569f81cc92308e35e1
Alexandre Emsenhuber [Wed, 5 Sep 2012 20:21:20 +0000 (22:21 +0200)]
Use $this to get the Title object in SkinTemplate::buildNavUrls()
No need to call OutputPage::getTitle().
Change-Id: I7ecd497b38044a05a953659780ac127bfb6597e5
Aaron [Wed, 5 Sep 2012 19:50:09 +0000 (12:50 -0700)]
Made DBABagOStuff return values match the base class better.
Change-Id: I2e6fd79195c52e66f8345c5cc67c2e3dcc04578d
IAlex [Wed, 5 Sep 2012 19:39:41 +0000 (19:39 +0000)]
Merge "Make Special:Log link pretty in navigation toolbox"
Translation updater bot [Wed, 5 Sep 2012 19:29:10 +0000 (19:29 +0000)]
Merge "Localisation updates from translatewiki.net."
Aaron [Wed, 5 Sep 2012 19:22:14 +0000 (12:22 -0700)]
Revert "(bug 27111) Make cascading foreign repo's fetch description properly"
The combination of $out->addHTML() and the super call cause action=render for
File pages to have the text rendered twice. Wikis get commons descriptions via
action=render, so they were showing the description text twice.
This reverts commit
ca13fde652e1a1a05c835219af7b014509a1c88f.
Conflicts:
RELEASE-NOTES-1.20
Change-Id: Ib1072fd1d109c0d6706215ccad1413dd72cb201d
daniel [Wed, 5 Sep 2012 19:15:11 +0000 (19:15 +0000)]
Merge "adding @group Database to more tests" into Wikidata
daniel [Wed, 5 Sep 2012 19:14:45 +0000 (19:14 +0000)]
Merge "fix spurious failure of TimestampTest" into Wikidata
Demon [Wed, 5 Sep 2012 19:14:09 +0000 (19:14 +0000)]
Merge "[FileBackend] Clear swift connection on invalid HTTP responses."
Translation updater bot [Wed, 5 Sep 2012 19:13:48 +0000 (19:13 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I283636215457bc783c8530ccef768d5cb31634ae
Daniel Kinzler [Wed, 5 Sep 2012 19:06:48 +0000 (19:06 +0000)]
Merge "New hook ApiCheckCanExecute."
Aaron [Wed, 5 Sep 2012 18:51:04 +0000 (11:51 -0700)]
Made default BagOStuff::incr() function more like memcached.
Change-Id: Ia216f20fdcf855448e2f2e4d99667e72c6254f82
Tyler Romeo [Tue, 21 Aug 2012 15:52:47 +0000 (11:52 -0400)]
New hook ApiCheckCanExecute.
Added new hook in ApiMain::checkCanExecute
so that extensions can authenticate and
authorize API clients before the module is
execute. (Necessary for extensions like
OAuth that externally authnz clients.)
Change-Id: I1b059fd9a4aa717928af8b09f5edebe899ab3ce1
Signed-off-by: Tyler Romeo <tylerromeo@gmail.com>
Catrope [Wed, 5 Sep 2012 18:17:14 +0000 (18:17 +0000)]
Merge "Handle '\0\0\0\0\0\0\0\0\0\0\0\0\0\0' in setTimestamp"
Kaldari [Wed, 5 Sep 2012 18:15:20 +0000 (18:15 +0000)]
Merge changes I794d4675,I57e2fc0b
* changes:
LivePreview: handle .mw-newarticletext element
LivePreview: coding conventions and overall code prettiness
MatmaRex [Sat, 1 Sep 2012 16:35:07 +0000 (18:35 +0200)]
LivePreview: handle .mw-newarticletext element
Previously, if LivePreview was used during article creation, the throbber
would be first inserted as the beginning of #mw-content-text (above
.mw-newarticletext), and then overlaid over it on subsequent previews.
Since .mw-newarticletext itself wasn't being faded, this looked ugly.
Now .mw-newarticletext is hidden after first preview and treated like
other elements LivePreview updates. (This mimics the behavior of regular
preview.)
Change-Id: I794d4675721280b041858fd1cb8ca26b32a5ed17
MatmaRex [Sat, 1 Sep 2012 14:46:04 +0000 (16:46 +0200)]
LivePreview: coding conventions and overall code prettiness
There are no functionality changes; some code has been moved around, some
variables were renamed, some whitespace fixed, some comments updated.
Slightly non-trivial changes:
* use .animate instead of .fadeTo (see comment in code for explanation)
* move loading diff styles out of the if (RL will take care of it)
Change-Id: I57e2fc0b090b6cbbcc15a445ac65bab860fbcae9
daniel [Wed, 5 Sep 2012 16:55:19 +0000 (18:55 +0200)]
fix spurious failure of TimestampTest
Change-Id: Ieadadd5300b10a3de856ffd4128bd9fbb09c417e
daniel [Wed, 5 Sep 2012 16:54:15 +0000 (18:54 +0200)]
adding @group Database to more tests
Change-Id: If1b63f8be80fdc18ccc3dc526f82f7684c5cf50b
daniel [Wed, 5 Sep 2012 16:27:32 +0000 (18:27 +0200)]
introducing ContentHandler::getPageViewLanguage
Change-Id: I5b7aabaab48b30a9b6620a0cb4272bc5e348c014
yaron [Wed, 5 Sep 2012 02:21:09 +0000 (06:21 +0400)]
New hook, 'SearchResultInitFromTitle'
This hook lets you change the revision ID used for a page (a Title
object), when displaying that page in search results. It's useful for
the Approved Revs extension, so that pages whose approved revision is
not their latest can have their approved revision, not the latest one,
show up when doing a search text. It's also potentially useful for
other, similar extensions, like FlaggedRevs.
Change-Id: Ic4bad8dfaa83de131db9c8e7667d7f5767d8d5f5
daniel [Wed, 5 Sep 2012 15:50:13 +0000 (17:50 +0200)]
merge latest master.
some tests fail due to logical changes, will fix that in a follow-up
Change-Id: I8a5e4087ecf674fbcf6327c5d168cd401be12400
Reedy [Wed, 5 Sep 2012 00:21:42 +0000 (01:21 +0100)]
Handle '\0\0\0\0\0\0\0\0\0\0\0\0\0\0' in setTimestamp
Also tidied up/fleshed out method function type documentation
Change-Id: I3d1b1862d0f2f1968e0e4c9b01dc34de955377d2
daniel [Wed, 5 Sep 2012 13:04:07 +0000 (15:04 +0200)]
Restore (some) globals after each test
Change-Id: I5fbf777c2bd4b1f88ba76d5cc42ad6df2eee4a9c
Brion Vibber [Tue, 4 Sep 2012 23:47:25 +0000 (18:47 -0500)]
Fix exif timestamp bug
Missing a prefixed 0 on the hour for some reason, explodes.
Change-Id: I8658223d36404e73b9b4d28ce027c1abf98b3f8f
Aaron [Tue, 4 Sep 2012 16:57:44 +0000 (09:57 -0700)]
thumb.php now handles short and long thumbnail name formats when possible.
Change-Id: I8e53ce711e23127854185661c5ce8bddbb226623
Timo Tijhof [Tue, 4 Sep 2012 19:47:20 +0000 (21:47 +0200)]
Various javascript optimizations (fixes bug 39959)
* (bug 39959) Right click to edit section causing browser hangs
The :has() selector has gotten significantly slower in
jQuery 1.8.1 however the reason it affected us so much is
partly because of the very inefficient way we used it.
Namely duplicated 6 times and evaluated from a live() binding
In order words, on every instance of the event.
Optimizing by
- only select headings, do the :has implicitly by checking
for the result of .find().
- document.on(.., selector) instead of .live()
- remove redundant and overkill 'return false'
Results in Firefox 15/Chrome 21:
- up to 130x (one hundred and thirty) faster!
* /resources/* (except for third party libs)
- Use .on() instead of bind, delegate or live
- Use .off() instead of unbind, undelegate or die
- Use document.getElementById instead of $('#' + variable)
not for performance but for predictability/security.
(e.g. rel="foo.bar" should select id="foo.bar" not
id="foo" class="bar")
- Fix some minor whitespace and code conventions.
Change-Id: I2fefb5376d0de40f4997a3a1763eee23fcd3e7fa
Aaron Schulz [Tue, 4 Sep 2012 20:59:16 +0000 (20:59 +0000)]
Merge "Fixed and normalized content-disposition for thumbs."
Translation updater bot [Tue, 4 Sep 2012 20:18:01 +0000 (20:18 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I4f812faef1be14d9a699d5159d8e453c74763d68
Alexandre Emsenhuber [Tue, 4 Sep 2012 19:05:40 +0000 (21:05 +0200)]
Remove usage of wfTime() in maintenance
This function is only a wrapper to microtime( true ),
so it can easily be replaced and deprecated at some point.
Change-Id: I26f77d3cb02cc517ecf51262a4684084a7ce7825
Aaron Schulz [Tue, 4 Sep 2012 18:44:55 +0000 (18:44 +0000)]
Merge "(bug 39287) Fixed error checking in DatabaseMysql::fetchObject."
Tyler Anthony Romeo [Tue, 4 Sep 2012 03:55:18 +0000 (23:55 -0400)]
(bug 39287) Fixed error checking in DatabaseMysql::fetchObject.
According to the libmysql API documentation, mysql_fetch_row,
upon which the PHP functions mysql_fetch_object, etc. are
based on, does not reset the error number or message upon
success. So calling mysql_errno() after a successful fetch
may return the error of the previous function call.
This commit changes DatabaseMysql::fetchObject and similar
functions to only check for specific error numbers that are
explicitly documented to be expected from mysql_fetch_*.
Change-Id: Iacb78828885a8a0d4e499a681d938a6adf651582