From 3535a5f32794114f8dc8b060a217f6da020401e3 Mon Sep 17 00:00:00 2001
From: Ed Sanders <esanders@wikimedia.org>
Date: Fri, 12 Apr 2019 20:45:35 +0100
Subject: [PATCH] JsonContent: Add missing prefix to selector

Change-Id: I977f6c565b93949a310d1207411f893cf83af996
---
 includes/content/JsonContent.php                 |  2 +-
 resources/src/mediawiki.content.json.less        |  2 ++
 .../phpunit/includes/content/JsonContentTest.php | 16 ++++++++--------
 3 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/includes/content/JsonContent.php b/includes/content/JsonContent.php
index 2cd1fb3b50..a1f199de2f 100644
--- a/includes/content/JsonContent.php
+++ b/includes/content/JsonContent.php
@@ -220,7 +220,7 @@ class JsonContent extends TextContent {
 			return Html::rawElement( 'td', [], $this->arrayTable( $val ) );
 		}
 
-		return Html::element( 'td', [ 'class' => 'value' ], $this->primitiveValue( $val ) );
+		return Html::element( 'td', [ 'class' => 'mw-json-value' ], $this->primitiveValue( $val ) );
 	}
 
 	/**
diff --git a/resources/src/mediawiki.content.json.less b/resources/src/mediawiki.content.json.less
index ca950d58ec..4fa9ee25bd 100644
--- a/resources/src/mediawiki.content.json.less
+++ b/resources/src/mediawiki.content.json.less
@@ -18,8 +18,10 @@
 	padding: 0.5em 1em;
 }
 
+/* TODO: Remove this old class once the content caches have cleared */
 /* stylelint-disable-next-line selector-class-pattern */
 .mw-json .value,
+.mw-json-value,
 .mw-json-single-value {
 	background-color: #dcfae3;
 	font-family: monospace, monospace;
diff --git a/tests/phpunit/includes/content/JsonContentTest.php b/tests/phpunit/includes/content/JsonContentTest.php
index 7cddbad26d..8546d967a6 100644
--- a/tests/phpunit/includes/content/JsonContentTest.php
+++ b/tests/phpunit/includes/content/JsonContentTest.php
@@ -113,27 +113,27 @@ class JsonContentTest extends MediaWikiLangTestCase {
 			],
 			[
 				(object)[ 'foo' ],
-				'<table class="mw-json"><tbody><tr><th>0</th><td class="value">"foo"</td></tr>' .
+				'<table class="mw-json"><tbody><tr><th>0</th><td class="mw-json-value">"foo"</td></tr>' .
 				'</tbody></table>'
 			],
 			[
 				(object)[ 'foo', 'bar' ],
-				'<table class="mw-json"><tbody><tr><th>0</th><td class="value">"foo"</td></tr>' .
-				'<tr><th>1</th><td class="value">"bar"</td></tr></tbody></table>'
+				'<table class="mw-json"><tbody><tr><th>0</th><td class="mw-json-value">"foo"</td></tr>' .
+				'<tr><th>1</th><td class="mw-json-value">"bar"</td></tr></tbody></table>'
 			],
 			[
 				(object)[ 'baz' => 'foo', 'bar' ],
-				'<table class="mw-json"><tbody><tr><th>baz</th><td class="value">"foo"</td></tr>' .
-				'<tr><th>0</th><td class="value">"bar"</td></tr></tbody></table>'
+				'<table class="mw-json"><tbody><tr><th>baz</th><td class="mw-json-value">"foo"</td></tr>' .
+				'<tr><th>0</th><td class="mw-json-value">"bar"</td></tr></tbody></table>'
 			],
 			[
 				(object)[ 'baz' => 1000, 'bar' ],
-				'<table class="mw-json"><tbody><tr><th>baz</th><td class="value">1000</td></tr>' .
-				'<tr><th>0</th><td class="value">"bar"</td></tr></tbody></table>'
+				'<table class="mw-json"><tbody><tr><th>baz</th><td class="mw-json-value">1000</td></tr>' .
+				'<tr><th>0</th><td class="mw-json-value">"bar"</td></tr></tbody></table>'
 			],
 			[
 				(object)[ '<script>alert("evil!")</script>' ],
-				'<table class="mw-json"><tbody><tr><th>0</th><td class="value">"' .
+				'<table class="mw-json"><tbody><tr><th>0</th><td class="mw-json-value">"' .
 				'&lt;script>alert("evil!")&lt;/script>"' .
 				'</td></tr></tbody></table>',
 			],
-- 
2.20.1