From aad0185da5269da7e059be9f1fabfb8b3ccffb87 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Thu, 13 Feb 2014 19:19:22 +0100 Subject: [PATCH] mediawiki.jqueryMsg: Deprecate window.gM The comment already said it was. Make this more obvious with mw.log.deprecate. Change-Id: I60af043eb7a136a0f52618fdbc9bb76b17788b83 --- resources/mediawiki/mediawiki.jqueryMsg.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/resources/mediawiki/mediawiki.jqueryMsg.js b/resources/mediawiki/mediawiki.jqueryMsg.js index e4a9316fde..5f20ee40d8 100644 --- a/resources/mediawiki/mediawiki.jqueryMsg.js +++ b/resources/mediawiki/mediawiki.jqueryMsg.js @@ -1174,11 +1174,13 @@ return this.language.convertNumber( number, isInteger ); } }; + // Deprecated! don't rely on gM existing. // The window.gM ought not to be required - or if required, not required here. // But moving it to extensions breaks it (?!) // Need to fix plugin so it could do attributes as well, then will be okay to remove this. - window.gM = mw.jqueryMsg.getMessageFunction(); + // @deprecated since 1.23 + mw.log.deprecate( window, 'gM', mw.jqueryMsg.getMessageFunction(), 'Use mw.message( ... ).parse() instead' ); /** * @method -- 2.20.1