From 89688d6ce0a586a45ec6634fba306fdbba481127 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Wed, 8 Aug 2012 01:54:34 +0200 Subject: [PATCH] (bug 38987) mediawiki.api.parse.test: Fix test breakage The direct html comparison is not stable enough due to interference if Tidy. Working around by doing a dom comparison instead of raw html. Change-Id: I62e39e0b05e3f9b5f78e2ac28a6f3ca0b608d152 --- .../mediawiki.api/mediawiki.api.parse.test.js | 20 +++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/tests/qunit/suites/resources/mediawiki.api/mediawiki.api.parse.test.js b/tests/qunit/suites/resources/mediawiki.api/mediawiki.api.parse.test.js index f33edb02db..3d3f630f60 100644 --- a/tests/qunit/suites/resources/mediawiki.api/mediawiki.api.parse.test.js +++ b/tests/qunit/suites/resources/mediawiki.api/mediawiki.api.parse.test.js @@ -1,17 +1,25 @@ QUnit.module( 'mediawiki.api.parse', QUnit.newMwEnvironment() ); -QUnit.asyncTest( 'Simple', function ( assert ) { +QUnit.asyncTest( 'Hello world', function ( assert ) { var api; - QUnit.expect( 1 ); + QUnit.expect( 6 ); api = new mw.Api(); api.parse( "'''Hello world'''" ) .done( function ( html ) { - // Html also contains "NewPP report", so only check the first part - assert.equal( html.substr( 0, 25 ), '

Hello world

', - 'Wikitext to html parsing works.' - ); + // Parse into a document fragment instead of comparing HTML, due to + // presence of Tidy influencing whitespace. + // Html also contains "NewPP report" comment. + var $res = $( '
' ).html( html ).children(), + res = $res.get( 0 ); + assert.equal( $res.length, 1, 'Response contains 1 element' ); + assert.equal( res.nodeName.toLowerCase(), 'p', 'Response is a paragraph' ); + assert.equal( $res.children().length, 1, 'Response has 1 child element' ); + assert.equal( $res.children().get( 0 ).nodeName.toLowerCase(), 'b', 'Child element is a bold tag' ); + // Trim since Tidy may or may not mess with the spacing here + assert.equal( $.trim( $res.text() ), 'Hello world', 'Response contains given text' ); + assert.equal( $res.find( 'b' ).text(), 'Hello world', 'Bold tag wraps the entire, same, text' ); QUnit.start(); }); -- 2.20.1