From 1647bb07fcc6c590087b286160592db5d2f36713 Mon Sep 17 00:00:00 2001 From: umherirrender Date: Mon, 7 Dec 2015 17:38:28 +0100 Subject: [PATCH] Fix phpunit for wikis with $wgResourceLoaderValidateJS = false 1) ResourceLoaderModuleTest::testValidateScriptFile Replace invalid syntax with error logging Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'var a = 'this is'; - { -invalid' +'mw.log.error("JavaScript parse error: Parse error: Unexpected token; token } expected in file 'input' on line 3");' Change-Id: I0271de4bf2d5bcc50eaf5c0e999e16e554985805 --- .../includes/resourceloader/ResourceLoaderModuleTest.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/phpunit/includes/resourceloader/ResourceLoaderModuleTest.php b/tests/phpunit/includes/resourceloader/ResourceLoaderModuleTest.php index f700348348..c49d70123c 100644 --- a/tests/phpunit/includes/resourceloader/ResourceLoaderModuleTest.php +++ b/tests/phpunit/includes/resourceloader/ResourceLoaderModuleTest.php @@ -69,6 +69,8 @@ class ResourceLoaderModuleTest extends ResourceLoaderTestCase { * @covers ResourceLoaderModule::validateScriptFile */ public function testValidateScriptFile() { + $this->setMwGlobals( 'wgResourceLoaderValidateJS', true ); + $context = $this->getResourceLoaderContext(); $module = new ResourceLoaderTestModule( array( -- 2.20.1