Tim Starling [Sat, 20 Sep 2008 07:55:14 +0000 (07:55 +0000)]
Fixed two patrol bugs:
* Return of ID instead of object from notifyNew() caused markPatrolled() to fail when the master and slave are different connections
* doMarkPatrolled() incorrectly checked for the patrol right instead of the autopatrol right when automatic patrol was requested.
Also fixed some formatting, more needed.
Aaron Schulz [Sat, 20 Sep 2008 07:31:44 +0000 (07:31 +0000)]
Add missing wfProfileOut( __METHOD__ );
Victor Vasiliev [Sat, 20 Sep 2008 07:22:33 +0000 (07:22 +0000)]
Add class to rows so admins can hide groups from Special:Statistics.
Aaron Schulz [Sat, 20 Sep 2008 06:52:01 +0000 (06:52 +0000)]
Fix regression from r40636: footer is now parsed again
Tim Starling [Sat, 20 Sep 2008 06:18:43 +0000 (06:18 +0000)]
Don't double-escape search terms before highlighting. It's done once already SearchResultSet::termMatches(). Doing it twice results in / -> \/ -> \\/, literal backslash followed by end of regex. Not obvious in SearchMySQL because of stripForSearch(), but visible in MWSearch.
The fact that it's done in termMatches() already is hackish and undocumented, but I won't change it right now.
Tim Starling [Sat, 20 Sep 2008 05:44:29 +0000 (05:44 +0000)]
Fixed warning. QueryPage subclasses are required to allow construction with no constructor parameters. This property is used by maintenance/updateSpecialPages.php.
Tim Starling [Sat, 20 Sep 2008 05:32:30 +0000 (05:32 +0000)]
Fix fatal error, addNewUserLogEntryAutoCreate is invoked non-statically from CentralAuth and uses $this
Chad Horohoe [Sat, 20 Sep 2008 04:04:51 +0000 (04:04 +0000)]
+doc
Chad Horohoe [Sat, 20 Sep 2008 03:57:16 +0000 (03:57 +0000)]
Lots of doc updates. Documented where I knew what it did. Added @see parameters to all of these wrappers for doxygen.
Tim Starling [Sat, 20 Sep 2008 03:49:48 +0000 (03:49 +0000)]
Remove rage, looks unprofessional.
Chad Horohoe [Sat, 20 Sep 2008 03:44:09 +0000 (03:44 +0000)]
Fix more doxygen stuff.
Tim Starling [Sat, 20 Sep 2008 02:55:02 +0000 (02:55 +0000)]
Reverted r40719, plainly flawed, for instance the hard-coded references to index.php have no place if the point is to make it work for other entry points.
Brion Vibber [Sat, 20 Sep 2008 00:05:04 +0000 (00:05 +0000)]
wrap some long lines
Chad Horohoe [Fri, 19 Sep 2008 19:06:57 +0000 (19:06 +0000)]
Cleanup to r41041. escape-noentities => escapenoentities
Chad Horohoe [Fri, 19 Sep 2008 18:56:20 +0000 (18:56 +0000)]
+4 docs, -4 @todo's
Brion Vibber [Fri, 19 Sep 2008 18:47:47 +0000 (18:47 +0000)]
Quickie example adding $wgLang->commaList() to encapsulate use of 'comma-separator' message.
Fixme: being in a hurry, I didn't make it work correctly for non-UI languages. It should grab from the appropriate lang, not just wfMsgExt.
Brion Vibber [Fri, 19 Sep 2008 17:13:06 +0000 (17:13 +0000)]
Drop $wgDBminWordLen from DefaultSettings.php -- hasn't been used since 1.6 dropped MySQL 3.x support.
Aaron Schulz [Fri, 19 Sep 2008 13:49:10 +0000 (13:49 +0000)]
opps, use trim() instead
Aaron Schulz [Fri, 19 Sep 2008 13:46:26 +0000 (13:46 +0000)]
Tweak edit comment space
Chad Horohoe [Fri, 19 Sep 2008 13:39:30 +0000 (13:39 +0000)]
Add accessor to $rootElement, rather than accessing it directly.
Aaron Schulz [Fri, 19 Sep 2008 11:42:24 +0000 (11:42 +0000)]
Clean up inDnsBlacklist()
Aaron Schulz [Fri, 19 Sep 2008 10:13:32 +0000 (10:13 +0000)]
Remove some individual transactions
Chad Horohoe [Fri, 19 Sep 2008 00:21:03 +0000 (00:21 +0000)]
Fix some doxygen stuff.
Aaron Schulz [Fri, 19 Sep 2008 00:11:41 +0000 (00:11 +0000)]
* Clean up patrol code to not possibly log twice (depended on slave lag)
* Make notifyEdit() return the whole RC object
* Spacing tweaks
* Wrap patrolling in a transaction
Aaron Schulz [Thu, 18 Sep 2008 23:43:41 +0000 (23:43 +0000)]
Wrap $log->addEntry() in transaction
Aaron Schulz [Thu, 18 Sep 2008 21:48:55 +0000 (21:48 +0000)]
Tweak report
Alex Z [Thu, 18 Sep 2008 21:30:51 +0000 (21:30 +0000)]
*Don't let the API action=protect set actions that aren't in $wgRestrictionTypes or levels not in $wgRestrictionLevels
*Pass an array to Article::updateRestrictions for the expiry. Though it should allow for separate expiry times, like the normal UI.
Aaron Schulz [Thu, 18 Sep 2008 21:12:29 +0000 (21:12 +0000)]
improve log dupe check
Aaron Schulz [Thu, 18 Sep 2008 20:56:49 +0000 (20:56 +0000)]
Comment out log_user_text stuff for now
Aaron Schulz [Thu, 18 Sep 2008 20:52:34 +0000 (20:52 +0000)]
* Add support for log importing
* Improve accuracy of revision duplicate check
* Some minor cleanup and re-organizing
Alex Z [Thu, 18 Sep 2008 20:28:52 +0000 (20:28 +0000)]
(bug 12678) Don't show the upload link in the toolbox if the user is not allowed to upload.
Brion Vibber [Thu, 18 Sep 2008 19:38:56 +0000 (19:38 +0000)]
Back out r41001 for the moment ("Add log_user_text. Useful for log dumps, which are needed by rev_deleted")
If applied in one piece, it should probably fill in log_user_text... but that would be very slow in production environments.
If it has to be able to work with an online update in production, it should probably allow for a NULL log_user_text value rather than '', which is eery
Alexandre Emsenhuber [Thu, 18 Sep 2008 19:18:22 +0000 (19:18 +0000)]
Readd the note about the schema changes since there are some since 1.13 now
Aaron Schulz [Thu, 18 Sep 2008 19:15:18 +0000 (19:15 +0000)]
title -> logtitle
Aaron Schulz [Thu, 18 Sep 2008 18:26:54 +0000 (18:26 +0000)]
Add log_user_text. Useful for log dumps, which are needed by rev_deleted
Brion Vibber [Thu, 18 Sep 2008 17:11:51 +0000 (17:11 +0000)]
Revert r40953 '(bug 7509) Don't hardcode separation strings, make them configurable'
This seems to make code much uglier and harder to maintain -- there are a bajillion new calls to "wfMsgExt( 'pipe-separator' , 'escapenoentities' )" which is not trivial or easy to remember. This makes code uglier, harder to read, harder to maintain, and more prone to error.
Brion Vibber [Thu, 18 Sep 2008 17:01:36 +0000 (17:01 +0000)]
Cleanup for r40944:
* Break up giant long incomprehensible line
* Use SpecialPage::getTitleFor() rather than Title::newFromText() so we get proper localization of special page name
* No need to pass 'block' to Special:Log twice; just put it in the query to match actual paging behavior
* HTML-escape the blocklog-fulllog message for good measure
* No need to pass 'known' option to linker -- it knows that Special: pages are good
Aaron Schulz [Thu, 18 Sep 2008 16:41:43 +0000 (16:41 +0000)]
* Move Import stuff to it's own file like Export
* Force logging index
* Some code style tweaks
* Set visibility in some places
Rotem Liss [Thu, 18 Sep 2008 16:26:44 +0000 (16:26 +0000)]
Localization update.
Greg Sabino Mullane [Thu, 18 Sep 2008 15:19:44 +0000 (15:19 +0000)]
Duplicate code
Chad Horohoe [Thu, 18 Sep 2008 02:54:27 +0000 (02:54 +0000)]
Add id to file delete confirmation form.
Aaron Schulz [Thu, 18 Sep 2008 00:02:57 +0000 (00:02 +0000)]
* Add XML log dump support
* TODO: make importer
Roan Kattouw [Wed, 17 Sep 2008 18:49:22 +0000 (18:49 +0000)]
API: Adding APIAfterExecute, APIQueryAfterExecute and APIQueryGeneratorAfterExecute hooks to make extending core modules possible in a cleaner way
Alexandre Emsenhuber [Wed, 17 Sep 2008 18:41:40 +0000 (18:41 +0000)]
RELEASE-NOTES entry for my last commit
Alexandre Emsenhuber [Wed, 17 Sep 2008 18:36:49 +0000 (18:36 +0000)]
Fix for r40937 (and per talk with brion): merge the RenderHash extension in core
Alexandre Emsenhuber [Wed, 17 Sep 2008 14:26:43 +0000 (14:26 +0000)]
fix some doxygen warnings
Aaron Schulz [Wed, 17 Sep 2008 12:36:44 +0000 (12:36 +0000)]
Bah, revert to r40753
Aaron Schulz [Wed, 17 Sep 2008 12:31:57 +0000 (12:31 +0000)]
*Should need to escape twice
*Use single quotes on windows, as it goes to cygwin
Siebrand Mazeland [Wed, 17 Sep 2008 09:41:51 +0000 (09:41 +0000)]
(bug 7509) Don't hardcode separation strings, make them configurable
* Introduced message 'pipe-separator' to replace many occurrence of " | ". No changes made in skin "Nostalgia".
Siebrand Mazeland [Wed, 17 Sep 2008 07:31:39 +0000 (07:31 +0000)]
Localisation updates for core messages from Betawiki
Andrew Garrett [Wed, 17 Sep 2008 07:26:34 +0000 (07:26 +0000)]
Work around misconfiguration by requiring strict comparisons for in_array in User::isAllowed(). See wikitech-l.
Siebrand Mazeland [Wed, 17 Sep 2008 06:15:58 +0000 (06:15 +0000)]
X! [Wed, 17 Sep 2008 02:50:03 +0000 (02:50 +0000)]
Readding 'Full Block Log' link, after being removed for not using Linker function.
Patch submitted by Matt Johnston, in bug 14638
Brion Vibber [Tue, 16 Sep 2008 21:14:25 +0000 (21:14 +0000)]
* (bug 10463) Apply $wgRenderHashAppend to sitenotice cache keys so SSL and non-SSL sites get separate notice caches.
This seems to be a little funny, though, at least on commons -- the commonswiki:sitenotice:https=1 key is just storing 'false' so it presumably gets reparsed on each run. I can't see any way that this should be happening, which is a little intimidating...
Siebrand Mazeland [Tue, 16 Sep 2008 20:55:18 +0000 (20:55 +0000)]
Update message files for r40916. Is "php rebuildLanguage.php --lang=all" that hard?
Chad Horohoe [Tue, 16 Sep 2008 19:19:12 +0000 (19:19 +0000)]
Remove two useless classes from HTMLDiff. One was entirely unused and useless, and the other was a wrapper for a more simple solution.
Alexandre Emsenhuber [Tue, 16 Sep 2008 19:09:27 +0000 (19:09 +0000)]
* Added $wgUseMetadataEdit and $wgMetadataWhitelist to DefaultSettings.php, they exist since r6887.
* Fixed two E_NOTICE while editing a page with $wgUseMetadataEdit = true;
Alex Z [Tue, 16 Sep 2008 18:46:58 +0000 (18:46 +0000)]
Tweak to ProtectionForm: Title::getRestrictionExpiry returns 'infinity' for 'infinite'
Aaron Schulz [Tue, 16 Sep 2008 18:45:19 +0000 (18:45 +0000)]
* Add transaction to undelete
* Avoid some dupe key errors. They should silently be corrected. (bug 14149)
Aaron Schulz [Tue, 16 Sep 2008 18:39:13 +0000 (18:39 +0000)]
Avoid undefined var errors if data fetch fails
Alex Z [Tue, 16 Sep 2008 18:31:55 +0000 (18:31 +0000)]
*Re-implement r40723 in Article::view()
*Slight fix to EditPage following r40899
Aaron Schulz [Tue, 16 Sep 2008 17:08:08 +0000 (17:08 +0000)]
* Make sure we have the right article ID, not slave lagged. (bug 8072)
* Make FileDeleteForm use hook properly
Aaron Schulz [Tue, 16 Sep 2008 16:55:49 +0000 (16:55 +0000)]
minor refactoring
Rotem Liss [Tue, 16 Sep 2008 15:56:03 +0000 (15:56 +0000)]
Localization: Split the delete, rollback and protect messages into three sections (no change in the text).
Rotem Liss [Tue, 16 Sep 2008 15:50:40 +0000 (15:50 +0000)]
Localization update.
Rotem Liss [Tue, 16 Sep 2008 15:50:28 +0000 (15:50 +0000)]
Fix.
Aaron Schulz [Tue, 16 Sep 2008 13:29:01 +0000 (13:29 +0000)]
* Deal with new page move scenario (bug 3481)
* Move cat count stuff down in transaction for bug 13921
Aaron Schulz [Tue, 16 Sep 2008 12:47:44 +0000 (12:47 +0000)]
* Remove unneeded code
* Whitespace
Aaron Schulz [Tue, 16 Sep 2008 12:06:40 +0000 (12:06 +0000)]
This is indexed now, do live. (bug 3945)
Siebrand Mazeland [Tue, 16 Sep 2008 11:29:29 +0000 (11:29 +0000)]
Localisation updates for core messages from Betawiki (2008-09-16 12:46 CEST)
Siebrand Mazeland [Tue, 16 Sep 2008 11:27:44 +0000 (11:27 +0000)]
Add 'protect-existing-expiry'
Aaron Schulz [Tue, 16 Sep 2008 10:39:30 +0000 (10:39 +0000)]
whitespace tweaks
Tim Starling [Tue, 16 Sep 2008 09:42:31 +0000 (09:42 +0000)]
Revert r40723, and associated i18n. Unexpected side effects in Article::getContent(). Should be implemented in Article::view() if it's implemented at all.
Tim Starling [Tue, 16 Sep 2008 06:13:31 +0000 (06:13 +0000)]
Fixed documentation. Don't use empty() to determine if an array has zero length, that's not what it does.
Tim Starling [Tue, 16 Sep 2008 05:56:43 +0000 (05:56 +0000)]
Revert r40627, r40551, r40536, r40535 (mark non-autoconfirmed users in RC and watchlist with an orange asterisk). Potentially slow, potentially controversial, so it needs a configuration option to enable/disable it.
Tim Starling [Tue, 16 Sep 2008 05:21:10 +0000 (05:21 +0000)]
Revert revert r40717 of my formatting change r40416.
Tim Starling [Tue, 16 Sep 2008 04:59:49 +0000 (04:59 +0000)]
* Reverted code style change made by Aaron, "if (" -> "if("
* Use the convenience function selectRow() if you want a single row
* Move existence check for showDeletionLog() back to the caller, functions should do what their name says
* Revert r40674, $createRestrictions needs to be translated into some human language before it can be passed into a message. Also, note that "$a != array()" is equivalent to conversion to boolean if you know that the variable is an array.
Tim Starling [Tue, 16 Sep 2008 04:09:06 +0000 (04:09 +0000)]
In protect.js:
* Use fragments of English when naming things, instead of a jumble of words vaguely related to the topic
* Use verbs in function names that are related to what the functions do
* Move all functions into an object, to avoid prefixes that look like part of a nonsensical sentence
* Fixed a bug whereby the "move" controls would not be unlocked if the expiry times differed. Refactored the relevant code.
* When the user types something into the "other time" box, automatically select "other time" from the drop-down list.
In ProtectionForm:
* Use the new protect.js interface
* Use accessor instead of Title member variable mRestrictionsExpiry
* Added an "existing expiry" option to the expiry drop-down list, instead of putting the ISO 8601 time in the "other" box
* Formatting
* Fixed convoluted expiry time data flow, documented
* s/List/Selection, for variables containing a value that the user has selected from a list
X! [Tue, 16 Sep 2008 03:58:18 +0000 (03:58 +0000)]
(bug 15617)
$wgFeedClassesOutputPage::getHeadLinks() respects $wgFeedClasses, instead of hardcoding rss and atom.
Patch by Juliano F. Ravasi.
Aaron Schulz [Tue, 16 Sep 2008 01:38:03 +0000 (01:38 +0000)]
Undefined var error fix
Siebrand Mazeland [Mon, 15 Sep 2008 20:44:24 +0000 (20:44 +0000)]
* Fix common spelling error (seperate -> separate)
Siebrand Mazeland [Mon, 15 Sep 2008 20:38:27 +0000 (20:38 +0000)]
* Fix common spelling error (seperate -> separate)
Aaron Schulz [Mon, 15 Sep 2008 19:27:32 +0000 (19:27 +0000)]
Remove syntax typo that made line dupes
Rotem Liss [Mon, 15 Sep 2008 18:58:43 +0000 (18:58 +0000)]
Localization update for he.
Aaron Schulz [Mon, 15 Sep 2008 18:50:54 +0000 (18:50 +0000)]
Revert r40808. No need to make log_params and output uglier due to edit comment limitations.
Brion Vibber [Mon, 15 Sep 2008 18:33:36 +0000 (18:33 +0000)]
Revert r40838 -- patch is very scary and builds its links bizarrely
Rotem Liss [Mon, 15 Sep 2008 18:09:04 +0000 (18:09 +0000)]
Localization update for he.
* Note: Some updates were already done and were overrided by BetaWiki updates. Please do not override updates anymore.
Brion Vibber [Mon, 15 Sep 2008 17:51:53 +0000 (17:51 +0000)]
Revert r40837, r40839, r40840 (bug 332 - broken UTF-8)
Char-by-char scan of all output will perform very poorly and fails to address the root problem of bad internal treatment of strings.
Chad Horohoe [Mon, 15 Sep 2008 17:40:12 +0000 (17:40 +0000)]
Minor cleanup (docs, visibilities, formatting)
Aaron Schulz [Mon, 15 Sep 2008 15:51:45 +0000 (15:51 +0000)]
Clean up OldChangesListRecentChangesLine hooks some. Better if triggers before li tag additions.
Siebrand Mazeland [Mon, 15 Sep 2008 11:50:15 +0000 (11:50 +0000)]
Put back a message I somehow accidentally removed. Thanks to Raimond for noticing.
Siebrand Mazeland [Mon, 15 Sep 2008 10:59:37 +0000 (10:59 +0000)]
Remove more leftovers from r35950
Daniel Kinzler [Mon, 15 Sep 2008 09:53:52 +0000 (09:53 +0000)]
bug #15602: use echo for error messages if STDERR is undefined
Siebrand Mazeland [Mon, 15 Sep 2008 09:28:17 +0000 (09:28 +0000)]
Remove leftovers from r35950 (reverted addition of special page Missingfiles) *grumble*
Tim Starling [Mon, 15 Sep 2008 06:37:57 +0000 (06:37 +0000)]
Revert r40712, replace_variables is correct.
Tim Starling [Mon, 15 Sep 2008 05:34:32 +0000 (05:34 +0000)]
Fix $user parameter to Article::doEdit(), which was broken for page creation (worked only for page updates).
Fran Rogers [Mon, 15 Sep 2008 05:04:16 +0000 (05:04 +0000)]
Reverted r40771 for now - causes problems with CentralAuth
Fran Rogers [Mon, 15 Sep 2008 01:37:50 +0000 (01:37 +0000)]
Release notes for bug #332
Fran Rogers [Mon, 15 Sep 2008 01:27:22 +0000 (01:27 +0000)]
Addendum to r40837: only validate/clean the body text, as we can assume the rest of the skin is valid.
X! [Mon, 15 Sep 2008 01:26:32 +0000 (01:26 +0000)]
(bug 14638)
Special:Blockip now provides a link to the block log if the user has been blocked more than 10 times.
Patch by Matt Johnston.